linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Matthew Wilcox <willy@infradead.org>,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux1394-devel@lists.sourceforge.net, linux-usb@vger.kernel.org,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, Juergen Gross <jgross@suse.com>,
	qla2xxx-upstream@qlogic.com,
	Kent Overstreet <kent.overstreet@gmail.com>
Subject: Re: [PATCH 0/3] Use sbitmap instead of percpu_ida
Date: Tue, 12 Jun 2018 14:40:43 -0600	[thread overview]
Message-ID: <f7a9f7ad-843f-58fc-68f0-79dfd4019c18@kernel.dk> (raw)
In-Reply-To: <20180612190545.10781-1-willy@infradead.org>

On 6/12/18 1:05 PM, Matthew Wilcox wrote:
> Removing the percpu_ida code nets over 400 lines of removal.  It's not
> as spectacular as deleting an entire architecture, but it's still a
> worthy reduction in lines of code.
> 
> Untested due to lack of hardware and not understanding how to set up a
> target platform.
> 
> Changes from v1:
>  - Fixed bugs pointed out by Jens in iscsit_wait_for_tag()
>  - Abstracted out tag freeing as requested by Bart
>  - Made iscsit_wait_for_tag static as pointed out by 0day

Reviewed-by: Jens Axboe <axboe@kernel.dk>

-- 
Jens Axboe


  parent reply	other threads:[~2018-06-12 20:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12 19:05 [PATCH 0/3] Use sbitmap instead of percpu_ida Matthew Wilcox
2018-06-12 19:05 ` [PATCH 1/3] target: Abstract tag freeing Matthew Wilcox
2018-06-12 19:05 ` [PATCH 2/3] Convert target drivers to use sbitmap Matthew Wilcox
2018-06-12 19:05 ` [PATCH 3/3] Remove percpu_ida Matthew Wilcox
2018-06-12 20:06 ` [PATCH 0/3] Use sbitmap instead of percpu_ida Bart Van Assche
2018-06-12 20:40 ` Jens Axboe [this message]
2018-06-15  2:06 ` Martin K. Petersen
2018-06-15  2:37   ` Matthew Wilcox
2018-06-19  2:26     ` Martin K. Petersen
2018-06-15  7:37 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7a9f7ad-843f-58fc-68f0-79dfd4019c18@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=jgross@suse.com \
    --cc=kent.overstreet@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    --cc=qla2xxx-upstream@qlogic.com \
    --cc=target-devel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).