From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933803AbdKBPLb (ORCPT ); Thu, 2 Nov 2017 11:11:31 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:54250 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932724AbdKBPL1 (ORCPT ); Thu, 2 Nov 2017 11:11:27 -0400 Subject: Re: [PATCH v2 net-next 3/5] bpf, cgroup: implement eBPF-based device controller for cgroup v2 To: Roman Gushchin , References: <20171102145440.12986-1-guro@fb.com> <20171102145440.12986-4-guro@fb.com> CC: Tejun Heo , Alexei Starovoitov , Daniel Borkmann , , From: Alexei Starovoitov Message-ID: Date: Thu, 2 Nov 2017 08:11:07 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20171102145440.12986-4-guro@fb.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c090:180::1:a530] X-ClientProxiedBy: BN6PR1801CA0033.namprd18.prod.outlook.com (2603:10b6:405:5f::46) To CO1PR15MB0967.namprd15.prod.outlook.com (2a01:111:e400:7b64::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c7d1c800-6806-4b5f-f9aa-08d52203f4db X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603238);SRVR:CO1PR15MB0967; X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB0967;3:QOmsI3Jd9zsHe6w6r47yaBV4MRD652GDWIRZXveXH3itiWR2TyujQ1tx5raDpEiLd/NbhcSFr15gK4TLMTqlgVlW/gV+iHOnR+fsFCPxxCnyznNVBn2Ri7xcaQiBfxBF6G3DOek0poSGm2qM7LSaE8DvRlGj4F6PIBA5+n8fmE2FEovJGTNUVbPT5g/mhrdUe7Iswer1gzT6QPHBQNhByfVeq5CKuyhIrDI5xLy/qgKmoc9d3/N4s5wAcf1ER5nU;25:VDZSGpE6WwpWSsxh+h8tfoCIxALp7GTALSZxyLSGLjaUUfS7DrAMde5yrsDEAFjhl8bD/uMCcFRURwvQl01YX5iVxwvTuhUV/v+R60SyOAgm093j+pbkSQq8dOZC6pkLfC6rk8+7FPTE9OL+Za8gEP6QHqo+xEckiDguHv7Hi0ILWfFmD5SXdg4y5ti0ceTkhbXY476z4Sge0MvpF8MY4Pq/DDDRZTVERC4n2T2rVtBMwrmdJvU6wpPvC/GbYpTHd8IEE1rqZg2ip6gBwX/0gZ7xUmj0tm6qmugn0SFJB8kWVaBuNJtyk+yrPRWLfavNkwaH6He2J5AeVUfPNykJ8g==;31:dgZFwg1L52BJ4WaUe7PNQBZcBtZLUu80TDigTtZ4Rez7M7Khi22I9lsqq1uAJXW7Miw7ca2IJAwsO0Ps9JcPkFvA/8lQYWciyk7iJlC7vkdaB8WMFyaRFjNZoGGwePQ7d59tpMV/127ANykSUYqPEBWtD44lv4QnekZoYARqxrqKRx02XTKEFP0aNO5mA8wugdWc15q7DiGyKisN0jYzxVJA4cklbjIYzw44Vwh/TSw= X-MS-TrafficTypeDiagnostic: CO1PR15MB0967: X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB0967;20:NWzogRwh2jlJi+PIHG+b87Hx+QgOjmkCED42Xy3qOimif9o6TUvHni5fHHZhemCIW6e6+MJ60+KfhPLBsb6ZLv/HcJWYBCXyjZU7lJKIaeS/WkvnBxXnflKN8+Ssj/aBptZL3pYhFaCFSQQRrQRmjzsbJ7vPdj66RIL+Us3jmhWuVRes2UAOvJzZMVbn6ZehGbX3FG7YCE32nWNSFvEsHrl30zjn8CbQWDEP58a43xyOHCYmL6DucF5HywygNmo3E26m4Bkhsmu49CoMFzpg+J8pDp62zwA3fhP8THMXgPr2O92yKWzwvl20JBgjsoR7kX4cCp5w9odfj2KdtUle/PFD6XDLFiij7k8Q/Os0XPmjxuntulP4YHKvF0njpYzSXJWGMOfPEyKunZH2xWcHdcRLuMmu86cb2LgEZ28jbBFugehP3YoJFY+gC8ZK5IZ9r2kgZ7w3Pa3TzaCX5sSQDv8nP3cmiv2OEA/SaznudYrA5FPfY7wk4n/jK5v/8rMc;4:+jCEN7QVt0upoj7YGKG8sbJ1NJV0kw+QjeoRGlxVyxG5vyz/5gaHKN3YIV0L/uK8ehgI5ZKbIs5XeuY5YmqItRUOxhr+R0kgKlZomA4+nAXYimTULRPldDKMSmNkWqKw/zyHJxJPhA7uy6k+dUu88+/0lmKpDvj+lXp0XmX1lhFOO7vUopm1WmvLDElTN/j2o37aNqpW7RKkNh8JYXxCKBZu33GoinEr5gzUrn3/JSAZ5xc6Ec5rGy/IdAUeAVu+lw9mzKhwPyxJShnLLTXSQA== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(11241501159)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(3231020)(3002001)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CO1PR15MB0967;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CO1PR15MB0967; X-Forefront-PRVS: 047999FF16 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(189002)(199003)(24454002)(31686004)(54906003)(53936002)(83506002)(478600001)(6246003)(305945005)(8936002)(316002)(105586002)(58126008)(106356001)(31696002)(86362001)(67846002)(6486002)(65806001)(2950100002)(65956001)(47776003)(25786009)(64126003)(4326008)(23746002)(81156014)(65826007)(229853002)(50986999)(54356999)(76176999)(189998001)(50466002)(68736007)(6116002)(6666003)(53546010)(33646002)(97736004)(81166006)(2906002)(7736002)(36756003)(5660300001)(1706002)(101416001)(230700001)(8676002)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:CO1PR15MB0967;H:[IPv6:2620:10d:c081:1131::112d];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CO1PR15MB0967;23:Pdw1bkgaLbv5aDN27YXq0qwXebwtW3WqxOMBq?= =?Windows-1252?Q?sFPDPvBHJUZxmjhxIcyNdfxTzmO7aUa7afMyMPoZ5DDUYcbSVOd1gE+0?= =?Windows-1252?Q?GsKdXXxHRfhur73CCNDojs4na/eNfArm4U+PYKcN+AyWmWAKfH45xYkL?= =?Windows-1252?Q?jLGRAfAvAVaGg2DOYnlF8sRH14URzXzodssLgwahYaJ8dUuomls1fcUL?= =?Windows-1252?Q?a/eApqyOX8+O3Y4e4LTjLMamys5RJxslIp2prF27yVIEnEK1kvmj1Has?= =?Windows-1252?Q?k3UKi4HauFwE/8wv+aatjidhSakoKNjDaFp/onq2JHxCpCQbzbG8+7Zq?= =?Windows-1252?Q?8BFlpjoJxgGzF+0neWKb399mq8MYvIRXVIJx6PRAdT4oQcGPlXcf/H6w?= =?Windows-1252?Q?lId010WJSdNlSKylUjbsN9Fchxp0ZkKpgCSJ+wHqUXCbYDTRP0KzjYKP?= =?Windows-1252?Q?DnhGdqokYuHSTjwXmi8tZJwI7TiGRhwjWLL80NjlUXsRtyGe8zlv2L63?= =?Windows-1252?Q?8hFEdL8sdLTb6azGaKKD/85+ZYywejwrkjPef0X2FFFw03vR6molXPgT?= =?Windows-1252?Q?ixDI8Jr8hjH5Jnos3cU1PxrlaHaI3bF4y1iJ/QZU3O0wufURFcvo1LBb?= =?Windows-1252?Q?nfn9w6U2XCagoP2XCUMpVejqb9nWxs8YdjcWzbdWsRMvIYg1sArReoIZ?= =?Windows-1252?Q?5ziUFVZ2xmAJy5cR++mLeN5ByU0SLcCEz9GANKR/fdYSNIXx0TUxPDaN?= =?Windows-1252?Q?uzEk5X0XzPkYifZYporr6auJdpwHwoPWTBQGNIlqiTFsuCzXBNFS0zZR?= =?Windows-1252?Q?1vq+44mIJvO7h0fHoDWpu+nshu1TiSyRI20S9km2YtTCArBNqj8UM99D?= =?Windows-1252?Q?p73NlWy2mTTWFoJy0i1eLKndZfUaD+AkMS5ET3/Z5QO4tRR+x27odnqv?= =?Windows-1252?Q?CNy8q6rWauv6rULeah1CDIH+DFN+FrI3DvoikaO9TkS2/VCo800S3ayG?= =?Windows-1252?Q?f+LDcEKLnaBKOianxNxZC+sdxSXVnYiShZFYTF88ctiU/Ck/7Q9l6TS+?= =?Windows-1252?Q?qpP3mLlqtBE+sZBGH0DDU5Fx9MbgwCCIJc2KWHGuboTz1ZHgETbh/6mw?= =?Windows-1252?Q?DyXhqLB3NxOqZMzGiseXqEeQ/+1wEVaMs5+aHsoF5/ysKYVwxSn/YDEX?= =?Windows-1252?Q?+H2b5J0mZ9xc0JfZomzouOKCdwUG705EIut6Zz0Ejf9k6rc1oLJN9CXe?= =?Windows-1252?Q?/pOKE2ETZ4kkMZPiWrhpoK6ZMObLLzbX1dFX1z5EwZYTzfqQlOoQWCKL?= =?Windows-1252?Q?mZDZIShYyqO9TCI3FSss7fxM1sNPzBGlNc/eor4YY9FGy0=3D?= X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB0967;6:+ZUTGj7UZNwBPLqPlnuZOotPYxlfvXPElmGd91aGL6DX9HKQ17oEk1B1T1ilus3iaNcffmXL6NNvu9I4nVgUebiN25OO2K0idAu8kdRo7sNlQxp2gqlJsDNlFz+fajuCBRd0vbSGoRJ0icdZbcJZv0f5NlZoGjaKgBX9uczYs9kVpR3WIjNl8ti0nefvjFa1gZtD3N26e4HSYDNe+HqmMXYlYStZsjwKOYSWa5H3PP+HqNqriOHzlgAmgvFohLdysD0mwJ9h9xgwBpCut976KbzRbJrVxLWVAIAf69gQbjd8heQW2b1z103lVpsRQ1fe+Js9CdvcKqGE2QFDCKzyIMeQp7bZqW+e5emUjREn4xA=;5:4GgtbRAfGvRvDcerjtuVSlK2O+g0Def72dgHzz3dqfuHpmxaX50cKcp30SypooEUr5IyupWaCc94NxLfVgioi9t0IOtG6IySkCvx4Tf1DE59ZT2JoOnlmXZtqdJuM1mGH1X52O3BigkoS1WLNwF5WFE50ZeA6/kdaulUm/R+IO8=;24:HkNaCsYOTq3ayElwWJLBuX2oU53CP2HCGdpeJdYbv3UwxslKgTR2DwLYO5Wg5jCB72F+oEUSbo9YkafWG2/C20XdV+rmA0246meTnB77Rvs=;7:yIzbwlTDCAexFIwjO+skQbOcVIn0gdzCphM1Jqxw1befHwsA9JpiGJX3Vb2OAFPYhkErA8uoq58hJ7Ko5E5Q6I1y2s7n4jeRqOqslnHKYvsTiym+Pnb0oSiQw2T01cKx4wYZeOSa9u9NE0iFJ8QmRZl/5qlg9lH5bQcABrqfuYG5hWLf+LQUh+UmvH4w1RjKHtqm/s+zSoBqWPOHeMCRLuVaEEknAyT2JEUlAgzvm/nCKkgV90CY8aQs/ccMy/da SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO1PR15MB0967;20:tgPlckEverD0J7D2DvMC5CJ6JSBsSgKVWCRxx7TBV+NyZCDAFHer8k4mtF9dQYPfp3Bv7Iind3ETVVx8VgSMcYqWLJdK10mSBWAW2L6iqqaj80GXqoPMb3NuLlAQC556pBkY72UaKz6v9qabobAxsk1QJ+rVocZlYbxovxQ1mb4= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2017 15:11:11.3283 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c7d1c800-6806-4b5f-f9aa-08d52203f4db X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR15MB0967 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-02_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/2/17 7:54 AM, Roman Gushchin wrote: > +#define DEV_BPF_ACC_MKNOD (1ULL << 0) > +#define DEV_BPF_ACC_READ (1ULL << 1) > +#define DEV_BPF_ACC_WRITE (1ULL << 2) > + > +#define DEV_BPF_DEV_BLOCK (1ULL << 0) > +#define DEV_BPF_DEV_CHAR (1ULL << 1) > + all macros in bpf.h start with BPF_ To be consistent with the rest can you rename above to BPF_DEVCG_.. ?