From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01707C433E1 for ; Thu, 27 Aug 2020 14:24:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCB8C2177B for ; Thu, 27 Aug 2020 14:24:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="VT257ly/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727786AbgH0OX4 (ORCPT ); Thu, 27 Aug 2020 10:23:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728191AbgH0OK4 (ORCPT ); Thu, 27 Aug 2020 10:10:56 -0400 Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51C28C061237 for ; Thu, 27 Aug 2020 07:10:52 -0700 (PDT) Received: by mail-il1-x142.google.com with SMTP id f12so4967278ils.6 for ; Thu, 27 Aug 2020 07:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=etGmff5kjea2pYumFvnmRUd62aXV3Jnz4zFc8MdNedw=; b=VT257ly/Gi/sHNPTYqDt3YpqbEVFt/d4BM9TRuMzVg3+JUv1/v1DCMU7+QMWuChY8s b1p5uA8EnzQd8lo/7L/WuXpX234qc0mXNzM57pqrSHInoWgkqOLhM2UYewaqawhC8xs2 /JATaHIrv9gRN6q5OwyC0zpbV8MrYvPYfPRrgSUIY5c7xpj2AzHpQ+9GWbamAj53fWdn IeXDsh5FTtNMD5PrcA8140uRXbLsq0eEhyqWzzAwR/z3Hh16IW5HhkceWImTFcsjSh0N B4HSMRW2OuXRO1u3iXOEWUD/HUY/3yuxS1JX9rZ/y2txqPH0FqMoeouoQ7oGg5U+3kGI 219g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=etGmff5kjea2pYumFvnmRUd62aXV3Jnz4zFc8MdNedw=; b=kH3v6wv/fZ0i6FQHnfrZx0ZTc5e1WdWIl4R0gL8X2pSTraEBZVma1kpEqvO4o8jh+n dOEkdHif1LNLPWVO71eS0QcnRqadXKMmkWAzO5s1aY5c7iripP9mP/gMyNg8gNgczc6h YFi9VGq0jsKW9P66moVuj3ZM2D6jgpe1AFzaTkIzPPsIx/E9idGuviXucY0vY/FHL1Tr v9CFNLyYshJMeTPeYTSREG8DP5NOnBAvChhO60aF9/386QtrzpaYyoCfOxolE/F74rs+ uBTib2PlYbADHcsgbsXL7MaQa4qFj7QuEkevTjkR6ddTWhvepVK/Jad0lwcf5RHiWSAG Mp9Q== X-Gm-Message-State: AOAM530qB6PR/WYuVFdRXQiWeNUIsI20orQTXpPgR984W0U/9ex1ePMD UvMFaGIaq1Tnq4VOvVzAxUm/fg== X-Google-Smtp-Source: ABdhPJzM4CEH4kFINWPdYKqisNNlQjrNEp30gUUdhxYouGz8K5XQM7Wt2Ie5RxeKhyFHqad/dXvtng== X-Received: by 2002:a92:9181:: with SMTP id e1mr16756233ill.274.1598537451548; Thu, 27 Aug 2020 07:10:51 -0700 (PDT) Received: from [192.168.1.58] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id h18sm1235881iow.16.2020.08.27.07.10.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Aug 2020 07:10:50 -0700 (PDT) Subject: Re: [PATCH v5 0/3] io_uring: add restrictions to support untrusted applications and guests To: Stefano Garzarella Cc: Aleksa Sarai , Kernel Hardening , Jann Horn , io-uring@vger.kernel.org, Christian Brauner , linux-fsdevel@vger.kernel.org, Alexander Viro , Stefan Hajnoczi , linux-kernel@vger.kernel.org, Sargun Dhillon , Kees Cook , Jeff Moyer References: <20200827134044.82821-1-sgarzare@redhat.com> <2ded8df7-6dcb-ee8a-c1fd-e0c420b7b95d@kernel.dk> <20200827141002.an34n2nx6m4dfhce@steredhat.lan> From: Jens Axboe Message-ID: Date: Thu, 27 Aug 2020 08:10:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200827141002.an34n2nx6m4dfhce@steredhat.lan> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/27/20 8:10 AM, Stefano Garzarella wrote: > On Thu, Aug 27, 2020 at 07:50:44AM -0600, Jens Axboe wrote: >> On 8/27/20 7:40 AM, Stefano Garzarella wrote: >>> v5: >>> - explicitly assigned enum values [Kees] >>> - replaced kmalloc/copy_from_user with memdup_user [kernel test robot] >>> - added Kees' R-b tags >>> >>> v4: https://lore.kernel.org/io-uring/20200813153254.93731-1-sgarzare@redhat.com/ >>> v3: https://lore.kernel.org/io-uring/20200728160101.48554-1-sgarzare@redhat.com/ >>> RFC v2: https://lore.kernel.org/io-uring/20200716124833.93667-1-sgarzare@redhat.com >>> RFC v1: https://lore.kernel.org/io-uring/20200710141945.129329-1-sgarzare@redhat.com >>> >>> Following the proposal that I send about restrictions [1], I wrote this series >>> to add restrictions in io_uring. >>> >>> I also wrote helpers in liburing and a test case (test/register-restrictions.c) >>> available in this repository: >>> https://github.com/stefano-garzarella/liburing (branch: io_uring_restrictions) >>> >>> Just to recap the proposal, the idea is to add some restrictions to the >>> operations (sqe opcode and flags, register opcode) to safely allow untrusted >>> applications or guests to use io_uring queues. >>> >>> The first patch changes io_uring_register(2) opcodes into an enumeration to >>> keep track of the last opcode available. >>> >>> The second patch adds IOURING_REGISTER_RESTRICTIONS opcode and the code to >>> handle restrictions. >>> >>> The third patch adds IORING_SETUP_R_DISABLED flag to start the rings disabled, >>> allowing the user to register restrictions, buffers, files, before to start >>> processing SQEs. >>> >>> Comments and suggestions are very welcome. >> >> Looks good to me, just a few very minor comments in patch 2. If you >> could fix those up, let's get this queued for 5.10. >> > > Sure, I'll fix the issues. This is great :-) Thanks! I'll pull in your liburing tests as well once we get the kernel side sorted. -- Jens Axboe