* [PATCH] ALSA: hda/realtek: Enable speaker and mute LEDs for HP laptops
@ 2022-07-19 14:20 Kai-Heng Feng
2022-07-19 15:26 ` Lucas Tanure
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Kai-Heng Feng @ 2022-07-19 14:20 UTC (permalink / raw)
To: tiwai
Cc: Kai-Heng Feng, Jaroslav Kysela, Tim Crawford, Werner Sembach,
Meng Tang, Lucas Tanure, Cameron Berkenpas, Kailang Yang,
Stefan Binding, Andy Chi, Yong Wu, alsa-devel, linux-kernel
Two more HP laptops that use cs35l41 AMP for speaker and GPIO for mute
LEDs.
So use the existing quirk to enable them accordingly.
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
sound/pci/hda/patch_realtek.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 2f55bc43bfa9c..cdbee71e83216 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9109,6 +9109,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x89c3, "Zbook Studio G9", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
+ SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+ SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED),
--
2.36.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Enable speaker and mute LEDs for HP laptops
2022-07-19 14:20 [PATCH] ALSA: hda/realtek: Enable speaker and mute LEDs for HP laptops Kai-Heng Feng
@ 2022-07-19 15:26 ` Lucas Tanure
2022-07-20 2:07 ` Kai-Heng Feng
2022-07-21 15:50 ` Lucas Tanure
2022-07-25 6:38 ` Takashi Iwai
2 siblings, 1 reply; 6+ messages in thread
From: Lucas Tanure @ 2022-07-19 15:26 UTC (permalink / raw)
To: Kai-Heng Feng, tiwai
Cc: Stefan Binding, Kailang Yang, linux-kernel, Meng Tang,
alsa-devel, Werner Sembach, Tim Crawford, Andy Chi,
Cameron Berkenpas, Yong Wu
On 7/19/22 15:20, Kai-Heng Feng wrote:
> Two more HP laptops that use cs35l41 AMP for speaker and GPIO for mute
> LEDs.
>
> So use the existing quirk to enable them accordingly.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> sound/pci/hda/patch_realtek.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 2f55bc43bfa9c..cdbee71e83216 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9109,6 +9109,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x89c3, "Zbook Studio G9", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> + SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
> SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED),
Hi,
Can you send us the ACPI dump (DSDT file) for review for both laptops?
We want to ensure that the ACPI has the correct information so the
driver will work properly.
Thanks
Lucas Tanure
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Enable speaker and mute LEDs for HP laptops
2022-07-19 15:26 ` Lucas Tanure
@ 2022-07-20 2:07 ` Kai-Heng Feng
2022-07-21 15:49 ` Lucas Tanure
0 siblings, 1 reply; 6+ messages in thread
From: Kai-Heng Feng @ 2022-07-20 2:07 UTC (permalink / raw)
To: Lucas Tanure
Cc: tiwai, Stefan Binding, Kailang Yang, linux-kernel, Meng Tang,
alsa-devel, Werner Sembach, Tim Crawford, Andy Chi,
Cameron Berkenpas, Yong Wu
[-- Attachment #1: Type: text/plain, Size: 1962 bytes --]
On Tue, Jul 19, 2022 at 11:27 PM Lucas Tanure
<tanureal@opensource.cirrus.com> wrote:
>
>
> On 7/19/22 15:20, Kai-Heng Feng wrote:
> > Two more HP laptops that use cs35l41 AMP for speaker and GPIO for mute
> > LEDs.
> >
> > So use the existing quirk to enable them accordingly.
> >
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> > ---
> > sound/pci/hda/patch_realtek.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > index 2f55bc43bfa9c..cdbee71e83216 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -9109,6 +9109,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> > SND_PCI_QUIRK(0x103c, 0x89c3, "Zbook Studio G9", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> > + SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> > + SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
> > SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED),
>
> Hi,
>
> Can you send us the ACPI dump (DSDT file) for review for both laptops?
As attachment.
>
> We want to ensure that the ACPI has the correct information so the
> driver will work properly.
One thing we noticed recently is that _all_ systems that are equipped
with cs35l41 have rather weak speaker output.
Sound is barely audible when the volume is around 50%.
Kai-Heng
>
> Thanks
>
> Lucas Tanure
>
[-- Attachment #2: DSDT-8ad2 --]
[-- Type: application/octet-stream, Size: 244908 bytes --]
[-- Attachment #3: DSDT-8ad1 --]
[-- Type: application/octet-stream, Size: 244908 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Enable speaker and mute LEDs for HP laptops
2022-07-20 2:07 ` Kai-Heng Feng
@ 2022-07-21 15:49 ` Lucas Tanure
0 siblings, 0 replies; 6+ messages in thread
From: Lucas Tanure @ 2022-07-21 15:49 UTC (permalink / raw)
To: Kai-Heng Feng
Cc: tiwai, Stefan Binding, Kailang Yang, linux-kernel, Meng Tang,
alsa-devel, Werner Sembach, Tim Crawford, Andy Chi,
Cameron Berkenpas, Yong Wu, patches
On 7/20/22 03:07, Kai-Heng Feng wrote:
> On Tue, Jul 19, 2022 at 11:27 PM Lucas Tanure
> <tanureal@opensource.cirrus.com> wrote:
>>
>> On 7/19/22 15:20, Kai-Heng Feng wrote:
>>> Two more HP laptops that use cs35l41 AMP for speaker and GPIO for mute
>>> LEDs.
>>>
>>> So use the existing quirk to enable them accordingly.
>>>
>>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>>> ---
>>> sound/pci/hda/patch_realtek.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>>> index 2f55bc43bfa9c..cdbee71e83216 100644
>>> --- a/sound/pci/hda/patch_realtek.c
>>> +++ b/sound/pci/hda/patch_realtek.c
>>> @@ -9109,6 +9109,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>>> SND_PCI_QUIRK(0x103c, 0x89c3, "Zbook Studio G9", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
>>> SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>>> SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>>> + SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>>> + SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
>>> SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
>>> SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED),
>>> SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED),
>> Hi,
>>
>> Can you send us the ACPI dump (DSDT file) for review for both laptops?
> As attachment.
Your DSDT looks good, I will +1 your patch.
>
>> We want to ensure that the ACPI has the correct information so the
>> driver will work properly.
> One thing we noticed recently is that _all_ systems that are equipped
> with cs35l41 have rather weak speaker output.
> Sound is barely audible when the volume is around 50%.
Full speaker performance will be enabled with DSP support. The code for
this has recently been merged and you may need to backport it to your
code base.
Additionally, the appropriate firmware and tunings need to be available
for your specific SKU. We are in the process of pushing these to the
linux-firmware repo now. If there is a particular SKU you wish to
prioritize, then please let us know.
>
> Kai-Heng
>
>> Thanks
>>
>> Lucas Tanure
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Enable speaker and mute LEDs for HP laptops
2022-07-19 14:20 [PATCH] ALSA: hda/realtek: Enable speaker and mute LEDs for HP laptops Kai-Heng Feng
2022-07-19 15:26 ` Lucas Tanure
@ 2022-07-21 15:50 ` Lucas Tanure
2022-07-25 6:38 ` Takashi Iwai
2 siblings, 0 replies; 6+ messages in thread
From: Lucas Tanure @ 2022-07-21 15:50 UTC (permalink / raw)
To: Kai-Heng Feng, tiwai
Cc: Stefan Binding, Kailang Yang, linux-kernel, Meng Tang,
alsa-devel, Werner Sembach, Tim Crawford, Andy Chi,
Cameron Berkenpas, Yong Wu, patches
On 7/19/22 15:20, Kai-Heng Feng wrote:
> Two more HP laptops that use cs35l41 AMP for speaker and GPIO for mute
> LEDs.
>
> So use the existing quirk to enable them accordingly.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Reviewed-by: Lucas Tanure <tanureal@opensource.cirrus.com>
> ---
> sound/pci/hda/patch_realtek.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 2f55bc43bfa9c..cdbee71e83216 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9109,6 +9109,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x89c3, "Zbook Studio G9", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> + SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
> SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED),
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Enable speaker and mute LEDs for HP laptops
2022-07-19 14:20 [PATCH] ALSA: hda/realtek: Enable speaker and mute LEDs for HP laptops Kai-Heng Feng
2022-07-19 15:26 ` Lucas Tanure
2022-07-21 15:50 ` Lucas Tanure
@ 2022-07-25 6:38 ` Takashi Iwai
2 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2022-07-25 6:38 UTC (permalink / raw)
To: Kai-Heng Feng
Cc: tiwai, Stefan Binding, Kailang Yang, linux-kernel, Lucas Tanure,
Meng Tang, alsa-devel, Werner Sembach, Tim Crawford, Andy Chi,
Cameron Berkenpas, Yong Wu
On Tue, 19 Jul 2022 16:20:14 +0200,
Kai-Heng Feng wrote:
>
> Two more HP laptops that use cs35l41 AMP for speaker and GPIO for mute
> LEDs.
>
> So use the existing quirk to enable them accordingly.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Applied now (with re-sort of the entries in SSID order).
thanks,
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-25 6:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-19 14:20 [PATCH] ALSA: hda/realtek: Enable speaker and mute LEDs for HP laptops Kai-Heng Feng
2022-07-19 15:26 ` Lucas Tanure
2022-07-20 2:07 ` Kai-Heng Feng
2022-07-21 15:49 ` Lucas Tanure
2022-07-21 15:50 ` Lucas Tanure
2022-07-25 6:38 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).