From: "jianchao.wang" <jianchao.w.wang@oracle.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: jejb@linux.vnet.ibm.com, Bart.VanAssche@wdc.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V2] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert
Date: Fri, 2 Mar 2018 10:18:12 +0800 [thread overview]
Message-ID: <f7e93d3c-f7ee-0142-73b7-60ff868fcb34@oracle.com> (raw)
In-Reply-To: <yq1371jz1xx.fsf@oracle.com>
Hi martin
On 03/02/2018 09:44 AM, Martin K. Petersen wrote:
>> In scsi core, __scsi_queue_insert should just put request back on the
>> queue and retry using the same command as before. However, for blk-mq,
>> scsi_mq_requeue_cmd is employed here which will unprepare the
>> request. To align with the semantics of __scsi_queue_insert, use
>> blk_mq_requeue_request with kick_requeue_list == true and put the
>> reference of scsi_device.
>>
>> V1 -> V2:
>> - add put_device on scsi_device->sdev_gendev
> Also, please put changelog after the --- delimiter.
>
Yes, I will modify this next version.
Thanks
Jianchao
prev parent reply other threads:[~2018-03-02 2:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 8:55 [PATCH V2] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert Jianchao Wang
2018-02-28 17:52 ` Bart Van Assche
2018-03-01 1:57 ` jianchao.wang
2018-03-01 17:43 ` Bart Van Assche
2018-03-02 1:43 ` Martin K. Petersen
2018-03-02 2:17 ` jianchao.wang
2018-03-02 2:16 ` jianchao.wang
2018-03-02 1:44 ` Martin K. Petersen
2018-03-02 2:18 ` jianchao.wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7e93d3c-f7ee-0142-73b7-60ff868fcb34@oracle.com \
--to=jianchao.w.wang@oracle.com \
--cc=Bart.VanAssche@wdc.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).