From: Aaron Conole <aconole@redhat.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: netdev@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC -next 2/2] virtio_net: Read and use the advised MTU
Date: Tue, 15 Mar 2016 16:53:24 -0400 [thread overview]
Message-ID: <f7tio0n8nuj.fsf@redhat.com> (raw)
In-Reply-To: <56E1C372.60204@cogentembedded.com> (Sergei Shtylyov's message of "Thu, 10 Mar 2016 21:56:50 +0300")
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> writes:
> Hello.
Hi Sergei,
> On 03/10/2016 05:28 PM, Aaron Conole wrote:
>
>> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it
>> exists, read the advised MTU and use it.
>>
>> No proper error handling is provided for the case where a user changes the
>> negotiated MTU. A future commit will add proper error handling. Instead, a
>> warning is emitted if the guest changes the device MTU after previously being
>> given advice.
>>
>> Signed-off-by: Aaron Conole <aconole@redhat.com>
>> ---
>> drivers/net/virtio_net.c | 15 ++++++++++++++-
>> 1 file changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
>> index 767ab11..7175563 100644
>> --- a/drivers/net/virtio_net.c
>> +++ b/drivers/net/virtio_net.c
> [...]
>> @@ -1390,8 +1391,12 @@ static const struct ethtool_ops virtnet_ethtool_ops = {
>>
>> static int virtnet_change_mtu(struct net_device *dev, int new_mtu)
>> {
>> + struct virtnet_info *vi = netdev_priv(dev);
>> if (new_mtu < MIN_MTU || new_mtu > MAX_MTU)
>> return -EINVAL;
>> + if (vi->negotiated_mtu == true) {
>> + pr_warn("changing mtu from negotiated mtu.");
>> + }
>
> {} not needed, see Documentation/CodingStyle.
Okay, I'll make sure to fix this with v2.
> [...]
>
> MBR, Sergei
Thanks so much for the review!
-Aaron
prev parent reply other threads:[~2016-03-15 20:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 14:28 [RFC -next 0/2] virtio-net: Advised MTU feature Aaron Conole
2016-03-10 14:28 ` [RFC -next 1/2] virtio: Start the advised MTU feature support Aaron Conole
2016-03-10 14:28 ` [RFC -next 2/2] virtio_net: Read and use the advised MTU Aaron Conole
2016-03-10 14:57 ` Paolo Abeni
2016-03-15 20:52 ` Aaron Conole
2016-03-10 18:56 ` Sergei Shtylyov
2016-03-15 20:53 ` Aaron Conole [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tio0n8nuj.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).