From: Liu Ying <victor.liu@nxp.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
mchehab@kernel.org, a.hajda@samsung.com, narmstrong@baylibre.com,
jonas@kwiboo.se, jernej.skrabec@siol.net, kishon@ti.com,
vkoul@kernel.org
Subject: Re: [PATCH 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding
Date: Tue, 22 Dec 2020 17:00:25 +0800 [thread overview]
Message-ID: <f80179f0d7be9d1915a53184523b87e9f320246f.camel@nxp.com> (raw)
In-Reply-To: <X+GiA4LqJTQR9vrz@pendragon.ideasonboard.com>
Hi Laurent,
On Tue, 2020-12-22 at 09:36 +0200, Laurent Pinchart wrote:
> Hi Liu,
>
> Thank you for the patch.
>
> On Thu, Dec 17, 2020 at 05:59:30PM +0800, Liu Ying wrote:
> > This patch adds bindings for i.MX8qm/qxp LVDS display bridge(LDB).
> >
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > ---
> > .../bindings/display/bridge/fsl,imx8qxp-ldb.yaml | 185 +++++++++++++++++++++
> > 1 file changed, 185 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml
> > new file mode 100644
> > index 00000000..4e5ff6f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml
> > @@ -0,0 +1,185 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fdisplay%2Fbridge%2Ffsl%2Cimx8qxp-ldb.yaml%23&data=04%7C01%7Cvictor.liu%40nxp.com%7C8548efc7a1cd47907a7f08d8a64c5570%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637442194086922596%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ejDrgwOktws%2BdElmBSyvKLws1Kx3YvPSfFDFghvpnaI%3D&reserved=0
> > +$schema: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=04%7C01%7Cvictor.liu%40nxp.com%7C8548efc7a1cd47907a7f08d8a64c5570%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637442194086922596%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=lM09SU3NM5A3ogCzoOMowF%2FCdIOQrQO%2Fhoy2kUQZqYg%3D&reserved=0
> > +
> > +title: Freescale i.MX8qm/qxp LVDS Display Bridge
> > +
> > +maintainers:
> > + - Liu Ying <victor.liu@nxp.com>
> > +
> > +description: |
> > + The Freescale i.MX8qm/qxp LVDS Display Bridge(LDB) has two channels.
> > +
> > + For i.MX8qxp LDB, each channel supports up to 24bpp parallel input color
> > + format and can map the input to VESA or JEIDA standards. The two channels
> > + cannot be used simultaneously, that is to say, the user should pick one of
> > + them to use. Two LDB channels from two LDB instances can work together in
> > + LDB split mode to support a dual link LVDS display. The channel indexes
> > + have to be different. Channel0 outputs odd pixels and channel1 outputs
> > + even pixels.
>
> In this case, does the display controller output odd pixels and even
> pixels separately to the two LVDS channels, with each channel
> effectively be a separate LVDS encoder ? Could you give an example of DT
The display controller just outputs frames without odd/even pixels
concept.
The frames reach two LDBs through pixel combiner, display pixel link
and PXL2DPI.
Each LDB would split out odd/even pixels and just use either odd pixels
or even pixels.
> integration for dual-link LVDS support, with the display controller, two
> LDB instances, and a dual-link LVDS panel ?
https://pastebin.ubuntu.com/p/HmzxV6PpvH/
Liu Ying
>
> > +
> > + For i.MX8qm LDB, each channel additionally supports up to 30bpp parallel
> > + input color format. The two channels can be used simultaneously, either
> > + in dual mode or split mode. In dual mode, the two channels output identical
> > + data. In split mode, channel0 outputs odd pixels and channel1 outputs even
> > + pixels.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - fsl,imx8qm-ldb
> > + - fsl,imx8qxp-ldb
> > +
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
> > +
> > + clocks:
> > + items:
> > + - description: pixel clock
> > + - description: bypass clock
> > +
> > + clock-names:
> > + items:
> > + - const: pixel
> > + - const: bypass
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > + fsl,syscon:
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > + description: |
> > + A phandle which points to Control and Status Registers(CSR) module.
> > +
> > + fsl,companion-ldb:
> > + $ref: /schemas/types.yaml#/definitions/phandle
> > + description: |
> > + A phandle which points to companion LDB which is used in LDB split mode.
> > +
> > +patternProperties:
> > + "^channel@[0-1]$":
> > + type: object
> > + description: Represents a channel of LDB.
> > +
> > + properties:
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
> > +
> > + reg:
> > + description: The channel index.
> > + enum: [ 0, 1 ]
> > +
> > + phys:
> > + description: A phandle to the phy module representing the LVDS PHY.
> > + maxItems: 1
> > +
> > + phy-names:
> > + const: lvds_phy
> > +
> > + port@0:
> > + type: object
> > + description: Input port of the channel.
> > +
> > + properties:
> > + reg:
> > + const: 0
> > +
> > + required:
> > + - reg
> > +
> > + port@1:
> > + type: object
> > + description: Output port of the channel.
> > +
> > + properties:
> > + reg:
> > + const: 1
> > +
> > + required:
> > + - reg
> > +
> > + required:
> > + - "#address-cells"
> > + - "#size-cells"
> > + - reg
> > + - phys
> > + - phy-names
> > +
> > + additionalProperties: false
> > +
> > +required:
> > + - compatible
> > + - "#address-cells"
> > + - "#size-cells"
> > + - clocks
> > + - clock-names
> > + - power-domains
> > + - fsl,syscon
> > + - channel@0
> > + - channel@1
> > +
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: fsl,imx8qm-ldb
> > + then:
> > + properties:
> > + fsl,companion-ldb: false
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/firmware/imx/rsrc.h>
> > + ldb {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + compatible = "fsl,imx8qxp-ldb";
> > + clocks = <&clk IMX_SC_R_LVDS_0 IMX_SC_PM_CLK_MISC2>,
> > + <&clk IMX_SC_R_LVDS_0 IMX_SC_PM_CLK_BYPASS>;
> > + clock-names = "pixel", "bypass";
> > + power-domains = <&pd IMX_SC_R_LVDS_0>;
> > + fsl,syscon = <&mipi_lvds_0_csr>;
> > +
> > + channel@0 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0>;
> > + phys = <&mipi_lvds_0_phy>;
> > + phy-names = "lvds_phy";
> > +
> > + port@0 {
> > + reg = <0>;
> > +
> > + mipi_lvds_0_ldb_ch0_mipi_lvds_0_pxl2dpi: endpoint {
> > + remote-endpoint = <&mipi_lvds_0_pxl2dpi_mipi_lvds_0_ldb_ch0>;
> > + };
> > + };
> > + };
> > +
> > + channel@1 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <1>;
> > + phys = <&mipi_lvds_0_phy>;
> > + phy-names = "lvds_phy";
> > +
> > + port@0 {
> > + reg = <0>;
> > +
> > + mipi_lvds_0_ldb_ch1_mipi_lvds_0_pxl2dpi: endpoint {
> > + remote-endpoint = <&mipi_lvds_0_pxl2dpi_mipi_lvds_0_ldb_ch1>;
> > + };
> > + };
> > + };
> > + };
next prev parent reply other threads:[~2020-12-22 9:03 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 9:59 [PATCH 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs Liu Ying
2020-12-17 9:59 ` [PATCH 01/14] phy: Add LVDS configuration options Liu Ying
2020-12-17 9:59 ` [PATCH 02/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner Liu Ying
2020-12-17 9:59 ` [PATCH 03/14] media: docs: " Liu Ying
2020-12-17 9:59 ` [PATCH 04/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding Liu Ying
2020-12-17 18:50 ` Rob Herring
2020-12-18 1:45 ` Liu Ying
2020-12-18 22:42 ` Rob Herring
2020-12-19 4:15 ` Liu Ying
2020-12-21 17:02 ` Rob Herring
2020-12-22 2:44 ` Liu Ying
2020-12-21 22:07 ` Rob Herring
2020-12-22 2:59 ` Liu Ying
2020-12-17 9:59 ` [PATCH 05/14] drm/bridge: imx: Add i.MX8qm/qxp pixel combiner support Liu Ying
2020-12-17 9:59 ` [PATCH 06/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding Liu Ying
2020-12-21 22:31 ` Rob Herring
2020-12-22 3:08 ` Liu Ying
2020-12-22 7:09 ` Laurent Pinchart
2020-12-22 9:12 ` Liu Ying
2020-12-17 9:59 ` [PATCH 07/14] drm/bridge: imx: Add i.MX8qm/qxp display pixel link support Liu Ying
2020-12-21 22:29 ` Rob Herring
2020-12-22 9:47 ` Liu Ying
2020-12-17 9:59 ` [PATCH 08/14] dt-bindings: display: bridge: Add i.MX8qxp pixel link to DPI binding Liu Ying
2020-12-17 9:59 ` [PATCH 09/14] drm/bridge: imx: Add i.MX8qxp pixel link to DPI support Liu Ying
2020-12-17 9:59 ` [PATCH 10/14] drm/bridge: imx: Add LDB driver helper support Liu Ying
2020-12-17 9:59 ` [PATCH 11/14] dt-bindings: display: bridge: Add i.MX8qm/qxp LVDS display bridge binding Liu Ying
2020-12-21 22:33 ` Rob Herring
2020-12-22 3:48 ` Liu Ying
2020-12-22 7:36 ` Laurent Pinchart
2020-12-22 7:49 ` Laurent Pinchart
2020-12-22 8:27 ` Liu Ying
2020-12-22 9:00 ` Liu Ying [this message]
2020-12-17 9:59 ` [PATCH 12/14] drm/bridge: imx: Add LDB support for i.MX8qxp Liu Ying
2020-12-22 9:52 ` Liu Ying
2020-12-17 9:59 ` [PATCH 13/14] drm/bridge: imx: Add LDB support for i.MX8qm Liu Ying
2020-12-17 9:59 ` [PATCH 14/14] MAINTAINERS: add maintainer for DRM bridge drivers for i.MX SoCs Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f80179f0d7be9d1915a53184523b87e9f320246f.camel@nxp.com \
--to=victor.liu@nxp.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).