From: Juergen Gross <jgross@suse.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org,
boris.ostrovsky@oracle.com
Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [Xen-devel][PATCH 1/3] xen: Introduce shared buffer helpers for page directory...
Date: Fri, 30 Nov 2018 07:50:11 +0100 [thread overview]
Message-ID: <f802385f-3c78-2804-9e47-b590a9580955@suse.com> (raw)
In-Reply-To: <133b948f-fc31-4505-0b85-5fc7a7beb559@gmail.com>
On 29/11/2018 12:22, Oleksandr Andrushchenko wrote:
> ping
>
> On 11/22/18 12:02 PM, Oleksandr Andrushchenko wrote:
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>
>> based frontends. Currently the frontends which implement
>> similar code for sharing big buffers between frontend and
>> backend are para-virtualized DRM and sound drivers.
>> Both define the same way to share grant references of a
>> data buffer with the corresponding backend with little
>> differences.
>>
>> Move shared code into a helper module, so there is a single
>> implementation of the same functionality for all.
>>
>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
In general I'm fine with this approach.
With the concerns raised for one of the other patches I wanted to wait
for V2 of the series. Or won't the resulting change require a
modification of this patch?
It would be nice if you could point out in the commit message whether
you are doing code movement (with some renames) only, or if there are
any functional changes involved (and which ones). This would make the
review much easier and less time consuming.
Juergen
next prev parent reply other threads:[~2018-11-30 6:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 10:02 [Xen-devel][PATCH 1/3] xen: Introduce shared buffer helpers for page directory Oleksandr Andrushchenko
2018-11-22 10:02 ` [Xen-devel][PATCH 2/3] drm/xen-front: Use Xen common shared buffer implementation Oleksandr Andrushchenko
2018-11-22 14:33 ` Daniel Vetter
2018-11-23 8:24 ` Juergen Gross
2018-11-26 6:45 ` Oleksandr Andrushchenko
2018-11-22 10:02 ` [Xen-devel][PATCH 3/3] ALSA: xen-front: " Oleksandr Andrushchenko
2018-11-22 15:47 ` [alsa-devel] " Takashi Iwai
2018-11-23 8:19 ` Oleksandr Andrushchenko
2018-11-29 11:22 ` [Xen-devel][PATCH 1/3] xen: Introduce shared buffer helpers for page directory Oleksandr Andrushchenko
2018-11-30 6:50 ` Juergen Gross [this message]
2018-11-30 7:07 ` Oleksandr Andrushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f802385f-3c78-2804-9e47-b590a9580955@suse.com \
--to=jgross@suse.com \
--cc=alsa-devel@alsa-project.org \
--cc=andr2000@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).