From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756741AbdKOILI (ORCPT ); Wed, 15 Nov 2017 03:11:08 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:40090 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754867AbdKOILB (ORCPT ); Wed, 15 Nov 2017 03:11:01 -0500 From: Ravi Bangoria Subject: Re: [PATCH] perf annotate: Remove precision for mnemonics To: Arnaldo Carvalho de Melo Cc: peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, treeze.taeung@gmail.com, linux-kernel@vger.kernel.org, dstence@us.ibm.com, ravi.bangoria@linux.vnet.ibm.com References: <20171114032540.4564-1-ravi.bangoria@linux.vnet.ibm.com> <20171114130427.GK8836@kernel.org> Date: Wed, 15 Nov 2017 13:41:12 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171114130427.GK8836@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 17111508-0012-0000-0000-0000058D7CD8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17111508-0013-0000-0000-000019083962 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-15_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711150116 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/14/2017 06:34 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Nov 14, 2017 at 08:55:40AM +0530, Ravi Bangoria escreveu: >> There are many instructions, esp on powerpc, whose mnemonics are >> longer than 6 characters. Using precision limit causes truncation >> of such mnemonics. >> >> Fix this by removing precision limit. Note that, 'width' is still >> 6, so alignment won't get affected for length <= 6. >> >> Before: >> >> li r11,-1 >> xscvdp vs1,vs1 >> add. r10,r10,r11 >> >> After: >> >> li r11,-1 >> xscvdpsxds vs1,vs1 >> add. r10,r10,r11 > Ok, this improves the situation, as we stop truncating info, but I think > that we should look for the longest instruction name and then use that > to align the operands, will add that to my todo list if nobody does it > first :-) Hmm.. I could see longest one of 15 characters (f.e. AESKEYGENASSIST) by a quick glance over list of instructions for x86 and powerpc. Need to check for other archs. > Thanks, applied. Thanks, Ravi