From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422866AbcFMI46 (ORCPT ); Mon, 13 Jun 2016 04:56:58 -0400 Received: from lucky1.263xmail.com ([211.157.147.132]:57701 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422852AbcFMI4z (ORCPT ); Mon, 13 Jun 2016 04:56:55 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <30c5b17c8963397737a08c3ed12492c5> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 10/11] phy: rockchip-emmc: Minor code cleanup in rockchip_emmc_phy_power_off() To: Douglas Anderson , ulf.hansson@linaro.org, kishon@ti.com, Heiko Stuebner , robh+dt@kernel.org References: <1465339484-969-1-git-send-email-dianders@chromium.org> <1465339484-969-11-git-send-email-dianders@chromium.org> Cc: shawn.lin@rock-chips.com, xzy.xu@rock-chips.com, briannorris@chromium.org, adrian.hunter@intel.com, linux-rockchip@lists.infradead.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Shawn Lin Message-ID: Date: Mon, 13 Jun 2016 16:56:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1465339484-969-11-git-send-email-dianders@chromium.org> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/6/8 6:44, Douglas Anderson wrote: > There's no reason to store the return value of rockchip_emmc_phy_power() > in a variable nor to check it. Just return it. > > Signed-off-by: Douglas Anderson > --- > drivers/phy/phy-rockchip-emmc.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/phy/phy-rockchip-emmc.c b/drivers/phy/phy-rockchip-emmc.c > index 0fce7359d468..188e4c387ba8 100644 > --- a/drivers/phy/phy-rockchip-emmc.c > +++ b/drivers/phy/phy-rockchip-emmc.c > @@ -227,8 +227,6 @@ static int rockchip_emmc_phy_power_off(struct phy *phy) > static int rockchip_emmc_phy_power_on(struct phy *phy) > { I saw the cleanup for power_off is done on [patch 9/11] shouldn't be in this patch? :) > struct rockchip_emmc_phy *rk_phy = phy_get_drvdata(phy); > - int ret = 0; > - > > /* Drive impedance: 50 Ohm */ > regmap_write(rk_phy->reg_base, > @@ -252,11 +250,7 @@ static int rockchip_emmc_phy_power_on(struct phy *phy) > PHYCTRL_OTAPDLYSEL_SHIFT)); > > /* Power up emmc phy analog blocks */ > - ret = rockchip_emmc_phy_power(phy, PHYCTRL_PDB_PWR_ON); > - if (ret) > - return ret; > - > - return 0; > + return rockchip_emmc_phy_power(phy, PHYCTRL_PDB_PWR_ON); > } > > static const struct phy_ops ops = { > -- Best Regards Shawn Lin