From: Jan Beulich <jbeulich@suse.com>
To: Juergen Gross <jgross@suse.com>
Cc: linux@weissschuh.net,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen/privcmd: make option visible in Kconfig
Date: Tue, 16 Nov 2021 15:55:46 +0100 [thread overview]
Message-ID: <f80f3207-363d-51b7-4ae0-e4b8aeb2544b@suse.com> (raw)
In-Reply-To: <20211116143323.18866-1-jgross@suse.com>
On 16.11.2021 15:33, Juergen Gross wrote:
> This configuration option provides a misc device as an API to userspace.
> Make this API usable without having to select the module as a transitive
> dependency.
>
> This also fixes an issue where localyesconfig would select
> CONFIG_XEN_PRIVCMD=m because it was not visible and defaulted to
> building as module.
>
> Based-on-patch-by: Thomas Weißschuh <linux@weissschuh.net>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -259,9 +259,14 @@ config XEN_SCSI_BACKEND
> if guests need generic access to SCSI devices.
>
> config XEN_PRIVCMD
> - tristate
> + tristate "Xen hypercall passthrough driver"
> depends on XEN
> default m
> + help
> + The hypercall passthrough driver allows user land programs to perform
Maybe worth adding "privileged" here? Albeit of course that's different
from the use of the word ...
> + Xen hypercalls. This driver is normally required for systems running
> + as Dom0 to perform privileged operations, but in some disaggregated
... here, so there'd be a small risk of confusion.
Jan
> + Xen setups this driver might be needed for other domains, too.
>
> config XEN_ACPI_PROCESSOR
> tristate "Xen ACPI processor"
>
next prev parent reply other threads:[~2021-11-16 14:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 14:33 [PATCH] xen/privcmd: make option visible in Kconfig Juergen Gross
2021-11-16 14:55 ` Jan Beulich [this message]
2021-11-16 15:01 ` Juergen Gross
2021-11-16 16:05 ` Jan Beulich
2021-11-16 22:33 ` Boris Ostrovsky
2021-11-17 16:05 ` Boris Ostrovsky
2021-11-16 14:59 ` Thomas Weißschuh
-- strict thread matches above, loose matches on Subject: below --
2021-11-13 8:38 Thomas Weißschuh
2021-11-15 10:02 ` Jan Beulich
2021-11-15 10:25 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f80f3207-363d-51b7-4ae0-e4b8aeb2544b@suse.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).