From: Chris Goldsworthy <cgoldswo@codeaurora.org>
To: David Hildenbrand <david@redhat.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
pratikp@codeaurora.org, pdaly@codeaurora.org,
sudaraja@codeaurora.org, iamjoonsoo.kim@lge.com,
Vinayak Menon <vinmenon@codeaurora.org>
Subject: Re: [PATCH v3] mm: cma: indefinitely retry allocations in cma_alloc
Date: Fri, 25 Sep 2020 16:13:23 -0700 [thread overview]
Message-ID: <f8255f9c95f22035f57ed3167595e8e3@codeaurora.org> (raw)
In-Reply-To: <566091ab-11f2-f071-6072-3c1b0f80cc4e@redhat.com>
On 2020-09-25 05:18, David Hildenbrand wrote:
> On 24.09.20 07:16, Chris Goldsworthy wrote:
>> - GFP_KERNEL | (no_warn ? __GFP_NOWARN : 0));
>> + GFP_KERNEL | (gfp_mask & __GFP_NOWARN));
>
> Right, we definetly don't want to pass the flag further down.
>
> Alternative would be cma_alloc_nofail(). That helps avoid people
> passing
> stuff like GFP_USER and wondering why it doesn't have an effect.
But since we're doing a logical AND with __GFP_NOWARN, we're not passing
any other values down - this makes it equivalent to the previous
version, in that only __GFP_NOWARN can be passed to
alloc_contig_range().
--
The Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-09-25 23:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 5:16 [PATCH v3] mm: cma: indefinitely retry allocations in cma_alloc Chris Goldsworthy
2020-09-24 5:16 ` Chris Goldsworthy
2020-09-25 12:18 ` David Hildenbrand
2020-09-25 23:13 ` Chris Goldsworthy [this message]
2020-09-27 19:23 ` Minchan Kim
2020-09-28 20:10 ` Chris Goldsworthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8255f9c95f22035f57ed3167595e8e3@codeaurora.org \
--to=cgoldswo@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pdaly@codeaurora.org \
--cc=pratikp@codeaurora.org \
--cc=sudaraja@codeaurora.org \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).