From: Robin Murphy <robin.murphy@arm.com>
To: Joerg Roedel <joro@8bytes.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iommu/ipmmu-vmsa: Fix crash on early domain free
Date: Wed, 7 Nov 2018 16:17:09 +0000 [thread overview]
Message-ID: <f8259910-3e07-497b-9f18-6bcb47430cff@arm.com> (raw)
In-Reply-To: <20181107160341.pfpukoqhyhapfzpn@8bytes.org>
On 2018-11-07 4:03 pm, Joerg Roedel wrote:
> On Wed, Nov 07, 2018 at 04:50:40PM +0100, Geert Uytterhoeven wrote:
>> It only got triggered by the combination of commits 6c2fb2ea76361da9
>> ("of/device: Set bus DMA mask as appropriate") and b4ebe6063204da58
>> ("dma-direct: implement complete bus_dma_mask handling"), which is being
>> fixed by "of/device: Really only set bus DMA mask when
>> appropriate" (https://patchwork.kernel.org/patch/10670177/).
>
> Okay, but the bug is triggered since 6c2fb2ea76361da9, so I took this
> one for the fixes-tag.
FWIW it looks like it *has* always been possible to hit this crash by
allocating a domain and freeing it again without attaching any devices,
it's just highly improbable for any sane code to do that explicitly, so
the real latent triggers are failure paths in external callers (which in
this case are themselves only being reached thanks to my bug elsewhere).
Robin.
next prev parent reply other threads:[~2018-11-07 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 13:18 [PATCH] iommu/ipmmu-vmsa: Fix crash on early domain free Geert Uytterhoeven
2018-11-07 13:22 ` Robin Murphy
2018-11-07 15:34 ` Joerg Roedel
2018-11-07 15:50 ` Geert Uytterhoeven
2018-11-07 16:03 ` Joerg Roedel
2018-11-07 16:17 ` Robin Murphy [this message]
2018-11-07 16:53 ` Joerg Roedel
2018-11-07 16:04 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8259910-3e07-497b-9f18-6bcb47430cff@arm.com \
--to=robin.murphy@arm.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).