From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752273AbdLJQn7 (ORCPT ); Sun, 10 Dec 2017 11:43:59 -0500 Received: from mout.web.de ([212.227.15.14]:57901 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746AbdLJQn5 (ORCPT ); Sun, 10 Dec 2017 11:43:57 -0500 Subject: =?UTF-8?Q?Re:_iio/=e2=80=a6:_Use_common_error_handling_code?= To: Jonathan Cameron , linux-iio@vger.kernel.org Cc: LKML , kernel-janitors@vger.kernel.org, Hans de Goede , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler References: <5ab7e200-2dea-63e2-06db-0e185f563d16@users.sourceforge.net> <0f26a13b-7bbf-525b-a864-8aa8e13c3aef@users.sourceforge.net> <20171026174200.5c00b06d@archlinux> <20171210160829.16128419@archlinux> From: SF Markus Elfring Message-ID: Date: Sun, 10 Dec 2017 17:43:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171210160829.16128419@archlinux> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:pkPIUzkGlxDxPJRc/P9LGbeVWoHCGgw8CYNj2FFopQpLXmEbl+7 6Fv3Q0XA2xp0yGV/ekDifsiMxbT21eYAdUIqn3LNtA9ZQPcDwJ5n7oMd0ghVG8VX1E/FHpF izRR8fMcgjGBNvoiFmqch213YxW05WVmjGUkkgbnFWgBD7O7rxbtGQwSV4mEYqSuj/UvgVW 0WZTFFAGZJuLJJqZ8K6Rg== X-UI-Out-Filterresults: notjunk:1;V01:K0:jQ1tfmuuV3Q=:WcYNPpO7qmJr2m4lsmY5gc 5QajOvyXFR8V72b2uVuLIGmepgXR7EiDVnqTO8tP9dRxYMgYAVEQXThhgSv9i82Pim3anrUvL WHdqbDM1aDV+6sK4XBbMZJZNb1VoGHH4D0PkhQuy0CvMWviwdfhfYMKRlsYU4/LpK6eWGnCcY 2qCVgXcQCZ8JCGOdHf+mChxn9ILBFSidPLKAiX1ZwEtSWTXK4/J41Ke5wWD8kDn7M36ZR5od8 OgRk4tAORTotB5ojaraQs6b9WrNNOYJ4gpxYO0g7mNl1/OYucjgwFn99gDbSond1rLG/Jy9Ii ecPTS41pkU+7mTgwkieX8IYYDNRTMIZu6pO9EsHotDIahdRomn1qoJzEyWs+I1r5YZD5zC7ju s0aoxGszCv2QyxAjBQZelDEpZngsphLWtCkchqRicpCR+DoJB+y6nyVRsYWX+flWJbTEGCQQE T40z0vAdmhUbPsm/QPR5Ld/LaQg9GUMHbADXNJ49kMRmBUvmNYjjXihFI0NGmIixLDGJJsYlJ ld7BErHSEOP4T5o9kGq4eeer8Fp0dXNIyiNo0Bu+VlNU2bMzSPwMhkDtFYEiIlGTYXDTwdS2q hjMlYyqcsLYkV42nCU9aURfsgfbwZls4WqlF1Of0eYCSjg/0Nb6irZk1rir0MOgX27XASE00f r6yQ69L0Ib26VoRSI5wkx6G6hkhhIXJAa8Clyt7G8DpFw3ZKGs8YzYz3f8e3RZ4EMsUkQ5u+V wFiAKuTSx1D/0ynXEibfIX0+c16k1S/AmZo13GIiH/3xh28PKOZR+5SR80Cx3zn/GNgvak8I2 5BNH4s7HNmxfORBzLnCVw2nt2QKDE6z8mHxRKczVZleY8Ja5s0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hi Markus, I've accepted the ones that I think made an improvement > outweighing the inherent small costs of making any change. Does such a kind of feedback mean that you reconsidered any places where you expressed a rejection initially? > We also need to avoid code constructs that are unusual in error handling > such as backwards gotos. Why would you like to exclude this approach if anything useful could be achieved in the shown software design direction? > Note however that most of the changes made so far are only minor improvements. I agree that corresponding effects are small just because the discussed source code adjustments affected specific function implementations. > I am not saying I don't appreciate them, Thanks. > but rather than that they are of of low importance. A lot of details are competing also for our software development attention. Regards, Markus