From: Lars-Peter Clausen <lars@metafoo.de>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>,
"stefan.popa@analog.com" <stefan.popa@analog.com>,
"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"jic23@kernel.org" <jic23@kernel.org>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"yuehaibing@huawei.com" <yuehaibing@huawei.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH -next] iio:ad7797: Use correct attribute_group
Date: Mon, 9 Mar 2020 11:10:05 +0100 [thread overview]
Message-ID: <f82a318f-16b3-0bc0-61bf-0c54da05446d@metafoo.de> (raw)
In-Reply-To: <8d7a7062af94a3531dd519bd60fe26c8530c6a43.camel@analog.com>
On 3/4/20 7:35 AM, Ardelean, Alexandru wrote:
> On Mon, 2020-03-02 at 21:32 +0800, YueHaibing wrote:
>> [External]
>>
>> It seems ad7797_attribute_group should be used in ad7797_info,
>> according to commit ("iio:ad7793: Add support for the ad7796 and ad7797").
> While the change looks good at first, I am thinking that this might introduce
> another issue while fixing this one.
>
> It looks like the ad7797_attributes[] array may also require the
> &iio_dev_attr_in_m_in_scale_available.dev_attr.attr attribute as well.
> It looks like the available scales should be printed for AD7997 as well.
>
> That being said, this patch is fine as-is.
> But it would require a patch [before-this-patch] to fix the ad7797_attributes
> array.
>
> Something like this:
>
> static struct attribute *ad7797_attributes[] = {
> &iio_const_attr_sampling_frequency_available_ad7797.dev_attr.attr,
> + &iio_dev_attr_in_m_in_scale_available.dev_attr.attr,
> NULL
> };
>
> I'm hoping I'm right about this one. I sometimes don't notice things too well.
>
Scale is fixed for the ad7796 and not programmable. Usually we only have
the scale attribute itself in that case and no scale_available attribute.
- Lars
prev parent reply other threads:[~2020-03-09 10:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 13:32 [PATCH -next] iio:ad7797: Use correct attribute_group YueHaibing
2020-03-04 6:35 ` Ardelean, Alexandru
2020-03-07 13:10 ` Jonathan Cameron
2020-03-09 1:38 ` Yuehaibing
2020-03-09 10:12 ` Lars-Peter Clausen
2020-03-10 14:16 ` [PATCH v2] " YueHaibing
2020-03-15 9:17 ` Jonathan Cameron
2020-03-09 10:10 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f82a318f-16b3-0bc0-61bf-0c54da05446d@metafoo.de \
--to=lars@metafoo.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.Ardelean@analog.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=stefan.popa@analog.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).