From: Minda Chen <minda.chen@starfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Conor Dooley <conor@kernel.org>, "Vinod Koul" <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Pawel Laszczak <pawell@cadence.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Chen <peter.chen@kernel.org>,
Roger Quadros <rogerq@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-phy@lists.infradead.org>, <linux-usb@vger.kernel.org>,
<linux-riscv@lists.infradead.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: [PATCH v3 1/5] dt-bindings: phy: Add StarFive JH7110 USB/PCIe document
Date: Fri, 17 Mar 2023 18:29:06 +0800 [thread overview]
Message-ID: <f836d98d-bb3b-64a5-1598-1ef489e62fb6@starfivetech.com> (raw)
In-Reply-To: <f7752f68-11a6-cbf4-2f28-1de4c7ff9da2@linaro.org>
On 2023/3/17 16:39, Krzysztof Kozlowski wrote:
> On 15/03/2023 11:44, Minda Chen wrote:
>> Add StarFive JH7110 SoC USB 2.0/3.0 and PCIe 2.0 PHY dt-binding.
>> PCIe 2.0 phy can use as USB 3.0 PHY.
>>
>> Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
>> ---
>> .../phy/starfive,jh7110-usb-pcie-phy.yaml | 62 +++++++++++++++++++
>> 1 file changed, 62 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-usb-pcie-phy.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-pcie-phy.yaml
>> new file mode 100644
>> index 000000000000..aa1c3fe93100
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/starfive,jh7110-usb-pcie-phy.yaml
>> @@ -0,0 +1,62 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/phy/starfive,jh7110-usb-pcie-phy.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: StarFive USB 2.0 and PCIe 2.0 PHY
>> +
>> +maintainers:
>> + - Minda Chen <minda.chen@starfivetech.com>
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - starfive,jh7110-usb-phy
>> + - starfive,jh7110-pcie-phy
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + "#phy-cells":
>> + const: 0
>> +
>> + clocks:
>> + items:
>> + - description: usb 125m clock
>> + - description: app 125m clock
>> +
>> + clock-names:
>> + items:
>> + - const: 125m
>> + - const: app_125
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - "#phy-cells"
>> +
>
> It seems pci phy does not take these clocks, thus you should have
> allOf:if:then which will customize it per variant. Otherwise binding is
> incorrect for the pci.
>
ok
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + phy@10200000 {
>> + compatible = "starfive,jh7110-usb-phy";
>> + reg = <0x10200000 0x10000>;
>> + clocks = <&syscrg 95>,
>> + <&stgcrg 6>;
>> + clock-names = "125m", "app_125";
>> + #phy-cells = <0>;
>> + };
>> +
>> + phy@10210000 {
>> + compatible = "starfive,jh7110-pcie-phy";
>> + reg = <0x10210000 0x10000>;
>> + #phy-cells = <0>;
>> + };
>> +
>> + phy@10220000 {
>> + compatible = "starfive,jh7110-pcie-phy";
>> + reg = <0x10220000 0x10000>;
>> + #phy-cells = <0>;
>> + };
>
> Drop duplicated examples. Keep usb and maybe one phy.
>
ok, thanks
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-03-17 10:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 10:44 [PATCH v3 0/5] Add JH7110 USB and USB PHY driver support Minda Chen
2023-03-15 10:44 ` [PATCH v3 1/5] dt-bindings: phy: Add StarFive JH7110 USB/PCIe document Minda Chen
2023-03-17 8:39 ` Krzysztof Kozlowski
2023-03-17 10:29 ` Minda Chen [this message]
2023-03-15 10:44 ` [PATCH v3 2/5] phy: starfive: add JH7110 PCIE 2.0 and USB 2.0 PHY driver Minda Chen
2023-03-20 8:55 ` Vinod Koul
2023-03-20 11:00 ` Minda Chen
2023-03-15 10:44 ` [PATCH v3 3/5] dt-binding: Add JH7110 USB wrapper layer doc Minda Chen
2023-03-16 2:43 ` Peter Chen
2023-03-17 8:43 ` Krzysztof Kozlowski
2023-03-17 10:30 ` Minda Chen
2023-03-23 9:23 ` Philipp Zabel
2023-03-27 11:04 ` Minda Chen
2023-03-15 10:44 ` [PATCH v3 4/5] usb: cdns3: add StarFive JH7110 USB driver Minda Chen
2023-03-15 13:32 ` Dongliang Mu
2023-03-16 11:17 ` Minda Chen
2023-03-16 2:46 ` Peter Chen
2023-03-16 11:16 ` Minda Chen
2023-03-20 15:26 ` Rob Herring
2023-03-21 11:50 ` Minda Chen
2023-03-23 9:29 ` Philipp Zabel
2023-03-27 11:04 ` Minda Chen
2023-03-15 10:44 ` [PATCH v3 5/5] dts: usb: add StarFive JH7110 USB dts configuration Minda Chen
2023-03-16 2:43 ` Peter Chen
2023-03-16 3:02 ` Minda Chen
2023-03-17 8:44 ` Krzysztof Kozlowski
2023-03-17 10:59 ` Minda Chen
2023-03-20 15:34 ` Rob Herring
2023-03-21 12:35 ` Minda Chen
2023-03-22 8:00 ` Roger Quadros
2023-03-22 10:50 ` Minda Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f836d98d-bb3b-64a5-1598-1ef489e62fb6@starfivetech.com \
--to=minda.chen@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).