linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: Quorum Laval <quorum.laval@gmail.com>
Cc: jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jfs: jump to error_out when filemap_{fdatawait, write_and_wait} fails
Date: Mon, 29 Aug 2016 15:53:08 -0500	[thread overview]
Message-ID: <f8392112-ba3f-1cec-adfb-13c977458d04@oracle.com> (raw)
In-Reply-To: <1472222440-4736-1-git-send-email-quorum.laval@gmail.com>

On 08/26/2016 09:40 AM, Quorum Laval wrote:
> filemap_fdatawait/filemap_write_and_wait may fail, so check the return
> value and jump to error_out in the case of error.
> 
> Signed-off-by: Quorum Laval <quorum.laval@gmail.com>

This looks good. I'll push it upstream.

Thanks,
Dave

> ---
>  fs/jfs/resize.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/jfs/resize.c b/fs/jfs/resize.c
> index 90b3bc2..bd9b641 100644
> --- a/fs/jfs/resize.c
> +++ b/fs/jfs/resize.c
> @@ -379,8 +379,14 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize, int newLogSize)
>  	 * cached in meta-data cache, and not written out
>  	 * by txCommit();
>  	 */
> -	filemap_fdatawait(ipbmap->i_mapping);
> -	filemap_write_and_wait(ipbmap->i_mapping);
> +	rc = filemap_fdatawait(ipbmap->i_mapping);
> +	if (rc)
> +		goto error_out;
> +
> +	rc = filemap_write_and_wait(ipbmap->i_mapping);
> +	if (rc)
> +		goto error_out;
> +
>  	diWriteSpecial(ipbmap, 0);
>  
>  	newPage = nPages;	/* first new page number */
> 

      reply	other threads:[~2016-08-29 20:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26 14:40 [PATCH] jfs: jump to error_out when filemap_{fdatawait, write_and_wait} fails Quorum Laval
2016-08-29 20:53 ` Dave Kleikamp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8392112-ba3f-1cec-adfb-13c977458d04@oracle.com \
    --to=dave.kleikamp@oracle.com \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quorum.laval@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).