From: Rong Chen <rong.a.chen@intel.com>
To: Joerg Roedel <jroedel@suse.de>, kernel test robot <lkp@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, LKP <lkp@01.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>
Subject: Re: [LKP] a13c600e15 ("x86/mm/pti: Move user W+X check into .."): WARNING: CPU: 0 PID: 1 at arch/x86/mm/dump_pagetables.c:283 note_page
Date: Thu, 16 Aug 2018 11:08:59 +0800 [thread overview]
Message-ID: <f867895e-24c8-7c4d-869c-8cdfb1e0e82d@intel.com> (raw)
In-Reply-To: <20180810083504.55pljlr733lctz5k@suse.de>
On 08/10/2018 04:35 PM, Joerg Roedel wrote:
> On Fri, Aug 10, 2018 at 06:33:42AM +0800, kernel test robot wrote:
>> commit a13c600e15de44ccf03df28d3311ef3cb754ed9b
>> Author: Joerg Roedel <jroedel@suse.de>
>> AuthorDate: Wed Aug 8 13:16:40 2018 +0200
>> Commit: Thomas Gleixner <tglx@linutronix.de>
>> CommitDate: Thu Aug 9 20:42:07 2018 +0200
>>
>> x86/mm/pti: Move user W+X check into pti_finalize()
> Okay, I found the problem and the diff below fixes it.
The patch works well.
Tested-by: kernel test robot <rong.a.chen@intel.com>
>
> Ingo, Thomas, can you fold that diff into above commit or do you prefer
> a separate patch?
>
> Thanks and sorry for the hassle,
>
>
> Joerg
>
> diff --git a/arch/x86/mm/pti.c b/arch/x86/mm/pti.c
> index 026a89aa16d7..d1435c78ae4f 100644
> --- a/arch/x86/mm/pti.c
> +++ b/arch/x86/mm/pti.c
> @@ -629,5 +629,6 @@ void pti_finalize(void)
> pti_clone_entry_text();
> pti_clone_kernel_text();
>
> - debug_checkwx_user();
> + if (__supported_pte_mask & _PAGE_NX)
> + debug_checkwx_user();
> }
> _______________________________________________
> LKP mailing list
> LKP@lists.01.org
> https://lists.01.org/mailman/listinfo/lkp
prev parent reply other threads:[~2018-08-16 3:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 22:33 a13c600e15 ("x86/mm/pti: Move user W+X check into .."): WARNING: CPU: 0 PID: 1 at arch/x86/mm/dump_pagetables.c:283 note_page kernel test robot
2018-08-10 7:30 ` Joerg Roedel
2018-08-10 8:35 ` Joerg Roedel
2018-08-16 3:08 ` Rong Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f867895e-24c8-7c4d-869c-8cdfb1e0e82d@intel.com \
--to=rong.a.chen@intel.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=lkp@intel.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).