From: Tony Krowiak <akrowiak@linux.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Cc: freude@linux.ibm.com, cohuck@redhat.com, mjrosato@linux.ibm.com,
pasic@linux.ibm.com, alex.williamson@redhat.com,
kwankhede@nvidia.com, fiuczy@linux.ibm.com
Subject: Re: [PATCH v8 03/16] s390/vfio-ap: manage link between queue struct and matrix mdev
Date: Wed, 17 Jun 2020 08:10:23 -0400 [thread overview]
Message-ID: <f87a4326-ffd7-18b8-e128-2a583421cb1d@linux.ibm.com> (raw)
In-Reply-To: <6ae77590-8401-a06b-eec5-713319c21017@de.ibm.com>
On 6/16/20 1:50 PM, Christian Borntraeger wrote:
>
> On 05.06.20 23:39, Tony Krowiak wrote:
> [...]
>> +static void vfio_ap_mdev_link_queues(struct ap_matrix_mdev *matrix_mdev,
>> + enum qlink_type type,
>> + unsigned long qlink_id)
>> +{
>> + unsigned long id;
>> + struct vfio_ap_queue *q;
>> +
>> + switch (type) {
>> + case LINK_APID:
>> + case UNLINK_APID:
>> + for_each_set_bit_inv(id, matrix_mdev->matrix.aqm,
>> + matrix_mdev->matrix.aqm_max + 1) {
>> + q = vfio_ap_get_queue(AP_MKQID(qlink_id, id));
>> + if (q) {
>> + if (type == LINK_APID)
>> + q->matrix_mdev = matrix_mdev;
>> + else
>> + q->matrix_mdev = NULL;> + }
>> + }
>> + break;
>> + default:
> Can you rather use
> case LINK_APQI:
> case UNLINK_APQI:
>
> and add a default case with a WARN_ON_ONCE?
Yes I can.
>
>> + for_each_set_bit_inv(id, matrix_mdev->matrix.apm,
>> + matrix_mdev->matrix.apm_max + 1) {
>> + q = vfio_ap_get_queue(AP_MKQID(id, qlink_id));
>> + if (q) {
>> + if (type == LINK_APQI)
>> + q->matrix_mdev = matrix_mdev;
>> + else
>> + q->matrix_mdev = NULL;
>> + }
>> + }
>> + break;
>> + }
>> +}
>> +
next prev parent reply other threads:[~2020-06-17 12:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 21:39 [PATCH v8 00/16] s390/vfio-ap: dynamic configuration support Tony Krowiak
2020-06-05 21:39 ` [PATCH v8 01/16] s390/ap: introduce new ap function ap_get_qdev() Tony Krowiak
2020-06-05 21:39 ` [PATCH v8 02/16] s390/vfio-ap: use new AP bus interface to search for queue devices Tony Krowiak
2020-06-05 23:48 ` kernel test robot
2020-06-16 15:38 ` Christian Borntraeger
2020-06-16 15:45 ` Christian Borntraeger
2020-06-17 12:02 ` Tony Krowiak
2020-06-05 21:39 ` [PATCH v8 03/16] s390/vfio-ap: manage link between queue struct and matrix mdev Tony Krowiak
2020-06-16 17:50 ` Christian Borntraeger
2020-06-17 12:10 ` Tony Krowiak [this message]
2020-06-05 21:39 ` [PATCH v8 04/16] s390/zcrypt: driver callback to indicate resource in use Tony Krowiak
2020-06-06 1:14 ` kernel test robot
2020-06-06 1:29 ` kernel test robot
2020-07-08 12:27 ` Christian Borntraeger
2020-07-08 14:04 ` Tony Krowiak
2020-06-05 21:39 ` [PATCH v8 05/16] s390/vfio-ap: implement in-use callback for vfio_ap driver Tony Krowiak
2020-06-05 21:39 ` [PATCH v8 06/16] s390/vfio-ap: introduce shadow APCB Tony Krowiak
2020-06-05 21:39 ` [PATCH v8 07/16] s390/vfio-ap: sysfs attribute to display the guest's matrix Tony Krowiak
2020-06-05 21:39 ` [PATCH v8 08/16] s390/vfio-ap: filter matrix for unavailable queue devices Tony Krowiak
2020-06-05 21:39 ` [PATCH v8 09/16] s390/vfio_ap: add qlink from ap_matrix_mdev struct to vfio_ap_queue struct Tony Krowiak
2020-06-06 2:51 ` kernel test robot
2020-06-05 21:39 ` [PATCH v8 10/16] s390/vfio-ap: allow assignment of unavailable AP queues to mdev device Tony Krowiak
2020-06-05 21:39 ` [PATCH v8 11/16] s390/vfio-ap: allow configuration of matrix mdev in use by a KVM guest Tony Krowiak
2020-06-05 21:40 ` [PATCH v8 12/16] s390/vfio-ap: allow hot plug/unplug of AP resources using mdev device Tony Krowiak
2020-06-05 21:40 ` [PATCH v8 13/16] s390/zcrypt: Notify driver on config changed and scan complete callbacks Tony Krowiak
2020-06-05 21:40 ` [PATCH v8 14/16] s390/vfio-ap: handle host AP config change notification Tony Krowiak
2020-06-06 4:31 ` kernel test robot
2020-06-05 21:40 ` [PATCH v8 15/16] s390/vfio-ap: handle AP bus scan completed notification Tony Krowiak
2020-06-05 21:40 ` [PATCH v8 16/16] s390/vfio-ap: handle probe/remove not due to host AP config changes Tony Krowiak
2020-06-16 14:26 ` [PATCH v8 00/16] s390/vfio-ap: dynamic configuration support Tony Krowiak
2020-06-16 15:31 ` Christian Borntraeger
2020-06-17 12:21 ` Tony Krowiak
2020-06-22 14:03 ` Tony Krowiak
2020-06-29 15:11 ` Tony Krowiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f87a4326-ffd7-18b8-e128-2a583421cb1d@linux.ibm.com \
--to=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=fiuczy@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).