From: Justin Swartz <justin.swartz@risingedge.co.za>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>
Cc: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 3/3] mips: dts: ralink: mt7621: add serial1 and serial2 nodes
Date: Fri, 08 Mar 2024 15:56:10 +0200 [thread overview]
Message-ID: <f88bd12a52875fa6772b4d69991cc0cc@risingedge.co.za> (raw)
In-Reply-To: <55f6ee5c-84af-4976-a66c-63800f733f8f@arinc9.com>
On 2024-03-08 15:50, Arınç ÜNAL wrote:
> On 7.03.2024 22:04, Justin Swartz wrote:
>> Add serial1 and serial2 nodes to define the existence of
>> the MT7621's second and third UARTs.
>>
>> Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
>> ---
>> arch/mips/boot/dts/ralink/mt7621.dtsi | 28
>> +++++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi
>> b/arch/mips/boot/dts/ralink/mt7621.dtsi
>> index 3ad4e2343..5a89f0b8c 100644
>> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
>> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
>> @@ -124,6 +124,34 @@ serial0: serial@c00 {
>> pinctrl-0 = <&uart1_pins>;
>> };
>> + serial1: serial@d00 {
>> + compatible = "ns16550a";
>> + reg = <0xd00 0x100>;
>> + reg-io-width = <4>;
>> + reg-shift = <2>;
>> + clocks = <&sysc MT7621_CLK_UART2>;
>> + interrupt-parent = <&gic>;
>> + interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>;
>> + no-loopback-test;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&uart2_pins>;
>> + status = "disabled";
>> + };
>
> I would group this:
>
> serial1: serial@d00 {
> compatible = "ns16550a";
> reg = <0xd00 0x100>;
>
> reg-io-width = <4>;
> reg-shift = <2>;
>
> clocks = <&sysc MT7621_CLK_UART2>;
>
> interrupt-parent = <&gic>;
> interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>;
>
> no-loopback-test;
>
> pinctrl-names = "default";
> pinctrl-0 = <&uart2_pins>;
>
> status = "disabled";
> };
>
> Same goes for patch 2.
Thanks for the example.
Regards
Justin
next prev parent reply other threads:[~2024-03-08 13:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 20:10 [PATCH 1/2] mips: dts: ralink: mt7621: associate uart1_pins with serial0 Justin Swartz
2024-03-06 20:10 ` [PATCH 2/2] mips: dts: ralink: mt7621: add serial1 and serial2 nodes Justin Swartz
2024-03-07 10:04 ` Sergio Paracuellos
2024-03-07 15:14 ` Justin Swartz
2024-03-07 16:36 ` Sergio Paracuellos
2024-03-07 19:04 ` [PATCH v2 1/3] mips: dts: ralink: mt7621: associate uart1_pins with serial0 Justin Swartz
2024-03-07 19:04 ` [PATCH v2 2/3] mips: dts: ralink: mt7621: reorder serial0 properties Justin Swartz
2024-03-08 7:29 ` Sergio Paracuellos
2024-03-08 8:42 ` AngeloGioacchino Del Regno
2024-03-07 19:04 ` [PATCH v2 3/3] mips: dts: ralink: mt7621: add serial1 and serial2 nodes Justin Swartz
2024-03-08 7:28 ` Sergio Paracuellos
2024-03-08 8:44 ` AngeloGioacchino Del Regno
2024-03-08 10:56 ` Arınç ÜNAL
2024-03-08 13:50 ` Arınç ÜNAL
2024-03-08 13:56 ` Justin Swartz [this message]
2024-03-08 7:27 ` [PATCH v2 1/3] mips: dts: ralink: mt7621: associate uart1_pins with serial0 Sergio Paracuellos
2024-03-08 7:30 ` Sergio Paracuellos
2024-03-08 8:41 ` AngeloGioacchino Del Regno
2024-03-08 12:40 ` Justin Swartz
2024-03-08 13:24 ` Arınç ÜNAL
2024-03-07 11:33 ` [PATCH 1/2] " Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f88bd12a52875fa6772b4d69991cc0cc@risingedge.co.za \
--to=justin.swartz@risingedge.co.za \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).