From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36D23C388F9 for ; Mon, 26 Oct 2020 18:28:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D69FA20756 for ; Mon, 26 Oct 2020 18:28:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RGM1glyk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1789763AbgJZS2j (ORCPT ); Mon, 26 Oct 2020 14:28:39 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:34797 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1789755AbgJZS2i (ORCPT ); Mon, 26 Oct 2020 14:28:38 -0400 Received: by mail-wr1-f68.google.com with SMTP id i1so13828524wro.1 for ; Mon, 26 Oct 2020 11:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=mb+VsFHRngfApGddoi/2+L16aEwwHQwxUiOwMEFXlgs=; b=RGM1glykpkt4WTtU0NYkRbCZ3MHwai/Vlg0W0CaowGOLq+YfJ6TaONum9cShrZq706 JupbzNebx8SPwrqG+raIETfojDxCv9RakiErxnhOl5BcZvhZ2T2bVnFEzGvJhcHafkpE ayeayZio7irAins7HIVjUWJbVNhAdlpj7tnxKJ2bdB2CdzfMBa62FpflEQEwp2/ZGhL9 Tawj33jgUZ/6IRz4p9U+sf66NfGKLepJ/TvBM1IM1qwufnh8u8RDNjs8rVfN9+RhBEJ8 fO1O9CGJwTz0zuGkD4eHAUlJu+MDT4o3VTuZcYmqYMEvx0jngzQYw2vO5fINgjW2J7in IB9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mb+VsFHRngfApGddoi/2+L16aEwwHQwxUiOwMEFXlgs=; b=HirORMy1o83jw/BzLAtBje3k8sh5+BGFKFUiMKI+1SLXQxtWs3qSqMJcfc85dJG93Z pTxE1WoCSdlRQW2yVhwgpq0gUZs7yCqfZ4y60srNTvuA+mrIkwjNkoJgIcLCWF+N5/N9 +irk4PnYhV7y9Ts4ccO81iUoSmVg6wBunN2F1ZfQ/V0sFnhS7kSjM6pCCdiC81FtAJCE aAUqksxWyQ9qm5hrtfkO0fXie0Q5YXHkUobzC5S3UIHPNoFKW8lRXu62F9e+IwyyxOYW khwmAYLmMoyjfMXmgM/1Pw96krp64RMM5xJUcFGDXBwdMxa6fZ5ZyvyWEIaQkxwv9awr fNrw== X-Gm-Message-State: AOAM530Kl6BajJ9NPwRwK0xB17Z0PDcSG6ooma4Pe6fr5/p5pjJL0ciH kwmvHixR2W7g8Msq9RGEolFIpQ2RhRyQ4A== X-Google-Smtp-Source: ABdhPJww28uZ2Nkj3wMRpn4zzf7WBx9d4uAn0PaVp+B407u7eD0AreOrs1BqGAazN7DcEVl/f/cNRw== X-Received: by 2002:a5d:4802:: with SMTP id l2mr18697933wrq.282.1603736915868; Mon, 26 Oct 2020 11:28:35 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:54a1:359e:38ca:6e1? ([2a01:e34:ed2f:f020:54a1:359e:38ca:6e1]) by smtp.googlemail.com with ESMTPSA id r1sm25662056wro.18.2020.10.26.11.28.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 11:28:35 -0700 (PDT) Subject: Re: [PATCH] thermal: replace spin_lock_irqsave by spin_lock in hard IRQ To: Tian Tao , niklas.soderlund@ragnatech.se, rui.zhang@intel.com, amitk@kernel.org, linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1603249530-25218-1-git-send-email-tiantao6@hisilicon.com> From: Daniel Lezcano Message-ID: Date: Mon, 26 Oct 2020 19:28:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1603249530-25218-1-git-send-email-tiantao6@hisilicon.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/10/2020 05:05, Tian Tao wrote: > The code has been in a irq-disabled context since it is hard IRQ. There > is no necessity to do it again. > > Signed-off-by: Tian Tao > --- Whe resending with the log improved, please fix the subject: thermal: rcar: Replace ... Thanks -- Daniel > drivers/thermal/rcar_thermal.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c > index 5c2a13b..6ae757d 100644 > --- a/drivers/thermal/rcar_thermal.c > +++ b/drivers/thermal/rcar_thermal.c > @@ -409,16 +409,15 @@ static irqreturn_t rcar_thermal_irq(int irq, void *data) > { > struct rcar_thermal_common *common = data; > struct rcar_thermal_priv *priv; > - unsigned long flags; > u32 status, mask; > > - spin_lock_irqsave(&common->lock, flags); > + spin_lock(&common->lock); > > mask = rcar_thermal_common_read(common, INTMSK); > status = rcar_thermal_common_read(common, STR); > rcar_thermal_common_write(common, STR, 0x000F0F0F & mask); > > - spin_unlock_irqrestore(&common->lock, flags); > + spin_unlock(&common->lock); > > status = status & ~mask; > > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog