From: Anton Yakovlev <anton.yakovlev@opensynergy.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: <virtualization@lists.linux-foundation.org>,
<alsa-devel@alsa-project.org>, <virtio-dev@lists.oasis-open.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 6/9] ALSA: virtio: PCM substream operators
Date: Mon, 1 Mar 2021 10:29:24 +0100 [thread overview]
Message-ID: <f8a4bbf5-3bee-f336-0efd-94410184fb2b@opensynergy.com> (raw)
In-Reply-To: <s5hr1l0juld.wl-tiwai@suse.de>
On 28.02.2021 12:32, Takashi Iwai wrote:
> On Sat, 27 Feb 2021 09:59:53 +0100,
> Anton Yakovlev wrote:
>>
[snip]
>> +static snd_pcm_uframes_t
>> +virtsnd_pcm_pointer(struct snd_pcm_substream *substream)
>> +{
>> + struct virtio_pcm_substream *vss = snd_pcm_substream_chip(substream);
>> + snd_pcm_uframes_t hw_ptr = SNDRV_PCM_POS_XRUN;
>> + unsigned long flags;
>> +
>> + spin_lock_irqsave(&vss->lock, flags);
>> + if (!vss->xfer_xrun)
>> + hw_ptr = bytes_to_frames(substream->runtime, vss->hw_ptr);
>> + spin_unlock_irqrestore(&vss->lock, flags);
>
> Oh, and if we drop nonatomc PCM, both trigger and pointer callbacks
> are guaranteed to be called inside the spinlock, hence you can remove
> *_irqsave() but just us spin_lock() in those two callbacks.
As I understand, spin_lock_irqsave() disables only local interrupts. But
what about other CPU cores?
>
> thanks,
>
> Takashi
>
--
Anton Yakovlev
Senior Software Engineer
OpenSynergy GmbH
Rotherstr. 20, 10245 Berlin
next prev parent reply other threads:[~2021-03-01 9:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210227085956.1700687-1-anton.yakovlev@opensynergy.com>
2021-02-27 8:59 ` [PATCH v6 1/9] uapi: virtio_ids: add a sound device type ID from OASIS spec Anton Yakovlev
2021-02-27 8:59 ` [PATCH v6 2/9] ALSA: virtio: add virtio sound driver Anton Yakovlev
2021-02-27 8:59 ` [PATCH v6 3/9] ALSA: virtio: handling control messages Anton Yakovlev
2021-02-28 11:04 ` Takashi Iwai
2021-02-28 18:39 ` Anton Yakovlev
2021-02-27 8:59 ` [PATCH v6 4/9] ALSA: virtio: build PCM devices and substream hardware descriptors Anton Yakovlev
2021-02-28 11:15 ` Takashi Iwai
2021-02-27 8:59 ` [PATCH v6 5/9] ALSA: virtio: handling control and I/O messages for the PCM device Anton Yakovlev
2021-02-28 11:27 ` Takashi Iwai
2021-03-01 9:25 ` Anton Yakovlev
2021-03-01 13:32 ` Takashi Iwai
2021-03-01 14:47 ` Anton Yakovlev
2021-03-01 14:56 ` Takashi Iwai
2021-03-01 15:24 ` Anton Yakovlev
2021-03-01 15:30 ` Takashi Iwai
2021-02-27 8:59 ` [PATCH v6 6/9] ALSA: virtio: PCM substream operators Anton Yakovlev
2021-02-28 11:32 ` Takashi Iwai
2021-03-01 9:29 ` Anton Yakovlev [this message]
2021-03-01 13:33 ` Takashi Iwai
2021-02-27 8:59 ` [PATCH v6 7/9] ALSA: virtio: introduce jack support Anton Yakovlev
2021-02-27 8:59 ` [PATCH v6 8/9] ALSA: virtio: introduce PCM channel map support Anton Yakovlev
2021-02-27 8:59 ` [PATCH v6 9/9] ALSA: virtio: introduce device suspend/resume support Anton Yakovlev
2021-02-28 12:05 ` Takashi Iwai
2021-03-01 10:03 ` Anton Yakovlev
2021-03-01 13:38 ` Takashi Iwai
2021-03-01 15:30 ` Anton Yakovlev
2021-03-02 6:29 ` Anton Yakovlev
2021-03-02 6:48 ` Takashi Iwai
2021-03-02 8:09 ` Anton Yakovlev
2021-03-02 9:11 ` Takashi Iwai
2021-03-02 15:35 ` Anton Yakovlev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8a4bbf5-3bee-f336-0efd-94410184fb2b@opensynergy.com \
--to=anton.yakovlev@opensynergy.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).