From: Jens Axboe <axboe@kernel.dk>
To: Mathieu Malaterre <malat@debian.org>
Cc: Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Nikolay Borisov <nborisov@suse.com>, Tejun Heo <tj@kernel.org>,
Matthew Wilcox <mawilcox@microsoft.com>,
Minchan Kim <minchan@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] backing: silence compiler warning using __printf
Date: Mon, 9 Apr 2018 09:51:41 -0600 [thread overview]
Message-ID: <f8d37511-2a23-53f5-3c70-8a7f5f9e965e@kernel.dk> (raw)
In-Reply-To: <20180406201453.32683-1-malat@debian.org>
On 4/6/18 2:14 PM, Mathieu Malaterre wrote:
> __printf marker was added in commit d2cc4dde9206 ("bdi_register: add
> __printf verification, fix arg mismatch") for function `bdi_register`
> since it is useful to verify format and arguments. Apply equivalent gcc
> attribute to `bdi_register_va`.
>
> Remove warning triggered with W=1:
>
> mm/backing-dev.c:881:2: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2018-04-09 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 20:14 [PATCH] backing: silence compiler warning using __printf Mathieu Malaterre
2018-04-09 15:50 ` Jan Kara
2018-04-09 15:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8d37511-2a23-53f5-3c70-8a7f5f9e965e@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=malat@debian.org \
--cc=mawilcox@microsoft.com \
--cc=minchan@kernel.org \
--cc=nborisov@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).