From: Hari Bathini <hbathini@linux.ibm.com>
To: Sourabh Jain <sourabhjain@linux.ibm.com>, mpe@ellerman.id.au
Cc: mahesh@linux.vnet.ibm.com, linux-doc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
corbet@lwn.net
Subject: Re: [PATCH v3] powerpc/fadump: sysfs for fadump memory reservation
Date: Mon, 26 Aug 2019 16:46:18 +0530 [thread overview]
Message-ID: <f8e9cbdd-1926-081d-c8e6-f9d55408fe51@linux.ibm.com> (raw)
In-Reply-To: <f53e4cfe-57cb-d8a6-385a-fa6243940573@linux.ibm.com>
On 26/08/19 4:14 PM, Sourabh Jain wrote:
>
>
> On 8/26/19 3:46 PM, Sourabh Jain wrote:
>>
>>
>> On 8/26/19 3:29 PM, Hari Bathini wrote:
>>>
>>>
>>> On 10/08/19 11:29 PM, Sourabh Jain wrote:
>>>> Add a sys interface to allow querying the memory reserved by
>>>> fadump for saving the crash dump.
>>>>
>>>> Add an ABI doc entry for new sysfs interface.
>>>> - /sys/kernel/fadump_mem_reserved
>>>>
>>>> Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com>
>>>> ---
>>>> Changelog:
>>>> v1 -> v2:
>>>> - Added ABI doc for new sysfs interface.
>>>>
>>>> v2 -> v3:
>>>> - Updated the ABI documentation.
>>>> ---
>>>>
>>>> Documentation/ABI/testing/sysfs-kernel-fadump | 6 ++++++
>>>
>>> Shouldn't this be Documentation/ABI/testing/sysfs-kernel-fadump_mem_reserved?
>
> How about documenting fadump_mem_reserved and other sysfs attributes suggested
> by you in a single file Documentation/ABI/testing/sysfs-kernel-fadump?
I wouldn't mind that but please do check if it is breaking a convention..
- Hari
next prev parent reply other threads:[~2019-08-26 11:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-10 17:59 [PATCH v3] powerpc/fadump: sysfs for fadump memory reservation Sourabh Jain
2019-08-26 9:59 ` Hari Bathini
2019-08-26 10:16 ` Sourabh Jain
2019-08-26 10:44 ` Sourabh Jain
2019-08-26 11:16 ` Hari Bathini [this message]
2019-08-27 3:19 ` Michael Ellerman
2019-08-27 6:02 ` Hari Bathini
2019-09-18 8:19 ` Sourabh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8e9cbdd-1926-081d-c8e6-f9d55408fe51@linux.ibm.com \
--to=hbathini@linux.ibm.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=sourabhjain@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).