From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B71A7C63697 for ; Mon, 23 Nov 2020 06:48:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 612BC20773 for ; Mon, 23 Nov 2020 06:48:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="HLKk/+fV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727622AbgKWGsF (ORCPT ); Mon, 23 Nov 2020 01:48:05 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:15638 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727088AbgKWGsF (ORCPT ); Mon, 23 Nov 2020 01:48:05 -0500 Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20201123064801epoutp03e72c785fd5a610eb6991d15a97b36a76~KED9qrs-51244812448epoutp03O for ; Mon, 23 Nov 2020 06:48:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20201123064801epoutp03e72c785fd5a610eb6991d15a97b36a76~KED9qrs-51244812448epoutp03O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1606114081; bh=huO/DzlWXqHKtGTBqiOhR7mqW/ABbdb9hkVOQAK47aI=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=HLKk/+fVwHveW6qT52oIvAfSJg9Jc954lJ72TQDlTRx2txiuN+d/hYYyBnjSqh+FM RJ2vSjRvbYpJfEvJRl2g8596+gX8IuceeNvslMJtMdta0Gn380bAXBHA9KXbnQhJ2k hqqUbGW9A8K29n8+ZmkVg6++Q4fU4PjR60AsMfGc= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20201123064801epcas1p156a2230fe89d187f98a9e4d2b909a29e~KED9GdV6M0116501165epcas1p1o; Mon, 23 Nov 2020 06:48:01 +0000 (GMT) Received: from epsmges1p2.samsung.com (unknown [182.195.40.153]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4Cfd5B3NG2zMqYkj; Mon, 23 Nov 2020 06:47:58 +0000 (GMT) Received: from epcas1p1.samsung.com ( [182.195.41.45]) by epsmges1p2.samsung.com (Symantec Messaging Gateway) with SMTP id C1.C1.63458.E1B5BBF5; Mon, 23 Nov 2020 15:47:58 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p3.samsung.com (KnoxPortal) with ESMTPA id 20201123064757epcas1p37d2d540ba70cd4ad107d4442b58599e1~KED6OzJgg0264502645epcas1p3F; Mon, 23 Nov 2020 06:47:57 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20201123064757epsmtrp271e2c012cb93f1be7a489f1751cea718~KED6NwXer1092710927epsmtrp2-; Mon, 23 Nov 2020 06:47:57 +0000 (GMT) X-AuditID: b6c32a36-6dfff7000000f7e2-0a-5fbb5b1eae96 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id CB.4D.13470.D1B5BBF5; Mon, 23 Nov 2020 15:47:57 +0900 (KST) Received: from [10.113.221.102] (unknown [10.113.221.102]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20201123064757epsmtip2bdaaee5bf25ff7e246f8f3ba49fba7dd~KED5vTpQB2156421564epsmtip2I; Mon, 23 Nov 2020 06:47:57 +0000 (GMT) Subject: Re: [PATCH v10 09/19] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree To: Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski Cc: linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org From: Chanwoo Choi Organization: Samsung Electronics Message-ID: Date: Mon, 23 Nov 2020 16:02:17 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Thunderbird/59.0 MIME-Version: 1.0 In-Reply-To: <20201123002723.28463-10-digetx@gmail.com> Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGJsWRmVeSWpSXmKPExsWy7bCmrq5c9O54g9knxC3efXrKarH642NG iytf37NZTN+7ic2iZdYiFovz5zewW2x9uobJ4mzTG3aLy7vmsFl87j3CaNH5ZRabxcVTrha3 G1ewWUxaO5XR4uwzb4vWvUfYLf5d28hi8XPXPBaLzQ+OsTkIe7y/0crusXPWXXaPS+f+MHts WtXJ5nHn2h42j/vdx5k8epvfsXn0bVnF6PF5k1wAZ1S2TUZqYkpqkUJqXnJ+SmZeuq2Sd3C8 c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QU0oKZYk5pUChgMTiYiV9O5ui/NKSVIWM/OIS W6XUgpScAssCveLE3OLSvHS95PxcK0MDAyNToMKE7Iy9P3pYCs5zVMx++YWpgbGXvYuRk0NC wERi7uudbF2MXBxCAjsYJd5cWskM4XxilDiwfRdU5hujxM+nHXAta081QFXtZZRo/vSbHcJ5 zyhx628PSxcjB4ewQJrE6Tl1IHERgZssEstX/GMDiTMLVEls+uMNMohNQEti/4sbbCA2v4Ci xNUfjxlBbF4BO4kPM2eygNgsAqoSxw58YQKxRQXCJE5ua4GqEZQ4OfMJWA2ngLnEol+XWUFs ZgFxiVtP5jNB2PIS29/OATtUQqCfU+LhlhOsEB+4SGzffBrqG2GJV8e3QNlSEp/f7WWDsKsl Vp48wgbR3MEosWX/BahmY4n9SyczQTyjKbF+lz5EWFFi5++5jBCL+STefe1hBSmREOCV6GgT gihRlrj84C4ThC0psbi9k20Co9IsJO/MQvLCLCQvzEJYtoCRZRWjWGpBcW56arFhgRFybG9i BCd4LbMdjJPeftA7xMjEwXiIUYKDWUmEt1VuZ7wQb0piZVVqUX58UWlOavEhRlNgAE9klhJN zgfmmLySeENTI2NjYwsTQzNTQ0Mlcd4/2h3xQgLpiSWp2ampBalFMH1MHJxSDUytOedCRDeV tctf1uPjWHP2F8Oecnkemx0fJcwm5T77LHfW+v5ipQ8815/rsrZyPA5J/jL/iUD/WU31oChR h5ZG5RtWolZLNoeFrrnldFYgYOIPt8s/vOY9t5q+8cxj26xn2+omiWdYzP1fy/NsrsD2gjMV 976uD39gZ5QQ8EtE25lhkumn5iWqnMr1s49sMcn2m3CtWsNfbq5fG7Oj7vpi0VObRN/ZqP/Z EJj8NX5C8c0Ea8mybumw1Wq3u7hvv9KTOR99LUxVepLk1pctbtItiarmmY6l738xXVp8N/Z6 Q9kJ1w3772ox/nkmITp7zun2GmlZ/8Uy6XN+z1spP6PSrOqm3i6L/7FzGBduVFRiKc5INNRi LipOBADsVN6NeQQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrIIsWRmVeSWpSXmKPExsWy7bCSvK5s9O54gxfP9C3efXrKarH642NG iytf37NZTN+7ic2iZdYiFovz5zewW2x9uobJ4mzTG3aLy7vmsFl87j3CaNH5ZRabxcVTrha3 G1ewWUxaO5XR4uwzb4vWvUfYLf5d28hi8XPXPBaLzQ+OsTkIe7y/0crusXPWXXaPS+f+MHts WtXJ5nHn2h42j/vdx5k8epvfsXn0bVnF6PF5k1wAZxSXTUpqTmZZapG+XQJXxt4fPSwF5zkq Zr/8wtTA2MvexcjJISFgIrH2VAMziC0ksJtRYvuJUoi4pMS0i0eB4hxAtrDE4cPFXYxcQCVv GSV6t/xjBKkRFkiT+LduAyNIQkTgLovEpB+32EASzAJVEgvXLmaD6NjGKPHr2AFWkASbgJbE /hc3wIr4BRQlrv54DDaJV8BO4sPMmSwgNouAqsSxA1+YQGxRgTCJnUseM0HUCEqcnPkErIZT wFxi0a/LrBDL1CX+zLvEDGGLS9x6Mp8JwpaX2P52DvMERuFZSNpnIWmZhaRlFpKWBYwsqxgl UwuKc9Nziw0LDPNSy/WKE3OLS/PS9ZLzczcxgmNdS3MH4/ZVH/QOMTJxMB5ilOBgVhLhbZXb GS/Em5JYWZValB9fVJqTWnyIUZqDRUmc90bhwjghgfTEktTs1NSC1CKYLBMHp1QDk5RPesT/ BW6saxNL9K8c3BWYEsKazsITFa4pKpO+KvBfdGHz7Y5tSuk5Cxe0tde+Sua+Vbe08Ol/6ems SQ8Wrzs+b9Lc90teC+e2WP0TfRwpO0G5vHFRw6Q07r8S0X97kp4e3/sk7HvF5fLknPnl97wt vsvNSlfaY8o/5dh56wXfkuYH/O9iU7uwlbX1avabfoaNQq7eDFZ7L544sCUwqkNps+iTNSKc L27tFJ09+8hjJpbc3MPa66wd07Tme80tz3l49fMG9W97dFdFbn8n1WvOdH5aY1Ewszlfb3vo jXW757Pd9Z2oGnlz6j7GbrZ/CuVC8+wsKh6828V9XEJG7U10n3GYNoe3iFD+Qpn/SizFGYmG WsxFxYkAQMqhAmQDAAA= X-CMS-MailID: 20201123064757epcas1p37d2d540ba70cd4ad107d4442b58599e1 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20201123003325epcas1p1b90c7b94507a3d58053949f5395c885a References: <20201123002723.28463-1-digetx@gmail.com> <20201123002723.28463-10-digetx@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, On 11/23/20 9:27 AM, Dmitry Osipenko wrote: > This patch moves ACTMON driver away from generating OPP table by itself, > transitioning it to use the table which comes from device-tree. This > change breaks compatibility with older device-trees and brings support > for the interconnect framework to the driver. This is a mandatory change > which needs to be done in order to implement interconnect-based memory > DVFS, i.e. device-trees need to be updated. Now ACTMON issues a memory > bandwidth requests using dev_pm_opp_set_bw() instead of driving EMC clock > rate directly. > > Tested-by: Peter Geis > Tested-by: Nicolas Chauvet > Acked-by: Chanwoo Choi > Signed-off-by: Dmitry Osipenko > --- > drivers/devfreq/tegra30-devfreq.c | 79 +++++++++++++++---------------- > 1 file changed, 37 insertions(+), 42 deletions(-) > (snip) When the patches related to icc are merged, I'll merge patch9/10. Thanks for your work. -- Best Regards, Chanwoo Choi Samsung Electronics