From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933884AbcK2PfN (ORCPT ); Tue, 29 Nov 2016 10:35:13 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:24769 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933610AbcK2Pex (ORCPT ); Tue, 29 Nov 2016 10:34:53 -0500 X-AuditID: cbfec7ef-f79e76d000005b57-9f-583da019374e Subject: Re: [PATCH V2] leds: pca963x: Add ACPI support To: Tin Huynh , Mika Westerberg Cc: "Rafael J. Wysocki" , Richard Purdie , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Loc Ho , Thang Nguyen , Phong Vo , patches From: Jacek Anaszewski Message-id: Date: Tue, 29 Nov 2016 16:34:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA01SfSyUcRzvd8/znOdO136O+EZUV2q1IU3zpBib1vFXiYXadMuzY3nbHUZb G/N2Z1NyxjrCmtJC8pJ3qkusOUaoVTvaGpmXlZeJlMvdQ/Pf5/P7fl722X40Ia6k7OnouERW ESeLkfCFZHPv2qDLvgrv0JPGJk8m83MeyVR130XMSHspn3kx9wwxhS09FkyGfoXPqGpWEKPv f08xHe2TFNOrDmfWVRrK11K6ULeIpGXvLkmbxnJIaWf5KiVdanC6SIULz0WyMdHJrMLN57ow qnxARyYM2qQsfU3np6EKnIsENGAPqBquJjhsC0PjdfxcJKTF+DGCztIhiiNLCO7/6uVvO7LS 06n/qpHyNsSRKQQ6wyxpUlljT3j+4LvZYYODofLOnNlB4GIejBumkOnAx+6wNj3LM2ER9oG5 2m+UCZPYGbTN+k0zTe/FodBhYDmJFaxqxs35AnwZfv4pMMcQ2AumNrIoDh+Axpp5wtQFuNsC 1vN6LEw5gB2h4dXWTn/Q/U3fWmMNM31NFhzeD2rVax7n1SAY7v1EcaQaQb1aTXKqs5Bm/E1y bXugoLmY4ApEoMoWcxIpGCeyt0L9oLptwVwmxp08yH3jkI8OaHfs0e7YoN2xoQIRT5ENm6SM lbNKd1elLFaZFCd3vREf24A2/07/Rt+PVjSZEaxDmEaS3aLpfO9QMSVLVqbG6hDQhMRG9LJk 80kUKUu9xSriIxRJMaxShxxoUmIn6qoYvSLGclkie5NlE1jF9pVHC+zTkGNAy9DM1ZxrbqcK ivzavWN21eUdLqSGR70S/YtUlpED9WieX2nVOIrPl3UJi1I1+iDfeM9A/bEU9RHt7Q1jkGvE I8HyvYnjJV1VHw0XakMeegTWuTgdbQ2Rh3XMl9udbj6jziQGPyw/CTg41WJLhI0dWqTWfGT+ Dc5jX94aV1QSUhklcz9BKJSyf04bIzA3AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCIsWRmVeSWpSXmKPExsVy+t/xK7oaC2wjDC6907JoudXLYrF8Xz+j xeVdc9gstr5Zx2gxZfsRdovmM9/YLDrWfGO0OHP6EqvF7l1PWS2OdUZZ/O6YzOrA7fFx/SdG j3knAz22XG1n8dgz/werx+dNcgGsUW42GamJKalFCql5yfkpmXnptkqhIW66FkoKeYm5qbZK Ebq+IUFKCmWJOaVAnpEBGnBwDnAPVtK3S3DLmH/2EEvBOZGKzw8a2RoYFwh0MXJySAiYSLQ2 NrJC2GISF+6tZwOxhQSWMEq8uivdxcgFZD9jlJhy8TVYQljAXGLD3OdgtohAiMSZa8+ZIYr2 MUk0nzzLBuIwC0xnkti0ZAY7SBWbgKHEzxevmUBsXgE7iTdrH4OtYxFQlZi17QzYJFGBCIlb qz4yQtQISvyYfI8FxOYUCJZoWfEcLM4sYCbx5eVhVghbXmLzmrfMExgFZiFpmYWkbBaSsgWM zKsYRVJLi3PTc4sN9YoTc4tL89L1kvNzNzECY3DbsZ+bdzBe2hh8iFGAg1GJh3dCn22EEGti WXFl7iFGCQ5mJRHe/bOBQrwpiZVVqUX58UWlOanFhxhNgZ6YyCwlmpwPTA95JfGGJobmloZG xhYW5kZGSuK8JR+uhAsJpCeWpGanphakFsH0MXFwSjUwLuLZULP6zaKsjGKto/atwaebudI1 7F/eX/tK6vCM9I2s5XVuyyc+rA1fb5YlLL/4a4bW39iyp887TiaI/k240t1d9cN0kvGd1y/c Ixwvb6wUy3nN0Wgtr2u1f+2qNV5cbDkNc9bLTFG6YVr8xFA/9WCqT5TwF4UvPC9OVEQ1uKm9 KxIsar6qxFKckWioxVxUnAgAvW4g5dcCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161129153448eucas1p1d6f33885491d84f5214d2d4d7366fa25 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?Qikb7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SmFjZWsgQW5hc3pld3NraRtTUlBPTC1TeXN0ZW0gRlcgIChN?= =?UTF-8?B?QikbU2Ftc3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgU29mdHdhcmUgRW5naW5l?= =?UTF-8?B?ZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjc1MjY=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161129102236epcas1p36ba8b4160c78cfd62d5748538174ca05 X-RootMTR: 20161129102236epcas1p36ba8b4160c78cfd62d5748538174ca05 References: <1480414910-16691-1-git-send-email-tnhuynh@apm.com> <676881f2-07e1-9c77-3559-3cf9832852a6@samsung.com> <20161129110400.GY1459@lahna.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tin, On 11/29/2016 03:47 PM, Tin Huynh wrote: > On Tue, Nov 29, 2016 at 6:04 PM, Mika Westerberg > wrote: >> On Tue, Nov 29, 2016 at 11:55:47AM +0100, Jacek Anaszewski wrote: >>> On 11/29/2016 11:21 AM, Tin Huynh wrote: >>>> This patch enables ACPI support for leds-pca963x driver. >>>> >>>> Signed-off-by: Tin Huynh >>>> --- >>>> drivers/leds/leds-pca963x.c | 25 ++++++++++++++++++++++++- >>>> 1 files changed, 24 insertions(+), 1 deletions(-) >>>> >>>> Change from V1: >>>> -Add CONFIG_ACPI. >>>> >>>> diff --git a/drivers/leds/leds-pca963x.c b/drivers/leds/leds-pca963x.c >>>> index 407eba1..57f11e3 100644 >>>> --- a/drivers/leds/leds-pca963x.c >>>> +++ b/drivers/leds/leds-pca963x.c >>>> @@ -25,6 +25,7 @@ >>>> * or by adding the 'nxp,hw-blink' property to the DTS. >>>> */ >>>> >>>> +#include >>>> #include >>>> #include >>>> #include >>>> @@ -95,6 +96,17 @@ struct pca963x_chipdef { >>>> }; >>>> MODULE_DEVICE_TABLE(i2c, pca963x_id); >>>> >>>> +#ifdef CONFIG_ACPI >>>> +static const struct acpi_device_id pca963x_acpi_ids[] = { >>>> + { "PCA9632", pca9633 }, >>>> + { "PCA9633", pca9633 }, >>>> + { "PCA9634", pca9634 }, >>>> + { "PCA9635", pca9635 }, >>>> + { } >>>> +}; >>>> +MODULE_DEVICE_TABLE(acpi, pca963x_acpi_ids); >>>> +#endif >>>> + >>>> struct pca963x_led; >>>> >>>> struct pca963x { >>>> @@ -322,7 +334,17 @@ static int pca963x_probe(struct i2c_client *client, >>>> struct pca963x_chipdef *chip; >>>> int i, err; >>>> >>>> - chip = &pca963x_chipdefs[id->driver_data]; >>>> + if (id) { >>>> + chip = &pca963x_chipdefs[id->driver_data]; >>>> + } else { >>>> + const struct acpi_device_id *acpi_id; >>>> + >>>> + acpi_id = acpi_match_device(ACPI_PTR(pca963x_acpi_ids), >>>> + &client->dev); >>> >>> What kind of problem did you get while compiling without ACPI_PTR here, >>> when CONFIG_ACPI is disabled? I also tried this configuration but >>> nothing wrong happened. Also at first glance I don't see why lack of >>> ACPI_PTR macro could cause problems. >>> >>> Grep also doesn't show any call to acpi_match_device >>> with ACPI_PTR as the first argument in the existing drivers. >> >> Indeed, that is not needed at all. > Sorry about that . The PATCH V1 should work fine both with or without > CONFIG_ACPI. > So V1 should be better . Please ignore PATCH V2 Reapplied V1. -- Best regards, Jacek Anaszewski