From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58551C433DF for ; Fri, 31 Jul 2020 18:20:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41B0221744 for ; Fri, 31 Jul 2020 18:20:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387772AbgGaSUZ (ORCPT ); Fri, 31 Jul 2020 14:20:25 -0400 Received: from smtprelay0096.hostedemail.com ([216.40.44.96]:34920 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387651AbgGaSUZ (ORCPT ); Fri, 31 Jul 2020 14:20:25 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 97275182CF666; Fri, 31 Jul 2020 18:20:24 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: rest28_1711f9a26f85 X-Filterd-Recvd-Size: 2325 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf15.hostedemail.com (Postfix) with ESMTPA; Fri, 31 Jul 2020 18:20:22 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 2/3] lib/vsprintf: Replace custom spec to print decimals with generic one From: Joe Perches To: Andy Shevchenko , Petr Mladek , Sergey Senozhatsky , linux-kernel@vger.kernel.org, Rasmus Villemoes Cc: Pantelis Antoniou , Rob Herring , Grant Likely , Steven Rostedt Date: Fri, 31 Jul 2020 11:20:21 -0700 In-Reply-To: <20200731180825.30575-2-andriy.shevchenko@linux.intel.com> References: <20200731180825.30575-1-andriy.shevchenko@linux.intel.com> <20200731180825.30575-2-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-07-31 at 21:08 +0300, Andy Shevchenko wrote: > When printing phandle via %pOFp the custom spec is used. First of all, > it has a SMALL flag which makes no sense for decimal numbers. Second, > we have already default spec for decimal numbers. Use the latter in > the %pOFp case as well. [] > diff --git a/lib/vsprintf.c b/lib/vsprintf.c [] > @@ -1979,12 +1979,6 @@ char *device_node_string(char *buf, char *end, struct device_node *dn, > char *buf_start = buf; > struct property *prop; > bool has_mult, pass; > - static const struct printf_spec num_spec = { > - .flags = SMALL, > - .field_width = -1, > - .precision = -1, > - .base = 10, > - }; > > struct printf_spec str_spec = spec; > str_spec.field_width = -1; > @@ -2024,7 +2018,7 @@ char *device_node_string(char *buf, char *end, struct device_node *dn, > str_spec.precision = precision; > break; > case 'p': /* phandle */ > - buf = number(buf, end, (unsigned int)dn->phandle, num_spec); > + buf = number(buf, end, (unsigned int)dn->phandle, default_dec_spec); Could changing .precision = -1 to 0 change any output?