From: Andrey Ryabinin <ryabinin.a.a@gmail.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>,
"Boy Wu (吳勃誼)" <Boy.Wu@mediatek.com>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"andreyknvl@gmail.com" <andreyknvl@gmail.com>,
"dvyukov@google.com" <dvyukov@google.com>,
"kasan-dev@googlegroups.com" <kasan-dev@googlegroups.com>,
"Iverlin Wang (王苳霖)" <Iverlin.Wang@mediatek.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"Light Chen (陳昱光)" <Light.Chen@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"glider@google.com" <glider@google.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"vincenzo.frascino@arm.com" <vincenzo.frascino@arm.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v2] arm: kasan: clear stale stack poison
Date: Mon, 29 Apr 2024 14:57:35 +0200 [thread overview]
Message-ID: <f90f5352-30ed-419f-803b-7885b4298868@gmail.com> (raw)
In-Reply-To: <Zi+Vu29rmNZ0MIFG@shell.armlinux.org.uk>
On 4/29/24 14:42, Russell King (Oracle) wrote:
> On Mon, Apr 29, 2024 at 07:51:49AM +0000, Boy Wu (吳勃誼) wrote:
>> On Sun, 2024-04-28 at 15:45 +0100, Russell King (Oracle) wrote:
>>> On Fri, Apr 12, 2024 at 10:37:06AM +0200, Linus Walleij wrote:
>>>> On Wed, Apr 10, 2024 at 9:31 AM boy.wu <boy.wu@mediatek.com> wrote:
>>>>
>>>>> From: Boy Wu <boy.wu@mediatek.com>
>>>>>
>>>>> We found below OOB crash:
>>>>
>>>> Thanks for digging in!
>>>>
>>>> Pleas put this patch into Russell's patch tracker so he can apply
>>> it:
>>>> https://www.armlinux.org.uk/developer/patches/
>>>
>>> Is this a bug fix? If so, having a Fixes: tag would be nice...
>>>
>>
>> This is a patch for cpuidle flow when KASAN enable, that is in ARM64
>> but not in ARM, so add to ARM.
>>
>> The reference commits did not mention fix any commits.
>> [1] commit 0d97e6d8024c ("arm64: kasan: clear stale stack poison")
>> [2] commit d56a9ef84bd0 ("kasan, arm64: unpoison stack only with
>> CONFIG_KASAN_STACK")
>
> These are not suitable for use as a Fixes: tag because these commits
> refer to code in another part of the tree that has nothing to do with
> the BUG() dump that is contained within your commit message.
>
> I ask again... Is this a bug fix?
>
> Is it a regression?
>
> Is it something that used to work that no longer works?
>
> When did it break?
>
> Has it always been broken?
>
> Has it been broken since KASAN was introduced on 32-bit ARM?
>
Yes, this is a bug fix and it has been broken since KASAN was introduced on 32-bit ARM.
So, I think this should be
Fixes: 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow memory")
next prev parent reply other threads:[~2024-04-29 12:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 7:30 [PATCH v2] arm: kasan: clear stale stack poison boy.wu
2024-04-12 8:37 ` Linus Walleij
2024-04-28 14:45 ` Russell King (Oracle)
2024-04-29 7:51 ` Boy Wu (吳勃誼)
2024-04-29 12:42 ` Russell King (Oracle)
2024-04-29 12:57 ` Andrey Ryabinin [this message]
2024-04-29 13:11 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f90f5352-30ed-419f-803b-7885b4298868@gmail.com \
--to=ryabinin.a.a@gmail.com \
--cc=Boy.Wu@mediatek.com \
--cc=Iverlin.Wang@mediatek.com \
--cc=Light.Chen@mediatek.com \
--cc=andreyknvl@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).