From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934214AbeAXPNA (ORCPT ); Wed, 24 Jan 2018 10:13:00 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:53872 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934032AbeAXPMz (ORCPT ); Wed, 24 Jan 2018 10:12:55 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1AB6E600C1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module To: Hans de Goede , Andy Shevchenko Cc: Mika Westerberg , Wolfram Sang , Eric Auger , eric.auger.pro@gmail.com, linux-i2c , Linux Kernel Mailing List , "linux-acpi@vger.kernel.org" References: <1514988151-12248-1-git-send-email-eric.auger@redhat.com> <20180124055615.c3qwhwnj7spmcr3w@ninjato> <20180124062725.GK27654@lahna.fi.intel.com> <54ef10bd-6209-6983-1d3a-ddf7d7fea252@redhat.com> From: Sinan Kaya Message-ID: Date: Wed, 24 Jan 2018 10:12:53 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <54ef10bd-6209-6983-1d3a-ddf7d7fea252@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/24/2018 9:59 AM, Hans de Goede wrote: > TL;DR: I have to NAK this, I'm sorry but with the current state of ACPI we > must simply have some stuff builtin to help with probe-ordering issues. Now > if the ACPI code where ever to honor the _DEP method everywhere instead of > only for battery devices this might change, but even then things will still > be tricky. Well, the alternative is even worse. Redhat and most other distros configure I2C as a module. With this setup, I2C OpRegion support does not get compiled. It doesn't even work let alone to have race conditions. I2C OpRegion feature is practically dead for most general users unless you recompile your own kernel. There must be a middle ground somewhere. I had some conversation with Rafael about _DEP support. He is not a big fan :) -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.