From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A203C00140 for ; Thu, 18 Aug 2022 20:20:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345655AbiHRUUr (ORCPT ); Thu, 18 Aug 2022 16:20:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239544AbiHRUUp (ORCPT ); Thu, 18 Aug 2022 16:20:45 -0400 Received: from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com [207.171.190.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1E67BFC52; Thu, 18 Aug 2022 13:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1660854045; x=1692390045; h=message-id:date:mime-version:to:cc:references:from: in-reply-to:content-transfer-encoding:subject; bh=kanXrwBuZHMiQBXi6LN1FkIWOY5iRPhyZJ3bP67qawY=; b=kQLI8ayZiGWIvevm30/UOrZKv/eQanU5q5uU+gqh+rDt5cEFdxNCpPcg T510aIOUj2hf7dkH5pDJZmepMJNeQ2HgZFOrAuPgsiQD/dC6/EXfF4Pza spbXVjgvo53ShtKxvFU84F2ZlDCBhi8xrpmC65tTR8BZ6qZoBiPrF/ji/ g=; X-IronPort-AV: E=Sophos;i="5.93,247,1654560000"; d="scan'208";a="219058026" Subject: Re: [PATCH v2 03/16] hwmon: (mr75203) update Moortec PVT controller intel, vm-map property Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-pdx-2a-e6c05252.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-33001.sea14.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2022 20:20:28 +0000 Received: from EX13MTAUEB002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-pdx-2a-e6c05252.us-west-2.amazon.com (Postfix) with ESMTPS id 0167C44B78; Thu, 18 Aug 2022 20:20:27 +0000 (UTC) Received: from EX13D08UEB003.ant.amazon.com (10.43.60.11) by EX13MTAUEB002.ant.amazon.com (10.43.60.12) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Thu, 18 Aug 2022 20:20:26 +0000 Received: from EX13MTAUEB002.ant.amazon.com (10.43.60.12) by EX13D08UEB003.ant.amazon.com (10.43.60.11) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Thu, 18 Aug 2022 20:20:26 +0000 Received: from [192.168.92.216] (10.85.143.172) by mail-relay.amazon.com (10.43.60.234) with Microsoft SMTP Server id 15.0.1497.38 via Frontend Transport; Thu, 18 Aug 2022 20:20:23 +0000 Message-ID: Date: Thu, 18 Aug 2022 23:20:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Content-Language: en-US To: Guenter Roeck CC: , , , , , , , , , , , , , , , , , References: <20220817054321.6519-1-farbere@amazon.com> <20220817054321.6519-4-farbere@amazon.com> <20220818194735.GA3279179@roeck-us.net> From: "Farber, Eliav" In-Reply-To: <20220818194735.GA3279179@roeck-us.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/18/2022 10:47 PM, Guenter Roeck wrote: > Ah. This patch should come first, before making associated > code changes, and there would need to be an explanation > _why_ it is not a mandatory property. Also, some action > is taken in the previous patches if the property is not > there. That indicates that the driver is expected to > use some defaults if the property is indeed not provided, > and that expected default should be documented. Ack. I should have been more clear and explained that driver actually handles the case that "intel,vm-map" does not exist (including an explicit comment - "Incase intel,vm-map property is not defined ...") and that it is actually optional. -- Regards, Eliav