From: simon@mungewell.org
To: "Jean Delvare" <jdelvare@suse.de>
Cc: "Jiri Kosina" <jkosina@suse.cz>,
linux-input@vger.kernel.org,
"LKML" <linux-kernel@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH RESEND] HID: Stop hiding options with !EXPERT
Date: Fri, 20 Feb 2015 13:41:29 -0500 [thread overview]
Message-ID: <f949ff4723760d33685391195404f861.squirrel@mungewell.org> (raw)
In-Reply-To: <20150220173333.5a71d6cb@endymion.delvare>
I can't really comment on the overall situation (Jiri replied to your last
thread), but...
> The HID_LOGITECH option is even worse than the others. Sub-options
> depend on it, and this causes menuconfig and friends to display the
> option even though the user can't change its value. The help page for
> HID_LOGITECH will not explain why the value can't be changed. It only
> says, for example:
Perhaps the Kconfig for Logitech does need some TLC.
It should be remembered that it supports a wide range of devices from
Unifying, to game controllers and wheels. In total it knows about 30
USB-IDs.
>
> Depends on: INPUT [=y] && HID [=y]
>
> and that leaves the user puzzled about why the option is forced to y.
> You might argue that this is a Kconfig bug, but that doesn't make it
> less annoying for the user.
>
> Even worse is that some of the sub-options of HID_LOGITECH select
> INPUT_FF_MEMLESS, which in turn gets out of control for the user. So,
> if you set INPUT=y and HID=y (something most general purpose
> distributions would do these days, as both modules would get loaded on
> a vast majority of systems otherwise), and you want support for
> force-feedback game controllers, you can't have that as a module, it
> has to be built-in, regardless of how rare these devices are.
It make sense to remain as a module (if modules are enabled) when 'INPUT=y
and HID=y', and should not force 'FF_MEMLESS=Y' (just leave that as module
too).
There is also the 'LEDS CLASS' which is required for G27 support. IIRC
there was some 'magic' done with hid-steelseries to tweak problems with
LEDs.
I'd be open to helping this happen, given some guidance.
Simon
next prev parent reply other threads:[~2015-02-20 18:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 16:33 [PATCH RESEND] HID: Stop hiding options with !EXPERT Jean Delvare
2015-02-20 18:41 ` simon [this message]
2015-03-16 15:03 ` Jiri Kosina
2015-03-16 16:22 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f949ff4723760d33685391195404f861.squirrel@mungewell.org \
--to=simon@mungewell.org \
--cc=akpm@linux-foundation.org \
--cc=jdelvare@suse.de \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).