From: David Hildenbrand <david@redhat.com>
To: Miaohe Lin <linmiaohe@huawei.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm/vmstat: remove unneeded return value
Date: Fri, 16 Jul 2021 14:59:14 +0200 [thread overview]
Message-ID: <f9598b11-486f-f047-63ca-ba6a6e1de3e4@redhat.com> (raw)
In-Reply-To: <20210715122911.15700-4-linmiaohe@huawei.com>
On 15.07.21 14:29, Miaohe Lin wrote:
> The return value of pagetypeinfo_showfree and pagetypeinfo_showblockcount
> are unused now. Remove them.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/vmstat.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index 76aef9510f6d..6246bab9fae2 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -1452,7 +1452,7 @@ static void pagetypeinfo_showfree_print(struct seq_file *m,
> }
>
> /* Print out the free pages at each order for each migatetype */
> -static int pagetypeinfo_showfree(struct seq_file *m, void *arg)
> +static void pagetypeinfo_showfree(struct seq_file *m, void *arg)
> {
> int order;
> pg_data_t *pgdat = (pg_data_t *)arg;
> @@ -1464,8 +1464,6 @@ static int pagetypeinfo_showfree(struct seq_file *m, void *arg)
> seq_putc(m, '\n');
>
> walk_zones_in_node(m, pgdat, true, false, pagetypeinfo_showfree_print);
> -
> - return 0;
> }
>
> static void pagetypeinfo_showblockcount_print(struct seq_file *m,
> @@ -1501,7 +1499,7 @@ static void pagetypeinfo_showblockcount_print(struct seq_file *m,
> }
>
> /* Print out the number of pageblocks for each migratetype */
> -static int pagetypeinfo_showblockcount(struct seq_file *m, void *arg)
> +static void pagetypeinfo_showblockcount(struct seq_file *m, void *arg)
> {
> int mtype;
> pg_data_t *pgdat = (pg_data_t *)arg;
> @@ -1512,8 +1510,6 @@ static int pagetypeinfo_showblockcount(struct seq_file *m, void *arg)
> seq_putc(m, '\n');
> walk_zones_in_node(m, pgdat, true, false,
> pagetypeinfo_showblockcount_print);
> -
> - return 0;
> }
>
> /*
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2021-07-16 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 12:29 [PATCH 0/3] Cleanup for vmstat Miaohe Lin
2021-07-15 12:29 ` [PATCH 1/3] mm/vmstat: correct some wrong comments Miaohe Lin
2021-07-15 12:29 ` [PATCH 2/3] mm/vmstat: simplify the array size calculation Miaohe Lin
2021-07-16 12:58 ` David Hildenbrand
2021-07-17 1:54 ` Miaohe Lin
2021-07-15 12:29 ` [PATCH 3/3] mm/vmstat: remove unneeded return value Miaohe Lin
2021-07-16 12:59 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9598b11-486f-f047-63ca-ba6a6e1de3e4@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).