From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
dhowells@redhat.com, acme@kernel.org, adrian.hunter@intel.com,
alexander.shishkin@linux.intel.com, bpf@vger.kernel.org,
davem@davemloft.net, irogers@google.com, jolsa@kernel.org,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
linux-perf-users@vger.kernel.org, mark.rutland@arm.com,
mingo@redhat.com, netdev@vger.kernel.org, peterz@infradead.org,
sfr@canb.auug.org.au
Subject: Re: [PATCH net-next] perf trace: fix MSG_SPLICE_PAGES build error
Date: Tue, 27 Jun 2023 05:31:35 +0200 (GMT+02:00) [thread overview]
Message-ID: <f99109bb-34aa-44d7-9a38-a6df0d6b2ff9@tessares.net> (raw)
In-Reply-To: <20230626144934.4904c2ad@kernel.org>
Hi Jakub, Namhyung,
@Namhyung: thank you for the explanations about the header files in the other thread!
26 Jun 2023 23:49:36 Jakub Kicinski <kuba@kernel.org>:
> On Mon, 26 Jun 2023 14:41:56 -0700 Namhyung Kim wrote:
>
>> But in general you don't need to change the copy of the tools
>> headers together. It also needs to support old & new kernels
>> so different care should be taken. Please separate tooling
>> changes and let us handle them.
>
> Ack, I'm not sure what makes this a special case, from Stephen's
> original report:
>
> https://lore.kernel.org/all/20230626112847.2ef3d422@canb.auug.org.au/
> > it sounded like perf won't build without the fix.
The copy of the header file is confusing :)
If I understood properly, here, we need the modification in msg_flags.c from Perf code because this file has been recently modified by David's series in net-next to support a new flag (not present in the system header files yet). Without this patch, Perf doesn't build.
Now regarding the "internal" copy of header files: we don't need to modify it because it is just used by Perf maintainers to monitor the modifications in the original file. If I'm not mistaken, it might even be better to revert the line that has been removed in David's original series in net-next in this header file. But now that Namhyung is aware of that modification, I guess the revert is probably not needed. But in short, it is then better not to modify this header file in the networking tree :-)
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next prev parent reply other threads:[~2023-06-27 3:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 1:28 linux-next: build failure after merge of the net-next tree Stephen Rothwell
2023-06-26 7:48 ` David Howells
2023-06-26 8:12 ` Stephen Rothwell
2023-06-26 9:02 ` [PATCH net-next] perf trace: fix MSG_SPLICE_PAGES build error Matthieu Baerts
2023-06-26 21:27 ` Jakub Kicinski
2023-06-26 21:41 ` Namhyung Kim
2023-06-26 21:49 ` Jakub Kicinski
2023-06-27 3:31 ` Matthieu Baerts [this message]
2023-06-27 14:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f99109bb-34aa-44d7-9a38-a6df0d6b2ff9@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).