From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: "Michal Simek" <michal.simek@xilinx.com>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>
Cc: linux-fbdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: xilinxfb: constify fb_fix_screeninfo and fb_var_screeninfo structures
Date: Sun, 16 Jul 2017 23:06:42 -0500 [thread overview]
Message-ID: <f9952748-5663-19ae-5417-aaf3c3f01d7e@embeddedor.com> (raw)
In-Reply-To: <c55390b8-c64b-e7ee-8099-5147970d5311@xilinx.com>
On 07/10/2017 02:29 AM, Michal Simek wrote:
> On 8.7.2017 03:24, Gustavo A. R. Silva wrote:
>> These structures are only used to copy into other structures,
>> so declare them as const.
>>
>> This issue was detected using Coccinelle and the following semantic patch:
>>
>> @r disable optional_qualifier@
>> identifier i;
>> position p;
>> @@
>> static struct fb_fix_screeninfo i@p = { ... };
>>
>> @ok@
>> identifier r.i;
>> expression e;
>> position p;
>> @@
>> e = i@p
>>
>> @bad@
>> position p != {r.p,ok.p};
>> identifier r.i;
>> struct fb_fix_screeninfo e;
>> @@
>> e@i@p
>>
>> @depends on !bad disable optional_qualifier@
>> identifier r.i;
>> @@
>> static
>> +const
>> struct fb_fix_screeninfo i = { ... };
>>
>> The semantic patch for fb_var_screeninfo is analogous.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>> drivers/video/fbdev/xilinxfb.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/xilinxfb.c b/drivers/video/fbdev/xilinxfb.c
>> index 17dc119..0bda18e 100644
>> --- a/drivers/video/fbdev/xilinxfb.c
>> +++ b/drivers/video/fbdev/xilinxfb.c
>> @@ -110,14 +110,14 @@ static struct xilinxfb_platform_data xilinx_fb_default_pdata = {
>> /*
>> * Here are the default fb_fix_screeninfo and fb_var_screeninfo structures
>> */
>> -static struct fb_fix_screeninfo xilinx_fb_fix = {
>> +static const struct fb_fix_screeninfo xilinx_fb_fix = {
>> .id = "Xilinx",
>> .type = FB_TYPE_PACKED_PIXELS,
>> .visual = FB_VISUAL_TRUECOLOR,
>> .accel = FB_ACCEL_NONE
>> };
>>
>> -static struct fb_var_screeninfo xilinx_fb_var = {
>> +static const struct fb_var_screeninfo xilinx_fb_var = {
>> .bits_per_pixel = BITS_PER_PIXEL,
>>
>> .red = { RED_SHIFT, 8, 0 },
>>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
Thank you, Michal.
--
Gustavo A. R. Silva
next prev parent reply other threads:[~2017-07-17 4:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170708012420epcas4p3f5cc06fb74847c659e28a80d405f77a0@epcas4p3.samsung.com>
2017-07-08 1:24 ` [PATCH] video: xilinxfb: constify fb_fix_screeninfo and fb_var_screeninfo structures Gustavo A. R. Silva
2017-07-10 7:29 ` Michal Simek
2017-07-17 4:06 ` Gustavo A. R. Silva [this message]
2017-08-01 12:46 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9952748-5663-19ae-5417-aaf3c3f01d7e@embeddedor.com \
--to=garsilva@embeddedor.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).