From: Guenter Roeck <linux@roeck-us.net>
To: Tero Kristo <t-kristo@ti.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] watchdog: rti: tweak min_hw_heartbeat_ms to match initial allowed window
Date: Wed, 1 Jul 2020 06:34:38 -0700 [thread overview]
Message-ID: <f9ab8206-a3a2-ec6e-2c7b-92e369c0996a@roeck-us.net> (raw)
In-Reply-To: <4e9c2731-bf02-1b59-298b-b7f9a0e87d10@ti.com>
On 6/30/20 10:50 PM, Tero Kristo wrote:
[ ... ]
> Hardware supports changing the timeout value, however it only updates this during the next window (preload values are picked once user pings the watchdog.)
>
The current driver doesn't support or use that, though, since the start
function is only called once to start the watchdog, and not at all if
the watchdog is already running. So, if the bootloader sets the timeout
to X, and the user sets a timeout of, say, X * 4, userspace will never
ping the watchdog often enough. The driver will have to address that
to support already-running watchdogs.
Thanks,
Guenter
next prev parent reply other threads:[~2020-07-01 13:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 11:45 [PATCH 0/2] watchdog: rti: adjust initial ping for attach Tero Kristo
2020-06-24 11:45 ` [PATCH 1/2] watchdog: use __watchdog_ping in startup Tero Kristo
2020-06-30 20:36 ` Guenter Roeck
2020-06-24 11:45 ` [PATCH 2/2] watchdog: rti: tweak min_hw_heartbeat_ms to match initial allowed window Tero Kristo
2020-06-24 15:24 ` Jan Kiszka
2020-06-25 8:32 ` Tero Kristo
2020-06-25 10:00 ` Jan Kiszka
2020-06-25 13:35 ` Guenter Roeck
2020-06-25 17:04 ` Tero Kristo
2020-06-30 20:23 ` Guenter Roeck
2020-07-01 5:50 ` Tero Kristo
2020-07-01 13:34 ` Guenter Roeck [this message]
2020-07-01 14:36 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9ab8206-a3a2-ec6e-2c7b-92e369c0996a@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=t-kristo@ti.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).