From: Robin Murphy <robin.murphy@arm.com>
To: Srinath Mannam <srinath.mannam@broadcom.com>,
Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>
Cc: bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Eric Auger <eric.auger@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>
Subject: Re: [RFC PATCH] iommu/arm-smmu: Add module parameter to set msi iova address
Date: Wed, 27 May 2020 18:30:15 +0100 [thread overview]
Message-ID: <f9b221cf-1c7f-9f95-133b-dca65197b6c2@arm.com> (raw)
In-Reply-To: <1590595398-4217-1-git-send-email-srinath.mannam@broadcom.com>
On 2020-05-27 17:03, Srinath Mannam wrote:
> This patch gives the provision to change default value of MSI IOVA base
> to platform's suitable IOVA using module parameter. The present
> hardcoded MSI IOVA base may not be the accessible IOVA ranges of platform.
That in itself doesn't seem entirely unreasonable; IIRC the current
address is just an arbitrary choice to fit nicely into Qemu's memory
map, and there was always the possibility that it wouldn't suit everything.
> Since commit aadad097cd46 ("iommu/dma: Reserve IOVA for PCIe inaccessible
> DMA address"), inaccessible IOVA address ranges parsed from dma-ranges
> property are reserved.
That, however, doesn't seem to fit here; iommu-dma maps MSI doorbells
dynamically, so they aren't affected by reserved regions any more than
regular DMA pages are. In fact, it explicitly ignores the software MSI
region, since as the comment says, it *is* the software that manages those.
The MSI_IOVA_BASE region exists for VFIO, precisely because in that case
the kernel *doesn't* control the address space, but still needs some way
to steal a bit of it for MSIs that the guest doesn't necessarily know
about, and give userspace a fighting chance of knowing what it's taken.
I think at the time we discussed the idea of adding something to the
VFIO uapi such that userspace could move this around if it wanted or
needed to, but decided we could live without that initially. Perhaps now
the time has come?
Robin.
> If any platform has the limitaion to access default MSI IOVA, then it can
> be changed using "arm-smmu.msi_iova_base=0xa0000000" command line argument.
>
> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
> ---
> drivers/iommu/arm-smmu.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index 4f1a350..5e59c9d 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -72,6 +72,9 @@ static bool disable_bypass =
> module_param(disable_bypass, bool, S_IRUGO);
> MODULE_PARM_DESC(disable_bypass,
> "Disable bypass streams such that incoming transactions from devices that are not attached to an iommu domain will report an abort back to the device and will not be allowed to pass through the SMMU.");
> +static unsigned long msi_iova_base = MSI_IOVA_BASE;
> +module_param(msi_iova_base, ulong, S_IRUGO);
> +MODULE_PARM_DESC(msi_iova_base, "msi iova base address.");
>
> struct arm_smmu_s2cr {
> struct iommu_group *group;
> @@ -1566,7 +1569,7 @@ static void arm_smmu_get_resv_regions(struct device *dev,
> struct iommu_resv_region *region;
> int prot = IOMMU_WRITE | IOMMU_NOEXEC | IOMMU_MMIO;
>
> - region = iommu_alloc_resv_region(MSI_IOVA_BASE, MSI_IOVA_LENGTH,
> + region = iommu_alloc_resv_region(msi_iova_base, MSI_IOVA_LENGTH,
> prot, IOMMU_RESV_SW_MSI);
> if (!region)
> return;
>
next prev parent reply other threads:[~2020-05-27 17:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 16:03 [RFC PATCH] iommu/arm-smmu: Add module parameter to set msi iova address Srinath Mannam
2020-05-27 17:30 ` Robin Murphy [this message]
2020-05-28 5:15 ` Srinath Mannam
2020-05-28 7:23 ` Jean-Philippe Brucker
2020-05-28 7:43 ` Auger Eric
2020-05-28 8:38 ` Jean-Philippe Brucker
2020-05-28 8:53 ` Auger Eric
2020-05-28 9:15 ` Shameerali Kolothum Thodi
2020-05-28 11:48 ` Auger Eric
2020-05-28 12:09 ` Shameerali Kolothum Thodi
2020-05-28 13:11 ` Auger Eric
2020-05-28 7:21 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9b221cf-1c7f-9f95-133b-dca65197b6c2@arm.com \
--to=robin.murphy@arm.com \
--cc=alex.williamson@redhat.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinath.mannam@broadcom.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).