From: Iskren Chernev <iskren.chernev@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
devicetree@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 2/3] dt-bindings: regulator: Add document bindings for max77826
Date: Thu, 23 Apr 2020 15:59:34 +0300 [thread overview]
Message-ID: <f9b5d68d-536b-5806-573b-9dafb848f46f@gmail.com> (raw)
In-Reply-To: <20200420205501.GA6828@bogus>
On 4/20/20 11:55 PM, Rob Herring wrote:
> On Mon, Apr 13, 2020 at 07:44:39PM +0300, Iskren Chernev wrote:
>> + patternProperties:
>> + "^LDO([1-9]|1[0-5])$":
>> + type: object
>> + allOf:
>> + - $ref: regulator.yaml#
>> +
>> + "^BUCK|BUCKBOOST$":
>> + type: object
>> + allOf:
>> + - $ref: regulator.yaml#
>> +
>> + additionalProperties: false
>
> You are defining a property called 'additionalProperties'. This one
> should be dropped because additionalProperties doesn't work with a $ref.
>
I got the idea from mps,mpq7920.yaml. It has additionalProperties in the
exact same places that I do. Also bd718(28|37|47).yaml seem to use
additionalProperties inside patternProperties. Shall I modify it as well?
I couldn't find the core schema for this yaml:
http://devicetree.org/meta-schemas/core.yaml (gives 404). Is there a way
to verify the validity of the yaml?
Also, this patch is already merged in linux-next. I guess I shall submit
a new patch with the fixes standalone?
next prev parent reply other threads:[~2020-04-23 12:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 16:44 [PATCH 0/3] regulator: max77826: Add MAX77826 support Iskren Chernev
2020-04-13 16:44 ` [PATCH 1/3] regulator: max77826: Add max77826 regulator driver Iskren Chernev
2020-04-14 10:56 ` Mark Brown
2020-04-13 16:44 ` [PATCH 2/3] dt-bindings: regulator: Add document bindings for max77826 Iskren Chernev
2020-04-20 20:55 ` Rob Herring
2020-04-23 12:59 ` Iskren Chernev [this message]
2020-04-24 14:28 ` Rob Herring
2020-04-13 16:44 ` [PATCH 3/3] ARM: dts: qcom: msm8974-klte: Add max77826 pmic node Iskren Chernev
2020-04-14 10:57 ` [PATCH 0/3] regulator: max77826: Add MAX77826 support Mark Brown
2020-04-14 13:14 ` Iskren Chernev
2020-04-14 14:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9b5d68d-536b-5806-573b-9dafb848f46f@gmail.com \
--to=iskren.chernev@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).