From: Chris Ruehl <chris.ruehl@gtsys.com.hk>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: imx: enable IMX21_UCR3_RXDMUXSEL for non-dte-mode
Date: Fri, 20 Apr 2018 16:56:04 +0800 [thread overview]
Message-ID: <f9cea977-56b8-052d-ccc2-9b6de7cd3645@gtsys.com.hk> (raw)
In-Reply-To: <20180420061316.sakoupltqxn2qhfr@pengutronix.de>
On Friday, April 20, 2018 02:13 PM, Uwe Kleine-König wrote:
> Hello Chris,
>
> On Fri, Apr 20, 2018 at 09:07:59AM +0800, Chris Ruehl wrote:
>> Fix a problem introduced with
>> commit e61c38d85b73 ("serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off")
>> result in non dte-mode imx-uart fail receive data.
>> By add back IMX21_UCR3_RXDMUXSEL the serial port works as expected.
>>
>> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
>> ---
>> drivers/tty/serial/imx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
>> index 91f3a1a..3d09933 100644
>> --- a/drivers/tty/serial/imx.c
>> +++ b/drivers/tty/serial/imx.c
>> @@ -1391,7 +1391,7 @@ static int imx_uart_startup(struct uart_port *port)
>>
>> ucr3 = imx_uart_readl(sport, UCR3);
>>
>> - ucr3 |= UCR3_DTRDEN | UCR3_RI | UCR3_DCD;
>> + ucr3 |= IMX21_UCR3_RXDMUXSEL | UCR3_DTRDEN | UCR3_RI | UCR3_DCD;
>>
>> if (sport->dte_mode)
>> /* disable broken interrupts */
>
> Doesn't 6df765dca378bddf994cfd2044acafa501bd800f fix this for you?
>
> Best regards
> Uwe
>
Uwe,
the patch you point out would fix that problem from what I can see.
But it not yet at the linux-next and since the error persists for 4.9.89
to present I filed a patch simple patch which fix my system.
Let me apply your patch and see if all works well then I fine to drop my
one liner.
Chris
next prev parent reply other threads:[~2018-04-20 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 1:07 [PATCH] serial: imx: enable IMX21_UCR3_RXDMUXSEL for non-dte-mode Chris Ruehl
2018-04-20 6:13 ` Uwe Kleine-König
2018-04-20 8:56 ` Chris Ruehl [this message]
2018-05-03 6:13 ` Chris Ruehl
2018-05-03 20:13 ` Greg Kroah-Hartman
2018-05-04 3:59 ` Chris Ruehl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9cea977-56b8-052d-ccc2-9b6de7cd3645@gtsys.com.hk \
--to=chris.ruehl@gtsys.com.hk \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).