From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934650AbcLTPrM (ORCPT ); Tue, 20 Dec 2016 10:47:12 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:44366 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934392AbcLTPrF (ORCPT ); Tue, 20 Dec 2016 10:47:05 -0500 Subject: Re: [PATCH 3/8] block: move rq_ioc() to blk.h To: Paolo Valente References: <1481933536-12844-1-git-send-email-axboe@fb.com> <1481933536-12844-4-git-send-email-axboe@fb.com> <5A31E864-F10C-4CB4-B780-BB16524E3590@linaro.org> CC: Jens Axboe , , Linux-Kernal , From: Jens Axboe Message-ID: Date: Tue, 20 Dec 2016 08:46:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <5A31E864-F10C-4CB4-B780-BB16524E3590@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: BY1PR20CA0009.namprd20.prod.outlook.com (10.162.140.19) To MWHPR15MB1197.namprd15.prod.outlook.com (10.175.2.139) X-MS-Office365-Filtering-Correlation-Id: 3a25e7fb-73b6-4153-e927-08d428ef6c97 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR15MB1197; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1197;3:tfDQZmo0NUta/aTgGRF3CFZzolWSPfWOtMMlfnsyAhGKaNyIFXgiWa/IUWzoBYbdNssvZ0j4EHGpMee7xqYyg5aDlUlv3O3E3x9xZzLU0MwCz0pJyJKnCLXcSAkECo0EQ2MSfJx3zNB0VbXe/LBEXqIGwNZhaMlUnGIpLkjV4c238ujzOvJUb8sobc/PL9WCKYxOrP4HPw7MzfLjXi2aNvZMGP+pnExAu2qndw7YSW1oGRzsBWZFaIznIoXNG8QlLhqKA4O9N5B8SGiyiTM8kA==;25:DRBCWf/mqp5Rvc4p04u5ChXbFmMLBAogWNOhUKHqityQl/M1rl7wz1qoDXfW9C48u5UphOUDkdL6KuxYIz/je+E6JWpSk0PeMOOWBo1oCOwuviHcDQBajUC0oeQy1P+Uh20zTv3g9DoLjCzbSScnryD5i07qCqn1h47pacHMG78fbPQpfTYqJ7g7mMGTZ8OxzBkCDbe2FVrW6VEtW1Xd0+v0yLxbcRoKqr43LjfLuhNOPw37IsG7ySFSru0Nmmvq+/QIT8C8bGR+1n40JoH/Y/1zInAkBxkYjKoz40Z/fsDpNGo4e8DNzmnO/0H3md1MCNLOgBzOusvlkOYBP/3s/v/biJ5CJXP8mmWspuk9ipi6A8ccnh93nJ1+wjBrm6tEwKLTwB7Odvwe20+M3M/QKcDcHe1NuLxIc/73hPjtB3PcpNr/gx0bmr2uVPtuidKoXmLQaQnGvD7r8xMZJoSqGQ== X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1197;31:aUKLp2NI+1M1WJOVDoRqmbnBP14abX8UUz0Blm0PrI7UzF6YyqQQYKpHrjLnTawlcUL9yiqEc+9Zg6SaubsHzs3ZnslpzWeisEUTp3G8Wfjbq1YqqsiRwQoHJilSAtgyp4dkslTUzJA/KTCc4s2esp9phfNwbwL6kRkPDWAA2pYW4eHASaOxJti1SKQgYqKqF5pP8CsZqcYJXiNYJwRxXJJocRbaUS9rc9Lh8CXdSXrhtycm7aG9PuQ92PiLrQ0rg1YQzS37dXJhNZpNCliL+w==;20:8F2wt1jXftK/Oc7RzuVPY8mzF5I2hZ84br2nVrXj5aKb9UjHWSAPPo1xVpd2HXq1yaKbQsgZC8OJkl9r0Ew3DQ8kBOFqQfwaMhth3x8gjtEPWzSzny4g2IZXlTeO9WjosbbH34dyhizsiaqWIKsPb1vSP8NDFcanNYzF1kmDp8qvjAgBR4drH5o8/tro07ZjrxQvycRdojaFP6britnoBy1Nmi7EKh9ECPCFcIiAKUCNZ84sIuD+M7UAWOflZaPrqkCgFadjnAsvhLkUuTfNRIu3mAL49we73HnvoqwFDj9c6jR1y7LTIpKeqveRX1KFF39u+oU0kX2EPwH8L6waBoASmZTS5GekN4MKEB1WDoZWFa2vd2e16QwYQXC6QYbbIqBEE2x5DeSgUq2dA+fXtdzY2m7afogKLQ+ASJV0YCfX72tnbXw52SP9/3w/lO2f9zrfR61zPQ+jrRK2ed06s84mrNYitc2O7rDe9SPqgolGAPDhUIX7KJ1LWAV1BFH3 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(6072148);SRVR:MWHPR15MB1197;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1197; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1197;4:ZQzvA71DwPbagVZMEMiOHjzYMZfoa6XeSzta23g1DthWZmc8ce7LzmVeJY9cfRlp88J/0vNsUQOW0rXgbAX/ZD5ExHpGNJFWWo7m3AehDk66/4RMAgJ8jPnknHydT1kUlokS4BpXIjmyJ0xbh3AM21GXvbPg9cUc5RUgka27d9GxXpF/D8XFzrYmrCayc2LUVu9ZRtMIvvshU86G0jxqvT67xxmqDlIrI3GYdiqb+fclHwAOhxjM4Bjj65/Eun2f8OD8CslIcAPbTELpkdEbsl+gc3wd0wb7HVCE6LuCF7upuBdZgTk5MaPXhCaJAy8S2mHhYluDiw+o47fP1T57H/esED2Eh4TZ77TE3RX0xlGg+Gc69NM/0NJ3ZT95jezRP/LKiCyoQG3D53v4gOwbRJxqIWWk8v3PkTar/GP3ysWxulssNcsUFH/fPa8PmI8MlYutPvioBH+NJ5zluQP4aDJcqKh+BWsZNDg72XYsfRqVwUpi7r0JCXlJTqrZQ3JbWPsCdQYntXb7PHbqojJT2BnH22jfL0hvGyRFEDsbWX/4euOran++puSI/SioMBGccyEAkoE/5vwIqKoSuJnhVI59yo1SE8eyrzT8+u+5pL8YlxUGJuVI/8sNh0XGHdaD X-Forefront-PRVS: 0162ACCC24 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(39410400002)(39450400003)(39830400002)(189002)(24454002)(199003)(377454003)(4326007)(81156014)(92566002)(97736004)(117156001)(105586002)(106356001)(86362001)(33646002)(8676002)(110136003)(6916009)(50466002)(305945005)(7736002)(31696002)(6666003)(65826007)(2950100002)(68736007)(64126003)(5660300001)(3846002)(42186005)(4001350100001)(76176999)(36756003)(77096006)(6486002)(229853002)(81166006)(38730400001)(6116002)(90366009)(189998001)(2906002)(83506001)(47776003)(65806001)(66066001)(101416001)(50986999)(25786008)(54356999)(31686004)(230700001)(23746002)(65956001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1197;H:[192.168.1.176];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;MWHPR15MB1197;23:da6sBmuu0GDqPuB2LR7+MDr5fuzq2lKIkLAmZ?= =?Windows-1252?Q?zkQQ2NSXV8otDetQl5nbsTxysxIjt/Qck1TNYnfqoDRHfp8Or8qJ7ISL?= =?Windows-1252?Q?TZL98sXY4ezk1YE0KVjz9Gx14L8fpmxIUJv8H9HIIxjzXV+VYSzmelIE?= =?Windows-1252?Q?/ywwQX9l6DT1u3n5MFY455ehLLPpDVlMBMECEziGV+ry0CdWwZiTvZZJ?= =?Windows-1252?Q?AzMjxOr+LOJmthgmIlv/50Nqeeph8TnzSEota1rhWCLR5p8hXDtD2O9M?= =?Windows-1252?Q?AwWyEqA41jNpcT/M0uL43NhaFs3q4/jBx51c+7SvFcmIKf20YTaDpbKN?= =?Windows-1252?Q?EERSEL0W9CeCPFGEGy/sx2LVkxGEGm6kxPQNrclfu4l9Hbio74DCqcLb?= =?Windows-1252?Q?TdRlZvSnEsrbQoWubqJZT7WbAj4rGgceZZBGvZm3ShtFBfVmG84cuVmK?= =?Windows-1252?Q?8IMFdckVqB8FUDS416UpdRasRgk12cd+vScum3WiTTVwUz9xOzw0sBFO?= =?Windows-1252?Q?UAA0l6SdwH5uoNhHdabfGKMXO0GwKOipzEo2bW5fMk/GoiucMF0C/513?= =?Windows-1252?Q?ssLn/G5zXhg1a36bmqBGn+EX5UFqFUauPy6b3kDnsiiZ4rfE9FKYc+w3?= =?Windows-1252?Q?q0Yv2UjnWPd8WPqa+elX5ke8yNj1RJ20lUnBR481EQFRf4q94wwUMqaw?= =?Windows-1252?Q?CYGO3mwkhFGvFwEv80+yM585CB9xYZLgLa0DEm7SkjmjOaRPubhJoGpq?= =?Windows-1252?Q?Vk7WOAZ7bukCVeO/ejJljMJfvY3GWE89UfCHGxcKU/n8cZaYjGJf5vH5?= =?Windows-1252?Q?lD9qYVPgKRhRzAeFitGw84HV//Y6AmXlXctlklVcEcK6nY1OeAqhyTvE?= =?Windows-1252?Q?hsRtEplBWS1qubajE0Z+zDbLtvp9RN3bWsIpjvkXndKPgVY1EXc5KQDv?= =?Windows-1252?Q?8+qSIGTaGPmRH2oRWx7pChMdbZh2V6gXSHVXrS03fuqBnXJGGUwmcM8N?= =?Windows-1252?Q?kgm0b/jXPW+Ub56kVME1NQBmIGyQPIeJAJgWTyjYs7tIWVTCHdGPcJ2G?= =?Windows-1252?Q?NX0xT5wxbUhQAB5SkBnm6sf3wgdJZAXuqOtHx9kBp/G2CKdSPhtkTbl0?= =?Windows-1252?Q?NSRrt5Kb4N2pHldvXxHpK6bQHpv9YGYBBDfhhD8H54nnhtvEXvVR1M9d?= =?Windows-1252?Q?nIFG/GUuAieihPwdlAqizGShDDSkDXPOWW73pgHU5YIuA2i5HQ7zd+Rc?= =?Windows-1252?Q?qAtYfMNUseiCV1hlnXpnwnxO1ksVSiXjnKTjr7JivUIFlMw8KG8CiRy+?= =?Windows-1252?Q?JZXOH2l5KJKTOA+HXZwvxWn+ZMEd7S1lkxwmkHMGr56Emh57dmu8G8YP?= =?Windows-1252?Q?y/c8xAzaUEG0V/EC2uZTPu9rsBiVX1doBO8Czld2vyhY6aXJilfows4G?= =?Windows-1252?Q?742u2zh641o5Aptg/CrXjwtfRFJ29A1xIj4vAb9osz/7AFAPZ9cNugVk?= =?Windows-1252?Q?KjgA7U4qOe+IeTuBVgnESPjB+w/K1tkcP3clE8JYcLTnF1X9w=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1197;6:YIyWUmgRJjToda9JbpnDqWcoPCHqXiDzC4S1xOZl7rRSgL2omR08eUkIsL4zB5TS1l4c7eJqzQ2CgkgUF3VGjcvNqdb8CamxJvrwpB9di/k5/sGIdFibb6X/l1Dc67R9xePGCik8xCfkKHqJBS1G+8EHaSsqnWoBUnCTI/NTZaH8lkaraJTmYfE5B/uOQNZqKHibJLFT8u6dUemCuN8Drl+7UhNWkItVIv0RhW6NhUeLUSs+SbN2B/FxgAwgVffBp40t3jhjYAhhhRc9A1PmmdDmS97nWM0e4NZsV3bi3IL/7vXsfRF7f74im093Ii787pGRx2M8tPgzMm88Q/OHSkX6trX8OZytZ1HHkLonLwjfMK3TYBUUBu8WQkvfR2NE8dMdIch2wujOtMLp5FA2mmuvHIVJRgubJklrrgVMx0s=;5:wHmZTwVdsexW2LoyKPg3xDrxKpVxy76saB3Urj/LglxWuTqzfWfdaw1WbR8Scbn3JE4WqAlY2jHtx49cUsGkFZS+HNLpO1BpY7BKtGKlHH9otyo/sVGsfrdt0dDixj2u1Cqjdq3zGy3GBVSMZWV7gGuCzKXr9OWJ0Vrhl4oS/X4=;24:XwyJQmaDk1QMgPhK9Eki+7P/OGWHiqBM/llu5wjVIFiIS0z0lJaMejr5Jaz3SEfBTvdilGSpl8bjld03fmWvecC6mO2TbiDK6iRqllaZhkA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1197;7:uNMQj4bWKaevGOc3LvkDRn8FLkkJJoghA6/ZVF/cSYmOGI2gBfTesrldHnfZBrftXlOxY1nggEtcugtzotlEMRDGu1M94xW1Wts24cJdq2DbD4Cz9xpJF8lqeP21cfyr11fDEp7URz0FYDIonZLAZ2x/lj2HAgkJCtmMUWoBOaoGJn4qFIduUUZyNPkVF9Z22Tj5v0tohIzCSXZGAYOViVVIP7yAZZdzFWrZiAGbdJ6IAcwU2ExrCQcMSKbABtdCM1bOmyNNVDEesTaK0IGHR3HKf6Llt6vHZoMC2Q8e2kpO3pibASq5ttX+EUNA2TUJDmKBy/kquyQ34j4ntdF0FivLL35Gld+s2xNawtCMDqtuQIlHyopk+XiW/L05COh8SuCnuRmK1NOCF27lf/ae/Jv5nfubeGctjIXCv7kip90kk/zwAkLReSAAAj342V6BQDkd82LGtMARFfJD0mbt9w==;20:C32rBD0Cvkf6DFH10+RZxBzQVVQP9QSEC2e9I/GVzgNM6AAOhdSu5cWvqX0mpUt+0TN89gh0kGAzeU5Cr6QxRVuGJ95Eql/tPG/x80aUM0ZX6KOomn1d1ylfq2v1bs3Xa4QHM541snMC7J21oi8TluI3vZlxyJAGqFTvEcl8d+s= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2016 15:46:54.0513 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1197 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-20_10:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/20/2016 03:12 AM, Paolo Valente wrote: > >> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >> >> We want to use it outside of blk-core.c. >> > > Hi Jens, > no hooks equivalent to elevator_init_icq_fn and elevator_exit_icq_fn > are invoked. In particular, the second hook let bfq (as with cfq) > know when it could finally exit the queue associated with the icq. > I'm trying to figure out how to make it without these hooks/signals, > but at no avail so far ... Yep, those need to be added. -- Jens Axboe