From: "Herrenschmidt, Benjamin" <benh@amazon.com>
To: "maz@kernel.org" <maz@kernel.org>, "Saidi, Ali" <alisaidi@amazon.com>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"jason@lakedaemon.net" <jason@lakedaemon.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"Zilberman, Zeev" <zeev@amazon.com>,
"Machulsky, Zorik" <zorik@amazon.com>
Subject: Re: [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq
Date: Wed, 3 Jun 2020 22:14:50 +0000 [thread overview]
Message-ID: <f9e9d8c37eb92e4b9576bfcb4386ff6ef00eddce.camel@amazon.com> (raw)
In-Reply-To: <622fb6be108e894ee365d6b213535c8b@kernel.org>
On Wed, 2020-06-03 at 16:16 +0100, Marc Zyngier wrote:
> > My original patch should certain check activated and not disabled.
> > With that do you still have reservations Marc?
>
> I'd still prefer it if we could do something in core code, rather
> than spreading these checks in the individual drivers. If we can't,
> fair enough. But it feels like the core set_affinity function could
> just do the same thing in a single place (although the started vs
> activated is yet another piece of the puzzle I didn't consider,
> and the ITS doesn't need the "can_reserve" thing).
For the sake of fixing the problem in a timely and backportable way I
would suggest first merging the fix, *then* fixing the core core.
Cheers,
Ben.
next prev parent reply other threads:[~2020-06-03 22:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 18:47 [PATCH] irqchip/gic-v3-its: Don't try to move a disabled irq Saidi, Ali
2020-06-03 15:16 ` Marc Zyngier
2020-06-03 22:14 ` Herrenschmidt, Benjamin [this message]
2020-06-08 13:48 ` Thomas Gleixner
2020-06-08 21:59 ` Benjamin Herrenschmidt
2020-06-08 23:36 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2020-06-11 17:44 Saidi, Ali
2020-05-29 1:55 Ali Saidi
2020-05-29 4:07 ` Zenghui Yu
2020-05-29 8:32 ` Marc Zyngier
2020-05-29 12:36 ` Saidi, Ali
2020-05-30 16:49 ` Marc Zyngier
2020-05-31 11:09 ` Marc Zyngier
2020-06-01 0:10 ` Saidi, Ali
2020-06-01 2:40 ` Herrenschmidt, Benjamin
2020-06-02 20:54 ` Thomas Gleixner
2020-06-03 12:44 ` Marc Zyngier
2020-05-31 2:53 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9e9d8c37eb92e4b9576bfcb4386ff6ef00eddce.camel@amazon.com \
--to=benh@amazon.com \
--cc=alisaidi@amazon.com \
--cc=dwmw@amazon.co.uk \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=zeev@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).