From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S978568AbdDXWuM (ORCPT ); Mon, 24 Apr 2017 18:50:12 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53472 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S977711AbdDXWuC (ORCPT ); Mon, 24 Apr 2017 18:50:02 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 478E2612D7 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org Subject: Re: [PATCH] ACPI / GED: use late init to allow other drivers init To: Sinan Kaya , linux-acpi@vger.kernel.org, timur@codeaurora.org Cc: "Rafael J. Wysocki" , Len Brown , linux-kernel@vger.kernel.org References: <1492813704-32280-1-git-send-email-okaya@codeaurora.org> From: "Baicar, Tyler" Message-ID: Date: Mon, 24 Apr 2017 16:49:59 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <1492813704-32280-1-git-send-email-okaya@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/21/2017 4:28 PM, Sinan Kaya wrote: > GED driver is currently set up as a platform driver. On modern operating > systems, most of the drivers are compiled as kernel modules. It is possible > that a GED interrupt event is received and the driver such as GHES/GPIO/I2C > to service it is not available yet. To accommodate this use case, delay > GED driver load to the late init phase. > > Signed-off-by: Sinan Kaya Tested-by: Tyler Baicar This resolves the GHES issue described here: https://lkml.org/lkml/2017/3/28/1083 Thanks, Tyler > --- > drivers/acpi/evged.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/evged.c b/drivers/acpi/evged.c > index 46f0603..30e638b 100644 > --- a/drivers/acpi/evged.c > +++ b/drivers/acpi/evged.c > @@ -151,4 +151,10 @@ static int ged_probe(struct platform_device *pdev) > .acpi_match_table = ACPI_PTR(ged_acpi_ids), > }, > }; > -builtin_platform_driver(ged_driver); > + > +static __init int ged_init(void) > +{ > + return platform_driver_register(&ged_driver); > +} > + > +late_initcall(ged_init); -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.