From: "Raphaël Beamonte" <raphael.beamonte@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Raphaël Beamonte" <raphael.beamonte@gmail.com>,
"Antoine Schweitzer-Chaput" <antoine@schweitzer-chaput.fr>,
"Cristina Opriceana" <cristina.opriceana@gmail.com>,
"Greg Donald" <gdonald@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 19/20] staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() code style issue
Date: Sat, 15 Aug 2015 21:34:15 -0400 [thread overview]
Message-ID: <fa05eaa95e594f670d6f5a9c104fb6bc440b03ee.1439688440.git.raphael.beamonte@gmail.com> (raw)
In-Reply-To: <cover.1439688440.git.raphael.beamonte@gmail.com>
In-Reply-To: <cover.1439688440.git.raphael.beamonte@gmail.com>
Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index 0048cff..28074ca 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -3469,7 +3469,7 @@ static int r8192_set_mac_adr(struct net_device *dev, void *mac)
down(&priv->wx_sem);
- memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
+ ether_addr_copy(dev->dev_addr, addr->sa_data);
schedule_work(&priv->reset_wq);
up(&priv->wx_sem);
--
2.1.4
next prev parent reply other threads:[~2015-08-16 1:37 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-16 1:33 [PATCH 00/20] staging: rtl8192u: r8192U_core: fix all checkpatch.pl reports Raphaël Beamonte
2015-08-16 1:33 ` [PATCH 01/20] staging: rtl8192u: r8192U_core: fix switch and case indent code style error Raphaël Beamonte
2015-08-16 1:33 ` [PATCH 02/20] staging: rtl8192u: r8192U_core: fix consistent spacing " Raphaël Beamonte
2015-08-18 5:02 ` Sudip Mukherjee
2015-08-18 5:38 ` Raphaël Beamonte
2015-08-18 5:44 ` Sudip Mukherjee
2015-08-18 6:02 ` Raphaël Beamonte
2015-08-18 6:14 ` Sudip Mukherjee
2015-08-16 1:33 ` [PATCH 03/20] staging: rtl8192u: t8192U_core: fix space before close parenthesis " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 04/20] staging: rtl8192u: r8192U_core: fix code indent using spaces " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 05/20] staging: rtl8192u: r8192U_core: fix else following close brace " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 06/20] staging: rtl8192u: r8192U_core: fix missing struct leading to consistent spacing " Raphaël Beamonte
2015-08-18 5:17 ` Sudip Mukherjee
2015-08-16 1:34 ` [PATCH 07/20] staging: rtl8192u: r8192_core: whitespace neatening Raphaël Beamonte
2015-08-18 5:24 ` Sudip Mukherjee
2015-08-16 1:34 ` [PATCH 08/20] staging: rtl8192u: r8192_core: clean C99 // comments Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 09/20] staging: rtl8192u: r8192U_core: include linux/uaccess.h instead of asm/uaccess.h Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 10/20] staging: rtl8192u: r8192U_core: remove return statement of void function Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 11/20] staging: rtl8192u: r8192U_core: fix unecessary braces code style issue Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 12/20] staging: rtl8192u: r8192U_core: fix externs in .c file " Raphaël Beamonte
2015-08-18 5:30 ` Sudip Mukherjee
2015-08-18 5:40 ` Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 13/20] staging: rtl8192u: r8192U_core: fix unnecessary check before kfree " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 14/20] staging: rtl8192u: r8192U_core: fix unnecessary parentheses " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 15/20] staging: rtl8192u: r8192U_core: fix unnecessary else after return " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 16/20] staging: rtl8192u: r8192U_core: fix unnecessary whitespace " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 17/20] staging: rtl8192u: r8192U_core: fix missing blank line after declarations " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 18/20] staging: rtl8192u: r8192U_core: fix quoted string split across lines " Raphaël Beamonte
2015-08-16 1:34 ` Raphaël Beamonte [this message]
2015-08-16 1:34 ` [PATCH 20/20] staging: rtl8192u: r8192U_core: fix line over 80 characters " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 00/19] staging: rtl8192u: r8192U_core: fix all checkpatch.pl reports Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 01/19] staging: rtl8192u: r8192U_core: fix switch and case indent code style error Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 02/19] staging: rtl8192u: r8192U_core: fix space before close parenthesis " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 03/19] staging: rtl8192u: r8192U_core: fix code indent using spaces " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 04/19] staging: rtl8192u: r8192U_core: fix else following close brace " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 05/19] staging: rtl8192u: r8192U_core: fix missing struct leading to consistent spacing " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 06/19] staging: rtl8192u: r8192U_core: whitespace neatening to fix consistent spacing code style errors Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 07/19] staging: rtl8192u: r8192U_core: clean C99 // comments Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 08/19] staging: rtl8192u: r8192U_core: include linux/uaccess.h instead of asm/uaccess.h Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 09/19] staging: rtl8192u: r8192U_core: remove return statement of void function Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 10/19] staging: rtl8192u: r8192U_core: fix unecessary braces code style issue Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 11/19] staging: rtl8192u: r8192U_core: remove forward declarations in .c file Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 12/19] staging: rtl8192u: r8192U_core: fix unnecessary check before kfree code style issue Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 13/19] staging: rtl8192u: r8192U_core: fix unnecessary parentheses " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 14/19] staging: rtl8192u: r8192U_core: fix unnecessary else after return " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 15/19] staging: rtl8192u: r8192U_core: fix unnecessary whitespace " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 16/19] staging: rtl8192u: r8192U_core: fix missing blank line after declarations " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 17/19] staging: rtl8192u: r8192U_core: fix quoted string split across lines " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 18/19] staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() " Raphaël Beamonte
2015-09-03 17:00 ` Greg Kroah-Hartman
2015-09-05 22:16 ` Raphaël Beamonte
2015-09-06 0:44 ` Greg Kroah-Hartman
2015-09-06 2:15 ` [PATCHv2] " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 19/19] staging: rtl8192u: r8192U_core: fix line over 80 characters " Raphaël Beamonte
2015-08-19 10:50 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa05eaa95e594f670d6f5a9c104fb6bc440b03ee.1439688440.git.raphael.beamonte@gmail.com \
--to=raphael.beamonte@gmail.com \
--cc=antoine@schweitzer-chaput.fr \
--cc=cristina.opriceana@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).