From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E43BC433FF for ; Mon, 29 Jul 2019 07:22:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C56F2184B for ; Mon, 29 Jul 2019 07:22:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726876AbfG2HW1 (ORCPT ); Mon, 29 Jul 2019 03:22:27 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3229 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725917AbfG2HW1 (ORCPT ); Mon, 29 Jul 2019 03:22:27 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 75FAC6D82EC4BAD96A58; Mon, 29 Jul 2019 15:22:24 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 29 Jul 2019 15:22:22 +0800 Subject: Re: [f2fs-dev] [PATCH v4 3/3] f2fs: Support case-insensitive file name lookups To: Jaegeuk Kim , Chao Yu CC: Daniel Rosenberg , Jonathan Corbet , , , , , , References: <20190723230529.251659-1-drosen@google.com> <20190723230529.251659-4-drosen@google.com> <9362e4ed-2be8-39f5-b4d9-9c86e37ab993@kernel.org> <20190729062735.GA98839@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: Date: Mon, 29 Jul 2019 15:22:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190729062735.GA98839@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/7/29 14:27, Jaegeuk Kim wrote: > On 07/28, Chao Yu wrote: >> On 2019-7-24 7:05, Daniel Rosenberg via Linux-f2fs-devel wrote: >>> /* Flags that are appropriate for regular files (all but dir-specific ones). */ >>> #define F2FS_REG_FLMASK (~(F2FS_DIRSYNC_FL | F2FS_PROJINHERIT_FL)) >> >> We missed to add F2FS_CASEFOLD_FL here to exclude it in F2FS_REG_FLMASK. > > Applied. > >> >>> @@ -1660,7 +1660,16 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask) >>> return -EPERM; >>> >>> oldflags = fi->i_flags; >>> + if ((iflags ^ oldflags) & F2FS_CASEFOLD_FL) { >>> + if (!f2fs_sb_has_casefold(F2FS_I_SB(inode))) >>> + return -EOPNOTSUPP; >>> + >>> + if (!S_ISDIR(inode->i_mode)) >>> + return -ENOTDIR; >>> >>> + if (!f2fs_empty_dir(inode)) >>> + return -ENOTEMPTY; >>> + } > > Modified like this: > @@ -1665,6 +1665,13 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask) > if (IS_NOQUOTA(inode)) > return -EPERM; > > + if ((iflags ^ fi->i_flags) & F2FS_CASEFOLD_FL) { > + if (!f2fs_sb_has_casefold(F2FS_I_SB(inode))) > + return -EOPNOTSUPP; > + if (!f2fs_empty_dir(inode)) > + return -ENOTEMPTY; > + } > + > > Note that, directory is checked by above change. > > I've uploaded in f2fs.git, so could you check it out and test a bit? I've checked it out, it looks good to me now, and later I will test this new version. Reviewed-by: Chao Yu Thanks, > > Thanks, > >> >> I applied the patches based on last Jaegeuk's dev branch, it seems we needs to >> adjust above code a bit. Otherwise it looks good to me. >> >> BTW, it looks the patchset works fine with generic/556 testcase. >> >> Thanks, > . >