From: Rashika Kheria <rashika.kheria@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Armin Schindler <mac@melware.de>,
Karsten Keil <isdn@linux-pingi.de>,
netdev@vger.kernel.org, josh@joshtriplett.org
Subject: [PATCH 25/26] drivers: isdn: Move prototype declaration to header file dadapter.h
Date: Fri, 7 Feb 2014 18:18:58 +0530 [thread overview]
Message-ID: <fa09a161cd57206bfac7f3ea2817fb6d535c727c.1390408520.git.rashika.kheria@gmail.com> (raw)
In-Reply-To: <3cb4d7892ba5a0c0936b3a1e2c9c991a6dbc3229.1390408513.git.rashika.kheria@gmail.com>
Move prototype declaration of functions to header file
hardware/eicon/dadapter.h because they are used by more than one file.
This eliminates the following warning in hardware/eicon/dadapter.c:
drivers/isdn/hardware/eicon/dadapter.c:361:22: warning: no previous prototype for ‘DIVA_DIDD_Read’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
drivers/isdn/hardware/eicon/capifunc.c | 3 +--
drivers/isdn/hardware/eicon/dadapter.h | 1 +
drivers/isdn/hardware/eicon/diddfunc.c | 1 -
drivers/isdn/hardware/eicon/diva_didd.c | 2 --
drivers/isdn/hardware/eicon/divasfunc.c | 3 +--
drivers/isdn/hardware/eicon/idifunc.c | 3 +--
drivers/isdn/hardware/eicon/mntfunc.c | 3 +--
7 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/isdn/hardware/eicon/capifunc.c b/drivers/isdn/hardware/eicon/capifunc.c
index 639d70f..3bcb602 100644
--- a/drivers/isdn/hardware/eicon/capifunc.c
+++ b/drivers/isdn/hardware/eicon/capifunc.c
@@ -18,6 +18,7 @@
#include "divacapi.h"
#include "divasync.h"
#include "capifunc.h"
+#include "dadapter.h"
#define DBG_MINIMUM (DL_LOG + DL_FTL + DL_ERR)
#define DBG_DEFAULT (DBG_MINIMUM + DL_XLOG + DL_REG)
@@ -55,8 +56,6 @@ static char *diva_procinfo(struct capi_ctr *);
static u16 diva_send_message(struct capi_ctr *,
diva_os_message_buffer_s *);
-extern void DIVA_DIDD_Read(DESCRIPTOR *, int);
-
/*
* debug
*/
diff --git a/drivers/isdn/hardware/eicon/dadapter.h b/drivers/isdn/hardware/eicon/dadapter.h
index 5540f46..f6cdebf 100644
--- a/drivers/isdn/hardware/eicon/dadapter.h
+++ b/drivers/isdn/hardware/eicon/dadapter.h
@@ -28,6 +28,7 @@
void diva_didd_load_time_init(void);
void diva_didd_load_time_finit(void);
+void IDI_CALL_LINK_T DIVA_DIDD_Read(void IDI_CALL_ENTITY_T *buffer, int length);
#define NEW_MAX_DESCRIPTORS 64
diff --git a/drivers/isdn/hardware/eicon/diddfunc.c b/drivers/isdn/hardware/eicon/diddfunc.c
index b0b23ed..a8a229f 100644
--- a/drivers/isdn/hardware/eicon/diddfunc.c
+++ b/drivers/isdn/hardware/eicon/diddfunc.c
@@ -20,7 +20,6 @@
#define DBG_DEFAULT (DBG_MINIMUM + DL_XLOG + DL_REG)
-extern void DIVA_DIDD_Read(void *, int);
extern char *DRIVERRELEASE_DIDD;
static dword notify_handle;
static DESCRIPTOR _DAdapter;
diff --git a/drivers/isdn/hardware/eicon/diva_didd.c b/drivers/isdn/hardware/eicon/diva_didd.c
index 56d32a7..b8e525f 100644
--- a/drivers/isdn/hardware/eicon/diva_didd.c
+++ b/drivers/isdn/hardware/eicon/diva_didd.c
@@ -39,8 +39,6 @@ MODULE_LICENSE("GPL");
#define DBG_MINIMUM (DL_LOG + DL_FTL + DL_ERR)
#define DBG_DEFAULT (DBG_MINIMUM + DL_XLOG + DL_REG)
-extern void DIVA_DIDD_Read(void *, int);
-
static struct proc_dir_entry *proc_didd;
struct proc_dir_entry *proc_net_eicon = NULL;
diff --git a/drivers/isdn/hardware/eicon/divasfunc.c b/drivers/isdn/hardware/eicon/divasfunc.c
index 4be5f88..a5d44d0 100644
--- a/drivers/isdn/hardware/eicon/divasfunc.c
+++ b/drivers/isdn/hardware/eicon/divasfunc.c
@@ -17,14 +17,13 @@
#include "divasync.h"
#include "diva.h"
#include "xdi_vers.h"
+#include "dadapter.h"
#define DBG_MINIMUM (DL_LOG + DL_FTL + DL_ERR)
#define DBG_DEFAULT (DBG_MINIMUM + DL_XLOG + DL_REG)
static int debugmask;
-extern void DIVA_DIDD_Read(void *, int);
-
extern PISDN_ADAPTER IoAdapters[MAX_ADAPTER];
extern char *DRIVERRELEASE_DIVAS;
diff --git a/drivers/isdn/hardware/eicon/idifunc.c b/drivers/isdn/hardware/eicon/idifunc.c
index bacab74..dc79095 100644
--- a/drivers/isdn/hardware/eicon/idifunc.c
+++ b/drivers/isdn/hardware/eicon/idifunc.c
@@ -15,14 +15,13 @@
#include "divasync.h"
#include "um_xdi.h"
#include "um_idi.h"
+#include "dadapter.h"
#define DBG_MINIMUM (DL_LOG + DL_FTL + DL_ERR)
#define DBG_DEFAULT (DBG_MINIMUM + DL_XLOG + DL_REG)
extern char *DRIVERRELEASE_IDI;
-extern void DIVA_DIDD_Read(void *, int);
-
static dword notify_handle;
static DESCRIPTOR DAdapter;
static DESCRIPTOR MAdapter;
diff --git a/drivers/isdn/hardware/eicon/mntfunc.c b/drivers/isdn/hardware/eicon/mntfunc.c
index e304a1d..be47431 100644
--- a/drivers/isdn/hardware/eicon/mntfunc.c
+++ b/drivers/isdn/hardware/eicon/mntfunc.c
@@ -15,14 +15,13 @@
#include "di_defs.h"
#include "divasync.h"
#include "debug_if.h"
+#include "dadapter.h"
extern char *DRIVERRELEASE_MNT;
#define DBG_MINIMUM (DL_LOG + DL_FTL + DL_ERR)
#define DBG_DEFAULT (DBG_MINIMUM + DL_XLOG + DL_REG)
-extern void DIVA_DIDD_Read(void *, int);
-
static dword notify_handle;
static DESCRIPTOR DAdapter;
static DESCRIPTOR MAdapter;
--
1.7.9.5
next prev parent reply other threads:[~2014-02-07 12:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 12:18 [PATCH 01/26] drivers: isdn: Rectify typing error in xdi_msg.h Rashika Kheria
2014-02-07 12:19 ` [PATCH 02/26] drivers: isdn: Move prototype declaration to header file um_idi.h from um_idi.c Rashika Kheria
2014-02-07 12:20 ` [PATCH 03/26] drivers: isdn: Move prototype declarations to header file um_idi.h from idifunc.c Rashika Kheria
2014-02-07 12:21 ` [PATCH 04/26] drivers: isdn: Add prototype declaration to header file platform.h from capifunc.c Rashika Kheria
2014-02-07 12:24 ` [PATCH 05/26] drivers: isdn: Move prototype declarations to header file capifunc.h from message.c Rashika Kheria
2014-02-07 12:25 ` [PATCH 06/26] drivers: isdn: Move prototype declarations to header file capifunc.h from capifunc.c and message.c Rashika Kheria
2014-02-07 12:26 ` [PATCH 07/26] drivers: isdn: Move prototype declaration to header file platform.h from divasproc.c Rashika Kheria
2014-02-07 12:27 ` [PATCH 08/26] drivers: isdn: Move prototype declaration to header file platform.h from divasmain.c and divasproc.c Rashika Kheria
2014-02-07 12:28 ` [PATCH 09/26] drivers: isdn: Include appropriate header file in diva.c Rashika Kheria
2014-02-07 12:29 ` [PATCH 10/26] drivers: isdn: Move prototype declaration to appropriate header file diva.h Rashika Kheria
2014-02-07 12:33 ` [PATCH 11/26] drivers: isdn: Move prototype declarations to header file platform.h from mntfunc.c Rashika Kheria
2014-02-07 12:34 ` [PATCH 12/26] drivers: isdn: Mark functions as static and remove unused function in hfcmulti.c Rashika Kheria
2014-02-07 12:35 ` [PATCH 13/26] drivers: isdn: Mark functions as static in avmfritz.c Rashika Kheria
2014-02-07 12:36 ` [PATCH 14/26] drivers: isdn: Mark function as static in w6692.c Rashika Kheria
2014-02-07 12:37 ` [PATCH 15/26] drivers: isdn: Mark function as static in mISDNipac.c Rashika Kheria
2014-02-07 12:38 ` [PATCH 16/26] drivers: isdn: Move prototype declarations to appropriate header file hscx.h from elsa_ser.c Rashika Kheria
2014-02-07 12:39 ` [PATCH 17/26] drivers: isdn: Move prototype declaration to header file platform.h from divasi.c Rashika Kheria
2014-02-07 12:41 ` [PATCH 18/26] drivers: isdn: Mark functions as static in layer2.c Rashika Kheria
2014-02-07 12:42 ` [PATCH 19/26] drivers: isdn: Move prototype declaration to header file platform.h from diva_didd.c Rashika Kheria
2014-02-07 13:33 ` David Laight
2014-02-07 17:15 ` Josh Triplett
2014-02-07 17:22 ` David Laight
2014-02-07 17:41 ` Josh Triplett
2014-02-07 12:43 ` [PATCH 20/26] drivers: isdn: Move prototype declaration to header file platform.h from os_bri.c Rashika Kheria
2014-02-07 12:44 ` [PATCH 21/26] drivers: isdn: Move prototype declaration to header file platform.h from os_4bri.c Rashika Kheria
2014-02-07 12:45 ` [PATCH 22/26] drivers: isdn: Move prototype declaration to header file platform.h from os_pri.c Rashika Kheria
2014-02-07 12:46 ` [PATCH 23/26] drivers: isdn: Move prototype declaration to header file platform.h from divamnt.c Rashika Kheria
2014-02-07 12:47 ` [PATCH 24/26] drivers: isdn: Move prototype declaration to header file hisax.h from config.c Rashika Kheria
2014-02-07 12:48 ` Rashika Kheria [this message]
2014-02-07 12:49 ` [PATCH 26/26] drivers: isdn: Move prototype declaration to header file platform.h from divasmain.c Rashika Kheria
2014-02-07 18:48 ` [PATCH 01/26] drivers: isdn: Rectify typing error in xdi_msg.h Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa09a161cd57206bfac7f3ea2817fb6d535c727c.1390408520.git.rashika.kheria@gmail.com \
--to=rashika.kheria@gmail.com \
--cc=isdn@linux-pingi.de \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mac@melware.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).