From: David Hildenbrand <david@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Sasha Levin <sasha.levin@oracle.com>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Jerome Marchand <jmarchan@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Hugh Dickins <hughd@google.com>, Jason Gunthorpe <jgg@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>,
Yang Shi <shy828301@gmail.com>
Subject: Re: [PATCH v1] mm/gup: adjust stale comment for RCU GUP-fast
Date: Thu, 1 Sep 2022 18:34:41 +0200 [thread overview]
Message-ID: <fa0bb4b1-3edd-eb5a-7ad6-dff785d88d8f@redhat.com> (raw)
In-Reply-To: <YxDdycTur733hMgt@xz-m1.local>
On 01.09.22 18:28, Peter Xu wrote:
> On Thu, Sep 01, 2022 at 09:21:19AM +0200, David Hildenbrand wrote:
>> commit 4b471e8898c3 ("mm, thp: remove infrastructure for handling splitting
>> PMDs") didn't remove all details about the THP split requirements for
>> RCU GUP-fast.
>>
>> IPI broeadcasts on THP split are no longer required.
>>
>> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>> Cc: Sasha Levin <sasha.levin@oracle.com>
>> Cc: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>> Cc: Vlastimil Babka <vbabka@suse.cz>
>> Cc: Jerome Marchand <jmarchan@redhat.com>
>> Cc: Andrea Arcangeli <aarcange@redhat.com>
>> Cc: Hugh Dickins <hughd@google.com>
>> Cc: Jason Gunthorpe <jgg@nvidia.com>
>> Cc: John Hubbard <jhubbard@nvidia.com>
>> Cc: Peter Xu <peterx@redhat.com>
>> Cc: Yang Shi <shy828301@gmail.com>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> ---
>> mm/gup.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/mm/gup.c b/mm/gup.c
>> index 5abdaf487460..cfe71f422787 100644
>> --- a/mm/gup.c
>> +++ b/mm/gup.c
>> @@ -2309,9 +2309,8 @@ EXPORT_SYMBOL(get_user_pages_unlocked);
>> *
>> * Another way to achieve this is to batch up page table containing pages
>> * belonging to more than one mm_user, then rcu_sched a callback to free those
>> - * pages. Disabling interrupts will allow the fast_gup walker to both block
>> - * the rcu_sched callback, and an IPI that we broadcast for splitting THPs
>> - * (which is a relatively rare event). The code below adopts this strategy.
>> + * pages. Disabling interrupts will allow the fast_gup walker to block the
>> + * rcu_sched callback.
>
> This is the comment for fast-gup in general but not only for thp split.
"an IPI that we broadcast for splitting THP" is about splitting THP.
>
> I can understand that we don't need IPI for thp split, but isn't the IPIs
> still needed for thp collapse (aka pmdp_collapse_flush)?
That was, unfortunately, never documented -- and as discussed in the
other thread, arm64 doesn't do that IPI before collapse and might need
fixing. We'll most probably end up getting rid of that
(undocumented/forgotten) IPI requirement and fix it in GUP-fast by
re-rechecking if the PMD changed.
Thanks!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-09-01 16:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 7:21 [PATCH v1] mm/gup: adjust stale comment for RCU GUP-fast David Hildenbrand
2022-09-01 14:37 ` Kirill A . Shutemov
2022-09-01 16:12 ` Jason Gunthorpe
2022-09-01 16:30 ` David Hildenbrand
2022-09-01 16:28 ` Peter Xu
2022-09-01 16:34 ` David Hildenbrand [this message]
2022-09-01 16:40 ` Peter Xu
2022-09-01 16:46 ` David Hildenbrand
2022-09-01 17:41 ` Peter Xu
2022-09-01 17:44 ` David Hildenbrand
2022-09-01 17:50 ` Yang Shi
2022-09-01 18:07 ` Peter Xu
2022-09-01 18:35 ` Yang Shi
2022-09-02 6:32 ` David Hildenbrand
2022-09-02 13:53 ` Peter Xu
2022-09-02 15:37 ` Yang Shi
2022-09-04 16:52 ` Aneesh Kumar K V
2022-09-05 8:38 ` David Hildenbrand
2022-09-05 8:41 ` Aneesh Kumar K V
2022-09-04 16:49 ` Aneesh Kumar K V
2022-09-05 8:02 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa0bb4b1-3edd-eb5a-7ad6-dff785d88d8f@redhat.com \
--to=david@redhat.com \
--cc=aarcange@redhat.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=hughd@google.com \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=jmarchan@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=shy828301@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).