From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Fabio Estevam <fabio.estevam@freescale.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pyra-handheld.com, letux-kernel@openphoenux.org
Subject: [PATCH 1/5] input: twl6040-vibra: fix DT node memory management
Date: Mon, 18 Apr 2016 21:55:37 +0200 [thread overview]
Message-ID: <fa39d5e67bd71ba0cde980313747f5b4d2f9be94.1461009340.git.hns@goldelico.com> (raw)
In-Reply-To: <cover.1461009340.git.hns@goldelico.com>
In-Reply-To: <cover.1461009340.git.hns@goldelico.com>
commit e7ec014a47e4 ("Input: twl6040-vibra - update for device tree support")
made the separate vibra DT node to a subnode of the twl6040.
It now calls of_find_node_by_name() to locate the "vibra" subnode.
This function has a side effect to call of_node_put on() for the twl6040
parent node passed in as a parameter. This causes trouble later on.
Solution: we must call of_node_get() before of_find_node_by_name()
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
drivers/input/misc/twl6040-vibra.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/misc/twl6040-vibra.c b/drivers/input/misc/twl6040-vibra.c
index ea63fad..7221a00 100644
--- a/drivers/input/misc/twl6040-vibra.c
+++ b/drivers/input/misc/twl6040-vibra.c
@@ -262,6 +262,7 @@ static int twl6040_vibra_probe(struct platform_device *pdev)
int vddvibr_uV = 0;
int error;
+ of_node_get(twl6040_core_dev->of_node);
twl6040_core_node = of_find_node_by_name(twl6040_core_dev->of_node,
"vibra");
if (!twl6040_core_node) {
--
2.7.3
next prev parent reply other threads:[~2016-04-18 19:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 19:55 [PATCH 0/5] fixes for twl6040-vibra H. Nikolaus Schaller
2016-04-18 19:55 ` H. Nikolaus Schaller [this message]
2016-04-18 21:22 ` [PATCH 1/5] input: twl6040-vibra: fix DT node memory management Dmitry Torokhov
2016-04-19 7:43 ` H. Nikolaus Schaller
2016-04-19 17:06 ` Dmitry Torokhov
2016-04-20 9:03 ` H. Nikolaus Schaller
2016-05-08 6:49 ` [Kernel] " H. Nikolaus Schaller
2016-05-10 0:02 ` Dmitry Torokhov
2016-04-18 19:55 ` [PATCH 2/5] input: twl6040-vibra: add handler to unregister input if module is removed H. Nikolaus Schaller
2016-04-18 21:12 ` Dmitry Torokhov
2016-04-19 7:33 ` H. Nikolaus Schaller
2016-04-19 7:57 ` Dmitry Torokhov
2016-04-19 8:05 ` H. Nikolaus Schaller
2016-04-19 16:53 ` Dmitry Torokhov
2016-04-20 9:12 ` H. Nikolaus Schaller
2016-04-18 19:55 ` [PATCH 3/5] input: twl6040-vibra: fix NULL pointer dereference by removing workqueue H. Nikolaus Schaller
2016-04-18 21:47 ` Dmitry Torokhov
2016-04-18 19:55 ` [PATCH 4/5] input: twl6040-vibra: ignore return value of schedule_work H. Nikolaus Schaller
2016-04-18 21:47 ` Dmitry Torokhov
2016-04-18 19:55 ` [PATCH 5/5] input: twl6040-vibra: remove mutex H. Nikolaus Schaller
2016-04-18 21:20 ` Dmitry Torokhov
2016-04-19 7:49 ` H. Nikolaus Schaller
2016-04-19 8:01 ` Dmitry Torokhov
2016-04-19 8:08 ` H. Nikolaus Schaller
2016-04-20 9:22 ` [Letux-kernel] " H. Nikolaus Schaller
2016-04-20 17:49 ` Dmitry Torokhov
2016-04-20 18:10 ` H. Nikolaus Schaller
2016-04-20 18:15 ` Dmitry Torokhov
2016-04-20 19:00 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa39d5e67bd71ba0cde980313747f5b4d2f9be94.1461009340.git.hns@goldelico.com \
--to=hns@goldelico.com \
--cc=dmitry.torokhov@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).