From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77B31C433E2 for ; Wed, 2 Sep 2020 08:14:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 482C92087C for ; Wed, 2 Sep 2020 08:14:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599034449; bh=5D9PpWt9bWuDNc203FjduFMM/5rtLKQAc3pFFPBSd7s=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=pBBs1jiT/iGznf2StRd7ntWq+ctVXEiTDK5Z0ompCuaYSiOFNypa360kyTd6bYV7z G9L9s+ZjK72EccKSw78g+vhJjUeCwDv8kTmULhCDKc7+y1AkVjX1UqFy6cj4m7FuvL Zn/SXFQ9a8GZeJZ97vtUr++PHiLsdB+BLDmCUuNw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726586AbgIBIOI (ORCPT ); Wed, 2 Sep 2020 04:14:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:36546 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbgIBIOH (ORCPT ); Wed, 2 Sep 2020 04:14:07 -0400 Received: from [192.168.0.50] (89-70-52-201.dynamic.chello.pl [89.70.52.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 29E232072A; Wed, 2 Sep 2020 08:14:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599034446; bh=5D9PpWt9bWuDNc203FjduFMM/5rtLKQAc3pFFPBSd7s=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=La76+VbBkCekCKyKhOMiO4ukzogPXQcPXmTsjW7CUn9XuTVaaKXRgbg3u/h5UPNUg QDS9DQeALQK2dw8H2YN/NHsXzgeLwX5h5dOhachsvz6725rDAKReavMhrfX3f08oyk /naVL0/Hw7IwW/K/aFlHGMDNDoaXa0wVYHhIJRQo= Subject: Re: [PATCH v2 6/9] spi: spi-s3c64xx: Check return values To: Lukasz Stelmach Cc: Kukjin Kim , Krzysztof Kozlowski , Andi Shyti , Mark Brown , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com References: From: Sylwester Nawrocki Message-ID: Date: Wed, 2 Sep 2020 10:14:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/1/20 17:21, Lukasz Stelmach wrote: > It was <2020-08-25 wto 21:06>, when Sylwester Nawrocki wrote: >> On 8/21/20 18:13, Łukasz Stelmach wrote: >>> Check return values in prepare_dma() and s3c64xx_spi_config() and >>> propagate errors upwards. >>> >>> Signed-off-by: Łukasz Stelmach >>> --- >>> drivers/spi/spi-s3c64xx.c | 47 ++++++++++++++++++++++++++++++++------- >>> 1 file changed, 39 insertions(+), 8 deletions(-) >> >>> @@ -298,12 +299,24 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma, >>> desc = dmaengine_prep_slave_sg(dma->ch, sgt->sgl, sgt->nents, >>> dma->direction, DMA_PREP_INTERRUPT); >>> + if (!desc) { >>> + dev_err(&sdd->pdev->dev, "unable to prepare %s scatterlist", >>> + dma->direction == DMA_DEV_TO_MEM ? "rx" : "tx"); >>> + return -ENOMEM; >>> + } >>> desc->callback = s3c64xx_spi_dmacb; >>> desc->callback_param = dma; >>> dma->cookie = dmaengine_submit(desc); >>> + ret = dma_submit_error(dma->cookie); >>> + if (ret) { >>> + dev_err(&sdd->pdev->dev, "DMA submission failed"); >>> + return -EIO; >> >> Just return the error value from dma_submit_error() here? >> > > --8<---------------cut here---------------start------------->8--- > static inline int dma_submit_error(dma_cookie_t cookie) > { > return cookie < 0 ? cookie : 0; > > } > --8<---------------cut here---------------end--------------->8--- > > Not quite meaningful IMHO, is it? dma_submit_error() returns 0 or an error code, I think it makes sense to propagate that error code rather than replacing it with -EIO.