From: Vincent Knecht <vincent.knecht@mailoo.org>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
obayerd@eurocomposant.fr, phone-devel@vger.kernel.org,
stephan@gerhold.net, linux-kernel@vger.kernel.org,
tiwai@suse.com, lgirdwood@gmail.com, robh+dt@kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 2/2] ASoC: Add AK4375 support
Date: Tue, 14 Dec 2021 19:28:19 +0100 [thread overview]
Message-ID: <fa40932c2dfbfcbdefa976f9609bdfca10fdd9cf.camel@mailoo.org> (raw)
In-Reply-To: <YbeZ37FLnAsMfrDl@sirena.org.uk>
Le lundi 13 décembre 2021 à 19:07 +0000, Mark Brown a écrit :
> On Mon, Dec 13, 2021 at 04:59:12PM +0100, Vincent Knecht wrote:
>
> > AK4375 is a 32-bit stereo DAC with headphones amplifier.
> > There's no documentation for it on akm.com, and only a brief
> > datasheet can be found floating on the internets [1].
>
> This driver looks relatively clean but it's in *serious* need of
> modernisation, there's issues here that haven't been present upstream
> for a very long time. Fortunately they're mostly style things so it
> should be relatively easy to handle.
Thank you Mark for this review, hopefully I'll fix all points
and submit a v2 within a week or so.
next prev parent reply other threads:[~2021-12-14 18:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 15:59 [PATCH 1/2] ASoC: dt-bindings: codecs: Add bindings for ak4375 Vincent Knecht
2021-12-13 15:59 ` [PATCH 2/2] ASoC: Add AK4375 support Vincent Knecht
2021-12-13 19:07 ` Mark Brown
2021-12-14 18:28 ` Vincent Knecht [this message]
2021-12-13 15:59 ` [PATCH 1/2] ASoC: dt-bindings: codecs: Add bindings for ak4375 Vincent Knecht
2021-12-15 20:20 ` Rob Herring
2021-12-13 15:59 ` [PATCH 2/2] ASoC: Add AK4375 support Vincent Knecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa40932c2dfbfcbdefa976f9609bdfca10fdd9cf.camel@mailoo.org \
--to=vincent.knecht@mailoo.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=obayerd@eurocomposant.fr \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=tiwai@suse.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).