From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Sebastian Reichel <sre@kernel.org>,
Gwendal Grignou <gwendal@chromium.org>,
Sameer Nanda <snanda@chromium.org>,
linux-pm@vger.kernel.org, Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org, Benson Leung <bleung@chromium.org>,
miguel.ojeda.sandonis@gmail.com
Subject: Re: [PATCH v2 3/3] mfd: cros_ec_dev: Register cros_usbpd-charger driver as a subdevice.
Date: Wed, 2 May 2018 11:42:23 +0200 [thread overview]
Message-ID: <fa4f27ca-00ab-22e5-a693-401344797eb9@collabora.com> (raw)
In-Reply-To: <20180501083229.GL5147@dell>
Hi Lee,
On 01/05/18 10:32, Lee Jones wrote:
> On Mon, 30 Apr 2018, Enric Balletbo i Serra wrote:
>
>> Check whether this EC instance has USBPD host command support and
>> instatiate the cros_usbpd-charger driver as a subdevice in such case.
>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> ---
>>
>> Changes in v2:
>> - [3/3] Use ARRAY_SIZE instead of hardcoded 1.
>>
>> drivers/mfd/cros_ec_dev.c | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>
> Patch looks good to me.
>
> Does it depend on any of the other patches in the series?
>
No, it only depends on [1] to apply cleanly (mentioned in the cover letter). I
think that [1] is close to be picked. If this is not the case I can rebase
without this dependency.
[1] https://lkml.org/lkml/2018/4/18/229
Best regards,
Enric
> For my own reference:
> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
>
prev parent reply other threads:[~2018-05-02 9:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 13:14 [PATCH v2 0/3] mfd/power: cros_ec: add support for USBPD charger driver Enric Balletbo i Serra
2018-04-30 13:14 ` [PATCH v2 1/3] mfd: cros_ec: Add USBPD charger commands and struct definitions Enric Balletbo i Serra
2018-05-01 8:29 ` Lee Jones
2018-05-02 9:33 ` Enric Balletbo i Serra
2018-05-02 9:56 ` Lee Jones
2018-04-30 13:14 ` [PATCH v2 2/3] power: supply: add cros-ec USBPD charger driver Enric Balletbo i Serra
2018-04-30 13:20 ` Miguel Ojeda
2018-04-30 13:37 ` Enric Balletbo Serra
2018-05-01 8:29 ` Lee Jones
2018-05-01 12:17 ` Sebastian Reichel
2018-05-01 13:27 ` Lee Jones
2018-04-30 13:14 ` [PATCH v2 3/3] mfd: cros_ec_dev: Register cros_usbpd-charger driver as a subdevice Enric Balletbo i Serra
2018-05-01 8:32 ` Lee Jones
2018-05-02 9:42 ` Enric Balletbo i Serra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa4f27ca-00ab-22e5-a693-401344797eb9@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=snanda@chromium.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).