From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org, Andrew Jeffery <andrew@aj.id.au>,
James Feist <james.feist@linux.intel.com>,
Jason M Biils <jason.m.bills@linux.intel.com>,
Joel Stanley <joel@jms.id.au>,
Vernon Mauery <vernon.mauery@linux.intel.com>
Subject: Re: [PATCH linux-next v5 07/13] dt-bindings: mfd: Add a document for PECI client mfd
Date: Mon, 18 Jun 2018 10:11:58 -0700 [thread overview]
Message-ID: <fa5a5714-f363-93df-4314-a140eb85747a@linux.intel.com> (raw)
In-Reply-To: <20180618060306.GD31141@dell>
On 6/17/2018 11:03 PM, Lee Jones wrote:
> On Thu, 14 Jun 2018, Jae Hyun Yoo wrote:
>
> [...]
>
>>>> +Example:
>>>> + peci-bus@0 {
>>>
>>> 0?
>>>
>>
>> Because the actual reg value of the peci bus is reg = <0x0 0x60> but
>> anyway it's an example.
>>
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>
>>> No 'reg' property?
>
> 0 is fine, but you really should have a 'reg' property.
>
Okay, I'll add reg setting example.
>> This is the actual peci bus node which is a parent of this MFD node:
>> peci0: peci-bus@0 {
>> compatible = "aspeed,ast2500-peci";
>> reg = <0x0 0x60>;
>> #address-cells = <1>;
>> #size-cells = <0>;
>> interrupts = <15>;
>> clocks = <&syscon ASPEED_CLK_GATE_REFCLK>;
>> resets = <&syscon ASPEED_RESET_PECI>;
>> clock-frequency = <24000000>;
>> msg-timing = <1>;
>> addr-timing = <1>;
>> rd-sampling-point = <8>;
>> cmd-timeout-ms = <1000>;
>> };
>>
>>>> + < more properties >
>>>
>>> Remove this.
>>
>> I dropped all other properties into < more properties > because I want
>> to show the #address-cells and #size-cells to state its sub-nodes
>> should have a single unique reg value. Should I remove this line or the
>> whole parent node?
>
> Just drop the properties which are unimportant for the example. You
> do not need to replace them with anything, especially with a non-DT
> compliant string.
>
Okay, I'll fix it. Thanks a lot!
>>>> + peci-client@30 {
>>>> + compatible = "intel,peci-client", "simple-mfd";
>>>> + reg = <0x30>;
>>>> + };
>>>> +
>>>> + peci-client@31 {
>>>> + compatible = "intel,peci-client", "simple-mfd";
>>>> + reg = <0x31>;
>>>> + };
>>>> + };
>>>
>
prev parent reply other threads:[~2018-06-18 17:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 18:22 [PATCH linux-next v5 07/13] dt-bindings: mfd: Add a document for PECI client mfd Jae Hyun Yoo
2018-06-13 6:16 ` Lee Jones
2018-06-14 17:25 ` Jae Hyun Yoo
2018-06-18 6:03 ` Lee Jones
2018-06-18 17:11 ` Jae Hyun Yoo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa5a5714-f363-93df-4314-a140eb85747a@linux.intel.com \
--to=jae.hyun.yoo@linux.intel.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=james.feist@linux.intel.com \
--cc=jason.m.bills@linux.intel.com \
--cc=joel@jms.id.au \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=vernon.mauery@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).